polish

Author: Bilal Al

splitio/engine/evaluator.py

@@ -68,7 +68,7 @@ def eval_with_context(self, key, bucketing, feature_name, attrs, ctx):
                 'label': label,
                 'change_number': _change_number
             },
-            'impressions_disabled': feature.ImpressionsDisabled if feature else None
+            'impressions_disabled': feature.impressionsDisabled if feature else None
         }
 
     def _treatment_for_flag(self, flag, key, bucketing, attributes, ctx):

splitio/models/splits.py

@@ -10,7 +10,7 @@
 
 SplitView = namedtuple(
     'SplitView',
-    ['name', 'traffic_type', 'killed', 'treatments', 'change_number', 'configs', 'default_treatment', 'sets', 'ImpressionsDisabled']
+    ['name', 'traffic_type', 'killed', 'treatments', 'change_number', 'configs', 'default_treatment', 'sets', 'impressions_disabled']
 )
 
 _DEFAULT_CONDITIONS_TEMPLATE =   {
@@ -74,7 +74,7 @@ def __init__(  # pylint: disable=too-many-arguments
             traffic_allocation_seed=None,
             configurations=None,
             sets=None,
-            ImpressionsDisabled=None
+            impressionsDisabled=None
     ):
         """
         Class constructor.
@@ -97,8 +97,8 @@ def __init__(  # pylint: disable=too-many-arguments
         :type traffic_allocation_seed: int
         :pram sets: list of flag sets
         :type sets: list
-        :pram ImpressionsDisabled: track impressions flag
-        :type ImpressionsDisabled: boolean
+        :pram impressionsDisabled: track impressions flag
+        :type impressionsDisabled: boolean
         """
         self._name = name
         self._seed = seed
@@ -128,7 +128,7 @@ def __init__(  # pylint: disable=too-many-arguments
 
         self._configurations = configurations
         self._sets = set(sets) if sets is not None else set()
-        self._ImpressionsDisabled = ImpressionsDisabled if ImpressionsDisabled is not None else False
+        self._impressionsDisabled = impressionsDisabled if impressionsDisabled is not None else False
 
     @property
     def name(self):
@@ -191,9 +191,9 @@ def sets(self):
         return self._sets
 
     @property
-    def ImpressionsDisabled(self):
-        """Return ImpressionsDisabled of the split."""
-        return self._ImpressionsDisabled
+    def impressionsDisabled(self):
+        """Return impressionsDisabled of the split."""
+        return self._impressionsDisabled
 
     def get_configurations_for(self, treatment):
         """Return the mapping of treatments to configurations."""
@@ -224,7 +224,7 @@ def to_json(self):
             'conditions': [c.to_json() for c in self.conditions],
             'configurations': self._configurations,
             'sets': list(self._sets),
-            'ImpressionsDisabled': self._ImpressionsDisabled
+            'impressionsDisabled': self._impressionsDisabled
         }
 
     def to_split_view(self):
@@ -243,7 +243,7 @@ def to_split_view(self):
             self._configurations if self._configurations is not None else {},
             self._default_treatment,
             list(self._sets) if self._sets is not None else [],
-            self._ImpressionsDisabled
+            self._impressionsDisabled
         )
 
     def local_kill(self, default_treatment, change_number):
@@ -300,5 +300,5 @@ def from_raw(raw_split):
         traffic_allocation_seed=raw_split.get('trafficAllocationSeed'),
         configurations=raw_split.get('configurations'),
         sets=set(raw_split.get('sets')) if raw_split.get('sets') is not None else [],
-        ImpressionsDisabled=raw_split.get('ImpressionsDisabled') if raw_split.get('ImpressionsDisabled') is not None else False
+        impressionsDisabled=raw_split.get('impressionsDisabled') if raw_split.get('impressionsDisabled') is not None else False
     )

splitio/recorder/recorder.py

@@ -174,9 +174,8 @@ def record_treatment_stats(self, impressions_decorated, latency, operation, meth
                 self._imp_counter.track(for_counter)
             if len(for_unique_keys_tracker) > 0:
                 [self._unique_keys_tracker.track(item[0], item[1]) for item in for_unique_keys_tracker]
-        except Exception as exc:  # pylint: disable=broad-except
+        except Exception:  # pylint: disable=broad-except
             _LOGGER.error('Error recording impressions')
-            _LOGGER.error(exc)
             _LOGGER.debug('Error: ', exc_info=True)
 
     def record_track_stats(self, event, latency):

tests/engine/test_evaluator.py

@@ -52,7 +52,7 @@ def test_evaluate_treatment_ok(self, mocker):
         assert result['impression']['change_number'] == 123
         assert result['impression']['label'] == 'some_label'
         assert mocked_split.get_configurations_for.mock_calls == [mocker.call('on')]
-        assert result['impressions_disabled'] == mocked_split.ImpressionsDisabled
+        assert result['impressions_disabled'] == mocked_split.impressionsDisabled
 
 
     def test_evaluate_treatment_ok_no_config(self, mocker):

tests/integration/__init__.py

@@ -1,7 +1,7 @@
 split11 = {"splits": [
-    {"trafficTypeName": "user", "name": "SPLIT_2","trafficAllocation": 100,"trafficAllocationSeed": 1057590779, "seed": -113875324, "status": "ACTIVE","killed": False, "defaultTreatment": "off", "changeNumber": 1675443569027,"algo": 2, "configurations": {},"conditions": [{"conditionType": "ROLLOUT","matcherGroup": {"combiner": "AND","matchers": [{"keySelector": { "trafficType": "user", "attribute": None },"matcherType": "ALL_KEYS","negate": False,"userDefinedSegmentMatcherData": None,"whitelistMatcherData": None,"unaryNumericMatcherData": None,"betweenMatcherData": None,"booleanMatcherData": None,"dependencyMatcherData": None,"stringMatcherData": None}]},"partitions": [{ "treatment": "on", "size": 100 },{ "treatment": "off", "size": 0 }],"label": "default rule"}], "sets": ["set_1"], "ImpressionsDisabled": False},
+    {"trafficTypeName": "user", "name": "SPLIT_2","trafficAllocation": 100,"trafficAllocationSeed": 1057590779, "seed": -113875324, "status": "ACTIVE","killed": False, "defaultTreatment": "off", "changeNumber": 1675443569027,"algo": 2, "configurations": {},"conditions": [{"conditionType": "ROLLOUT","matcherGroup": {"combiner": "AND","matchers": [{"keySelector": { "trafficType": "user", "attribute": None },"matcherType": "ALL_KEYS","negate": False,"userDefinedSegmentMatcherData": None,"whitelistMatcherData": None,"unaryNumericMatcherData": None,"betweenMatcherData": None,"booleanMatcherData": None,"dependencyMatcherData": None,"stringMatcherData": None}]},"partitions": [{ "treatment": "on", "size": 100 },{ "treatment": "off", "size": 0 }],"label": "default rule"}], "sets": ["set_1"], "impressionsDisabled": False},
     {"trafficTypeName": "user", "name": "SPLIT_1", "trafficAllocation": 100, "trafficAllocationSeed": -1780071202,"seed": -1442762199, "status": "ACTIVE","killed": False, "defaultTreatment": "off", "changeNumber": 1675443537882,"algo": 2, "configurations": {},"conditions": [{"conditionType": "ROLLOUT", "matcherGroup": {"combiner": "AND","matchers": [{"keySelector": { "trafficType": "user", "attribute": None },"matcherType": "ALL_KEYS","negate": False,"userDefinedSegmentMatcherData": None,"whitelistMatcherData": None,"unaryNumericMatcherData": None,"betweenMatcherData": None,"booleanMatcherData": None,"dependencyMatcherData": None,"stringMatcherData": None}]},"partitions": [{ "treatment": "on", "size": 0 },{ "treatment": "off", "size": 100 }],"label": "default rule"}], "sets": ["set_1", "set_2"]},
-    {"trafficTypeName": "user", "name": "SPLIT_3","trafficAllocation": 100,"trafficAllocationSeed": 1057590779, "seed": -113875324, "status": "ACTIVE","killed": False, "defaultTreatment": "off", "changeNumber": 1675443569027,"algo": 2, "configurations": {},"conditions": [{"conditionType": "ROLLOUT","matcherGroup": {"combiner": "AND","matchers": [{"keySelector": { "trafficType": "user", "attribute": None },"matcherType": "ALL_KEYS","negate": False,"userDefinedSegmentMatcherData": None,"whitelistMatcherData": None,"unaryNumericMatcherData": None,"betweenMatcherData": None,"booleanMatcherData": None,"dependencyMatcherData": None,"stringMatcherData": None}]},"partitions": [{ "treatment": "on", "size": 100 },{ "treatment": "off", "size": 0 }],"label": "default rule"}], "sets": ["set_1"], "ImpressionsDisabled": True}
+    {"trafficTypeName": "user", "name": "SPLIT_3","trafficAllocation": 100,"trafficAllocationSeed": 1057590779, "seed": -113875324, "status": "ACTIVE","killed": False, "defaultTreatment": "off", "changeNumber": 1675443569027,"algo": 2, "configurations": {},"conditions": [{"conditionType": "ROLLOUT","matcherGroup": {"combiner": "AND","matchers": [{"keySelector": { "trafficType": "user", "attribute": None },"matcherType": "ALL_KEYS","negate": False,"userDefinedSegmentMatcherData": None,"whitelistMatcherData": None,"unaryNumericMatcherData": None,"betweenMatcherData": None,"booleanMatcherData": None,"dependencyMatcherData": None,"stringMatcherData": None}]},"partitions": [{ "treatment": "on", "size": 100 },{ "treatment": "off", "size": 0 }],"label": "default rule"}], "sets": ["set_1"], "impressionsDisabled": True}
     ],"since": -1,"till": 1675443569027}
 split12 = {"splits": [{"trafficTypeName": "user","name": "SPLIT_2","trafficAllocation": 100,"trafficAllocationSeed": 1057590779,"seed": -113875324,"status": "ACTIVE","killed": True,"defaultTreatment": "off","changeNumber": 1675443767288,"algo": 2,"configurations": {},"conditions": [{"conditionType": "ROLLOUT","matcherGroup": {"combiner": "AND","matchers": [{"keySelector": { "trafficType": "user", "attribute": None },"matcherType": "ALL_KEYS","negate": False,"userDefinedSegmentMatcherData": None,"whitelistMatcherData": None,"unaryNumericMatcherData": None,"betweenMatcherData": None,"booleanMatcherData": None,"dependencyMatcherData": None,"stringMatcherData": None}]},"partitions": [{ "treatment": "on", "size": 100 },{ "treatment": "off", "size": 0 }],"label": "default rule"}]}],"since": 1675443569027,"till": 167544376728}
 split13 = {"splits": [

tests/models/test_splits.py

@@ -61,7 +61,7 @@ class SplitTests(object):
             'on': '{"color": "blue", "size": 13}'
         },
         'sets': ['set1', 'set2'],
-        'ImpressionsDisabled': False
+        'impressionsDisabled': False
     }
 
     def test_from_raw(self):
@@ -82,7 +82,7 @@ def test_from_raw(self):
         assert parsed.get_configurations_for('on') == '{"color": "blue", "size": 13}'
         assert parsed._configurations == {'on': '{"color": "blue", "size": 13}'}
         assert parsed.sets == {'set1', 'set2'}
-        assert parsed.ImpressionsDisabled == False
+        assert parsed.impressionsDisabled == False
 
     def test_get_segment_names(self, mocker):
         """Test fetching segment names."""
@@ -109,7 +109,7 @@ def test_to_json(self):
         assert as_json['algo'] == 2
         assert len(as_json['conditions']) == 2
         assert sorted(as_json['sets']) == ['set1', 'set2']
-        assert as_json['ImpressionsDisabled'] is False
+        assert as_json['impressionsDisabled'] is False
 
     def test_to_split_view(self):
         """Test SplitView creation."""
@@ -121,7 +121,7 @@ def test_to_split_view(self):
         assert as_split_view.traffic_type == self.raw['trafficTypeName']
         assert set(as_split_view.treatments) == set(['on', 'off'])
         assert sorted(as_split_view.sets) == sorted(list(self.raw['sets']))
-        assert as_split_view.ImpressionsDisabled == self.raw['ImpressionsDisabled']
+        assert as_split_view.impressions_disabled == self.raw['impressionsDisabled']
 
     def test_incorrect_matcher(self):
         """Test incorrect matcher in split model parsing."""