Skip to content

Commit 1ad41ce

Browse files
author
Bilal Al
committed
polish
1 parent 672b417 commit 1ad41ce

File tree

5 files changed

+34
-25
lines changed

5 files changed

+34
-25
lines changed

splitio/models/telemetry.py

Lines changed: 24 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -255,9 +255,10 @@ class MethodLatenciesAsync(MethodLatenciesBase):
255255
Method async Latency class
256256
257257
"""
258-
async def create():
258+
@classmethod
259+
async def create(cls):
259260
"""Constructor"""
260-
self = MethodLatenciesAsync()
261+
self = cls()
261262
self._lock = asyncio.Lock()
262263
async with self._lock:
263264
self._reset_all()
@@ -406,9 +407,10 @@ class HTTPLatenciesAsync(HTTPLatenciesBase):
406407
HTTP Latency async class
407408
408409
"""
409-
async def create():
410+
@classmethod
411+
async def create(cls):
410412
"""Constructor"""
411-
self = HTTPLatenciesAsync()
413+
self = cls()
412414
self._lock = asyncio.Lock()
413415
async with self._lock:
414416
self._reset_all()
@@ -557,9 +559,10 @@ class MethodExceptionsAsync(MethodExceptionsBase):
557559
Method async exceptions class
558560
559561
"""
560-
async def create():
562+
@classmethod
563+
async def create(cls):
561564
"""Constructor"""
562-
self = MethodExceptionsAsync()
565+
self = cls()
563566
self._lock = asyncio.Lock()
564567
async with self._lock:
565568
self._reset_all()
@@ -707,9 +710,10 @@ class LastSynchronizationAsync(LastSynchronizationBase):
707710
Last Synchronization async info class
708711
709712
"""
710-
async def create():
713+
@classmethod
714+
async def create(cls):
711715
"""Constructor"""
712-
self = LastSynchronizationAsync()
716+
self = cls()
713717
self._lock = asyncio.Lock()
714718
async with self._lock:
715719
self._reset_all()
@@ -869,9 +873,10 @@ class HTTPErrorsAsync(HTTPErrorsBase):
869873
Http error async class
870874
871875
"""
872-
async def create():
876+
@classmethod
877+
async def create(cls):
873878
"""Constructor"""
874-
self = HTTPErrorsAsync()
879+
self = cls()
875880
self._lock = asyncio.Lock()
876881
async with self._lock:
877882
self._reset_all()
@@ -1177,9 +1182,10 @@ class TelemetryCountersAsync(TelemetryCountersBase):
11771182
Counters async class
11781183
11791184
"""
1180-
async def create():
1185+
@classmethod
1186+
async def create(cls):
11811187
"""Constructor"""
1182-
self = TelemetryCountersAsync()
1188+
self = cls()
11831189
self._lock = asyncio.Lock()
11841190
async with self._lock:
11851191
self._reset_all()
@@ -1385,9 +1391,10 @@ class StreamingEventsAsync(object):
13851391
Streaming events async class
13861392
13871393
"""
1388-
async def create():
1394+
@classmethod
1395+
async def create(cls):
13891396
"""Constructor"""
1390-
self = StreamingEventsAsync()
1397+
self = cls()
13911398
self._lock = asyncio.Lock()
13921399
async with self._lock:
13931400
self._streaming_events = []
@@ -1803,9 +1810,10 @@ class TelemetryConfigAsync(TelemetryConfigBase):
18031810
Telemetry init config async class
18041811
18051812
"""
1806-
async def create():
1813+
@classmethod
1814+
async def create(cls):
18071815
"""Constructor"""
1808-
self = TelemetryConfigAsync()
1816+
self = cls()
18091817
self._lock = asyncio.Lock()
18101818
async with self._lock:
18111819
self._reset_all()

splitio/optional/loaders.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,4 @@ async def _anext(it):
1818
return await it.__anext__()
1919

2020
if sys.version_info.major < 3 or sys.version_info.minor < 10:
21-
anext = _anext
22-
else:
23-
anext = anext
21+
anext = _anext

splitio/storage/inmemmory.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1672,9 +1672,10 @@ def pop_update_from_sse(self, event):
16721672
class InMemoryTelemetryStorageAsync(InMemoryTelemetryStorageBase):
16731673
"""In-memory telemetry async storage."""
16741674

1675-
async def create():
1675+
@classmethod
1676+
async def create(cls):
16761677
"""Constructor"""
1677-
self = InMemoryTelemetryStorageAsync()
1678+
self = cls()
16781679
self._lock = asyncio.Lock()
16791680
self._method_exceptions = await MethodExceptionsAsync.create()
16801681
self._last_synchronization = await LastSynchronizationAsync.create()

splitio/storage/pluggable.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1539,7 +1539,8 @@ def record_ready_time(self, ready_time):
15391539
class PluggableTelemetryStorageAsync(PluggableTelemetryStorageBase):
15401540
"""Pluggable telemetry storage class."""
15411541

1542-
async def create(pluggable_adapter, sdk_metadata, prefix=None):
1542+
@classmethod
1543+
async def create(cls, pluggable_adapter, sdk_metadata, prefix=None):
15431544
"""
15441545
Class constructor.
15451546
@@ -1550,7 +1551,7 @@ async def create(pluggable_adapter, sdk_metadata, prefix=None):
15501551
:param prefix: optional, prefix to storage keys
15511552
:type prefix: str
15521553
"""
1553-
self = PluggableTelemetryStorageAsync()
1554+
self = cls()
15541555
self._pluggable_adapter = pluggable_adapter
15551556
self._sdk_metadata = sdk_metadata.sdk_version + '/' + sdk_metadata.instance_name + '/' + sdk_metadata.instance_ip
15561557
self._telemetry_config_key = 'SPLITIO.telemetry.init'

splitio/storage/redis.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1367,7 +1367,8 @@ def record_ready_time(self, ready_time):
13671367
class RedisTelemetryStorageAsync(RedisTelemetryStorageBase):
13681368
"""Redis based telemetry async storage class."""
13691369

1370-
async def create(redis_client, sdk_metadata):
1370+
@classmethod
1371+
async def create(cls, redis_client, sdk_metadata):
13711372
"""
13721373
Create instance and reset tags
13731374
@@ -1379,7 +1380,7 @@ async def create(redis_client, sdk_metadata):
13791380
:return: self instance.
13801381
:rtype: splitio.storage.redis.RedisTelemetryStorageAsync
13811382
"""
1382-
self = RedisTelemetryStorageAsync()
1383+
self = cls()
13831384
await self._reset_config_tags()
13841385
self._redis_client = redis_client
13851386
self._sdk_metadata = sdk_metadata

0 commit comments

Comments
 (0)