Skip to content

Commit 18fb7bb

Browse files
committed
polish
1 parent 2a871fa commit 18fb7bb

File tree

4 files changed

+11
-11
lines changed

4 files changed

+11
-11
lines changed

splitio/api/auth.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
from splitio.api.commons import headers_from_metadata, record_telemetry
88
from splitio.util.time import get_current_epoch_time_ms
99
from splitio.api.client import HttpClientException
10-
from splitio.models.token import decode_token
10+
from splitio.models.token import from_raw
1111
from splitio.models.telemetry import HTTPExceptionsAndLatencies
1212

1313
_LOGGER = logging.getLogger(__name__)
@@ -50,7 +50,7 @@ def authenticate(self):
5050
record_telemetry(response.status_code, get_current_epoch_time_ms() - start, HTTPExceptionsAndLatencies.TOKEN, self._telemetry_runtime_producer)
5151
if 200 <= response.status_code < 300:
5252
payload = json.loads(response.body)
53-
return decode_token(payload)
53+
return from_raw(payload)
5454
else:
5555
if (response.status_code >= 400 and response.status_code < 500):
5656
self._telemetry_runtime_producer.record_auth_rejections()

splitio/models/token.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ def iat(self):
5858
return self._iat
5959

6060

61-
def decode_token(raw_token):
61+
def from_raw(raw_token):
6262
"""
6363
Parse a new token from a raw token response.
6464

splitio/tasks/util/asynctask.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ def _execution_wrapper(self):
9494
_LOGGER.debug("Force execution signal received. Running now")
9595
if not _safe_run(self._main):
9696
_LOGGER.error("An error occurred when executing the task. "
97-
"Retrying after perio expires")
97+
"Retrying after period expires")
9898
continue
9999
except queue.Empty:
100100
# If no message was received, the timeout has expired
@@ -104,7 +104,7 @@ def _execution_wrapper(self):
104104
if not _safe_run(self._main):
105105
_LOGGER.error(
106106
"An error occurred when executing the task. "
107-
"Retrying after perio expires"
107+
"Retrying after period expires"
108108
)
109109
finally:
110110
self._cleanup()

tests/models/test_token.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,9 @@ class TokenTests(object):
88
"""Token model tests."""
99
raw_false = {'pushEnabled': False}
1010

11-
def test_decode_token_false(self):
11+
def test_from_raw_false(self):
1212
"""Test token model parsing."""
13-
parsed = token.decode_token(self.raw_false)
13+
parsed = token.from_raw(self.raw_false)
1414
assert parsed.push_enabled == False
1515
assert parsed.iat == None
1616
assert parsed.channels == None
@@ -22,9 +22,9 @@ def test_decode_token_false(self):
2222
'token': '',
2323
}
2424

25-
def test_decode_token_empty(self):
25+
def test_from_raw_empty(self):
2626
"""Test token model parsing."""
27-
parsed = token.decode_token(self.raw_empty)
27+
parsed = token.from_raw(self.raw_empty)
2828
assert parsed.push_enabled == False
2929
assert parsed.iat == None
3030
assert parsed.channels == None
@@ -36,9 +36,9 @@ def test_decode_token_empty(self):
3636
'token': 'eyJhbGciOiJIUzI1NiIsImtpZCI6IjVZOU05US45QnJtR0EiLCJ0eXAiOiJKV1QifQ.eyJ4LWFibHktY2FwYWJpbGl0eSI6IntcIk56TTJNREk1TXpjMF9NVGd5TlRnMU1UZ3dOZz09X3NlZ21lbnRzXCI6W1wic3Vic2NyaWJlXCJdLFwiTnpNMk1ESTVNemMwX01UZ3lOVGcxTVRnd05nPT1fc3BsaXRzXCI6W1wic3Vic2NyaWJlXCJdLFwiY29udHJvbF9wcmlcIjpbXCJzdWJzY3JpYmVcIixcImNoYW5uZWwtbWV0YWRhdGE6cHVibGlzaGVyc1wiXSxcImNvbnRyb2xfc2VjXCI6W1wic3Vic2NyaWJlXCIsXCJjaGFubmVsLW1ldGFkYXRhOnB1Ymxpc2hlcnNcIl19IiwieC1hYmx5LWNsaWVudElkIjoiY2xpZW50SWQiLCJleHAiOjE2MDIwODgxMjcsImlhdCI6MTYwMjA4NDUyN30.5_MjWonhs6yoFhw44hNJm3H7_YMjXpSW105DwjjppqE',
3737
}
3838

39-
def test_decode_token(self):
39+
def test_from_raw(self):
4040
"""Test token model parsing."""
41-
parsed = token.decode_token(self.raw_ok)
41+
parsed = token.from_raw(self.raw_ok)
4242
assert isinstance(parsed, token.Token)
4343
assert parsed.push_enabled == True
4444
assert parsed.iat == 1602084527

0 commit comments

Comments
 (0)