cleanup for PR

Author: chillaq

splitio/sync/split.py

@@ -1,5 +1,4 @@
 """Splits synchronization logic."""
-from ast import Not
 import logging
 import re
 import itertools
@@ -76,7 +75,6 @@ def _fetch_until(self, fetch_options, till=None, segment_sync=None):
 
             for split in split_changes.get('splits', []):
                 if split['status'] == splits.Status.ACTIVE.value:
-                    _LOGGER.debug('split details: '+str(split))                        
                     self._split_storage.put(splits.from_raw(split))
                 else:
                     self._split_storage.remove(split['name'])

splitio/sync/synchronizer.py

@@ -234,7 +234,7 @@ def synchronize_splits(self, till):
         _LOGGER.debug('Starting splits synchronization')
         try:
             segment_list = self._split_synchronizers.split_sync.synchronize_splits(till, self._split_synchronizers.segment_sync)
-            if segment_list != []:
+            if len(segment_list) != 0:
                 success = self._split_synchronizers.segment_sync.synchronize_segments(segment_list)
                 if not success:
                     _LOGGER.error('Failed to sync segment.')

tests/sync/test_synchronizer.py

@@ -248,7 +248,7 @@ def test_sync_all_ok(self, mocker):
         def sync_splits(*_):
             """Sync Splits."""
             counts['splits'] += 1
-            return True
+            return []
 
         def sync_segments(*_):
             """Sync Segments."""
@@ -262,7 +262,7 @@ def sync_segments(*_):
 
         synchronizer.sync_all()
         assert counts['splits'] == 1
-        assert counts['segments'] == 2
+        assert counts['segments'] == 1
 
     def test_sync_all_split_attempts(self, mocker):
         """Test that 3 attempts are done before failing."""