polishing

Author: chillaq

splitio/sync/synchronizer.py

@@ -320,7 +320,6 @@ def sync_all(self, max_retry_attempts=_SYNC_ALL_NO_RETRIES):
                         break
                 how_long = self._backoff.get()
                 time.sleep(how_long)
-                continue
 
         _LOGGER.error("Could not correctly synchronize splits and segments after %d attempts.", retry_attempts)
 

tests/client/test_factory.py

@@ -142,7 +142,7 @@ def test_redis_client_creation(self, mocker):
 
     def test_uwsgi_forked_client_creation(self):
         """Test client with preforked initialization."""
-#        pytest.set_trace()
+        # Invalid API Key with preforked should exit after 3 attempts.
         factory = get_factory('some_api_key', config={'preforkedInitialization': True})
         assert isinstance(factory._storages['splits'], inmemmory.InMemorySplitStorage)
         assert isinstance(factory._storages['segments'], inmemmory.InMemorySegmentStorage)
@@ -228,9 +228,10 @@ def _split_synchronizer(self, ready_flag, some, auth_api, streaming_enabled, sdk
         mocker.patch('splitio.sync.manager.Manager.__init__', new=_split_synchronizer)
 
         # Start factory and make assertions
+        # Using invalid key should result in a timeout exception
         factory = get_factory('some_api_key')
         try:
-            factory.block_until_ready(1) 
+            factory.block_until_ready(1)
         except:
             pass
         assert factory.ready is False
@@ -316,7 +317,7 @@ def _split_synchronizer(self, ready_flag, some, auth_api, streaming_enabled, sdk
         # Start factory and make assertions
         factory = get_factory('some_api_key')
         try:
-            factory.block_until_ready(1) 
+            factory.block_until_ready(1)
         except:
             pass
         assert factory.ready is False

tests/sync/test_synchronizer.py

@@ -34,6 +34,7 @@ def run(x, c):
 
         sychronizer.synchronize_splits(None)  # APIExceptions are handled locally and should not be propagated!
 
+        # test forcing to have only one retry attempt and then exit
         sychronizer.sync_all(1)  # sync_all should not throw!
 
     def test_sync_all_failed_segments(self, mocker):