Skip to content

Commit 0d2e69c

Browse files
author
Bilal Al
committed
moved close sse http session call to sync manager class
1 parent b8c8cba commit 0d2e69c

File tree

2 files changed

+1
-10
lines changed

2 files changed

+1
-10
lines changed

splitio/client/factory.py

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -372,10 +372,6 @@ def __init__( # pylint: disable=too-many-arguments
372372

373373
async def _update_status_when_ready_async(self):
374374
"""Wait until the sdk is ready and update the status for async mode."""
375-
if self._preforked_initialization:
376-
self._status = Status.WAITING_FORK
377-
return
378-
379375
if self._manager_start_task is not None:
380376
await self._manager_start_task
381377
self._manager_start_task = None
@@ -448,9 +444,6 @@ async def destroy(self, destroyed_event=None):
448444
if isinstance(self._sync_manager, ManagerAsync) and isinstance(self._telemetry_submitter, InMemoryTelemetrySubmitterAsync):
449445
await self._api_client.close_session()
450446

451-
if isinstance(self._sync_manager, ManagerAsync) and self._sync_manager._streaming_enabled:
452-
await self._sync_manager.close_sse_http_client()
453-
454447
except Exception as e:
455448
_LOGGER.error('Exception destroying factory.')
456449
_LOGGER.debug(str(e))

splitio/sync/manager.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -203,12 +203,10 @@ async def stop(self, blocking):
203203
self._push_status_handler_active = False
204204
await self._queue.put(self._CENTINEL_EVENT)
205205
await self._push.stop(blocking)
206+
await self._push.close_sse_http_client()
206207
await self._synchronizer.shutdown(blocking)
207208
self._stopped = True
208209

209-
async def close_sse_http_client(self):
210-
await self._push.close_sse_http_client()
211-
212210
async def _streaming_feedback_handler(self):
213211
"""
214212
Handle status updates from the streaming subsystem.

0 commit comments

Comments
 (0)