Skip to content

Commit 07ca6e0

Browse files
committed
Merge branch 'Feature/SemVer' of github.com:splitio/python-client into Feature/SemVer
2 parents 2eafb68 + e44fe87 commit 07ca6e0

File tree

5 files changed

+14
-4
lines changed

5 files changed

+14
-4
lines changed

CHANGES.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
9.7.0 (May XX, 2024)
2+
- Added support for targeting rules based on semantic versions (https://semver.org/).
3+
14
9.6.2 (Apr 5, 2024)
25
- Fixed an issue when pushing unique keys tracker data to redis if no keys exist, i.e. get_treatment flavors are not called.
36

splitio/api/commons.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -131,8 +131,8 @@ def build_fetch(change_number, fetch_options, metadata):
131131
return query, extra_headers
132132
if fetch_options.cache_control_headers:
133133
extra_headers[_CACHE_CONTROL] = _CACHE_CONTROL_NO_CACHE
134-
if fetch_options.change_number is not None:
135-
query['till'] = fetch_options.change_number
136134
if fetch_options.sets is not None:
137135
query['sets'] = fetch_options.sets
136+
if fetch_options.change_number is not None:
137+
query['till'] = fetch_options.change_number
138138
return query, extra_headers

splitio/models/grammar/matchers/semver.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,10 @@ def _parse(self, version):
5353
raise RuntimeError("Pre-release is empty despite delimeter exists: " + version)
5454

5555
without_metadata = without_metadata[:index]
56-
self._pre_release = pre_release_data.split(self._VALUE_DELIMITER)
56+
for pre_digit in pre_release_data.split(self._VALUE_DELIMITER):
57+
if pre_digit.isnumeric():
58+
pre_digit = str(int(pre_digit))
59+
self._pre_release.append(pre_digit)
5760

5861
self._set_major_minor_and_patch(without_metadata)
5962

splitio/version.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
__version__ = '9.6.2'
1+
__version__ = '9.7.0'

tests/models/grammar/test_semver.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,3 +53,7 @@ def test_compare(self):
5353
assert version2.compare(version1) >= 0 and version3.compare(version2) >= 0
5454
else:
5555
assert version2.compare(version1) < 0 or version3.compare(version2) < 0
56+
57+
def test_leading_zeros(self):
58+
assert Semver.build('1.01.2').version == '1.1.2'
59+
assert Semver.build('1.01.2-rc.01').version == '1.1.2-rc.1'

0 commit comments

Comments
 (0)