updated track tests

Author: chillaq

tests/integration/test_client_e2e.py

@@ -90,6 +90,13 @@ def _validate_last_impressions(self, client, *to_validate):
         as_tup_set = set((i.feature_name, i.matching_key, i.treatment) for i in impressions)
         assert as_tup_set == set(to_validate)
 
+    def _validate_last_events(self, client, *to_validate):
+        """Validate the last N impressions are present disregarding the order."""
+        event_storage = client._factory._get_storage('events')
+        events = event_storage.pop_many(len(to_validate))
+        as_tup_set = set((i.key, i.traffic_type_name, i.event_type_id, i.value, str(i.properties)) for i in events)
+        assert as_tup_set == set(to_validate)
+
     def test_get_treatment(self):
         """Test client.get_treatment()."""
         try:
@@ -275,10 +282,14 @@ def test_track(self):
             client = self.factory.client()
         except:
             pass
-        assert(client.track('user1', 'user', 'conversion'))
+        assert(client.track('user1', 'user', 'conversion', 1, {"prop1": "value1"}))
         assert(not client.track(None, 'user', 'conversion'))
         assert(not client.track('user1', None, 'conversion'))
         assert(not client.track('user1', 'user', None))
+        self._validate_last_events(
+            client,
+            ('user1', 'user', 'conversion', 1, "{'prop1': 'value1'}")
+        )
 
     def test_manager_methods(self):
         """Test manager.split/splits."""
@@ -369,6 +380,13 @@ def _validate_last_impressions(self, client, *to_validate):
         as_tup_set = set((i.feature_name, i.matching_key, i.treatment) for i in impressions)
         assert as_tup_set == set(to_validate)
 
+    def _validate_last_events(self, client, *to_validate):
+        """Validate the last N impressions are present disregarding the order."""
+        event_storage = client._factory._get_storage('events')
+        events = event_storage.pop_many(len(to_validate))
+        as_tup_set = set((i.key, i.traffic_type_name, i.event_type_id, i.value, str(i.properties)) for i in events)
+        assert as_tup_set == set(to_validate)
+
     def test_get_treatment(self):
         """Test client.get_treatment()."""
         client = self.factory.client()
@@ -543,10 +561,14 @@ def test_manager_methods(self):
     def test_track(self):
         """Test client.track()."""
         client = self.factory.client()
-        assert(client.track('user1', 'user', 'conversion'))
+        assert(client.track('user1', 'user', 'conversion', 1, {"prop1": "value1"}))
         assert(not client.track(None, 'user', 'conversion'))
         assert(not client.track('user1', None, 'conversion'))
         assert(not client.track('user1', 'user', None))
+        self._validate_last_events(
+            client,
+            ('user1', 'user', 'conversion', 1, "{'prop1': 'value1'}")
+        )
 
 class RedisIntegrationTests(object):
     """Redis storage-based integration tests."""
@@ -599,6 +621,20 @@ def setup_method(self):
                                     telemetry_init_producer=telemetry_producer.get_telemetry_init_producer(),
                                     )  # pylint:disable=attribute-defined-outside-init
 
+    def _validate_last_events(self, client, *to_validate):
+        """Validate the last N impressions are present disregarding the order."""
+        event_storage = client._factory._get_storage('events')
+        redis_client = event_storage._redis
+        events_raw = [
+            json.loads(redis_client.lpop(event_storage._EVENTS_KEY_TEMPLATE))
+            for _ in to_validate
+        ]
+        as_tup_set = set(
+            (i['e']['key'], i['e']['trafficTypeName'], i['e']['eventTypeId'], i['e']['value'], str(i['e']['properties']))
+            for i in events_raw
+        )
+        assert as_tup_set == set(to_validate)
+
     def _validate_last_impressions(self, client, *to_validate):
         """Validate the last N impressions are present disregarding the order."""
         imp_storage = client._factory._get_storage('impressions')
@@ -786,10 +822,14 @@ def test_get_treatments_with_config(self):
     def test_track(self):
         """Test client.track()."""
         client = self.factory.client()
-        assert(client.track('user1', 'user', 'conversion'))
+        assert(client.track('user1', 'user', 'conversion', 1, {"prop1": "value1"}))
         assert(not client.track(None, 'user', 'conversion'))
         assert(not client.track('user1', None, 'conversion'))
         assert(not client.track('user1', 'user', None))
+        self._validate_last_events(
+            client,
+            ('user1', 'user', 'conversion', 1, "{'prop1': 'value1'}")
+        )
 
     def test_manager_methods(self):
         """Test manager.split/splits."""