Remove SplitsCacheInLocal::storageHash

Author: EmilianoSanchez

src/storages/inLocalStorage/SplitsCacheInLocal.ts

@@ -15,15 +15,13 @@ export class SplitsCacheInLocal extends AbstractSplitsCacheSync {
 
   private readonly keys: KeyBuilderCS;
   private readonly log: ILogger;
-  private readonly storageHash: string;
   private readonly flagSetsFilter: string[];
   private hasSync?: boolean;
 
   constructor(settings: ISettings, keys: KeyBuilderCS) {
     super();
     this.keys = keys;
     this.log = settings.log;
-    this.storageHash = getStorageHash(settings);
     this.flagSetsFilter = settings.sync.__splitFiltersValidation.groupedFilters.bySet;
   }
 
@@ -32,7 +30,7 @@ export class SplitsCacheInLocal extends AbstractSplitsCacheSync {
    *
    * @param expirationTimestamp - if the value is not a number, data will not be cleaned
    */
-  public validateCache(expirationTimestamp?: number) {
+  public validateCache(settings: ISettings, expirationTimestamp?: number) {
     // _checkExpiration
     let value: string | number | null = localStorage.getItem(this.keys.buildLastUpdatedKey());
     if (value !== null) {
@@ -44,14 +42,15 @@ export class SplitsCacheInLocal extends AbstractSplitsCacheSync {
     // _checkFilterQuery
     const storageHashKey = this.keys.buildHashKey();
     const storageHash = localStorage.getItem(storageHashKey);
+    const currentStorageHash = getStorageHash(settings);
 
-    if (storageHash !== this.storageHash) {
+    if (storageHash !== currentStorageHash) {
       this.log.info(LOG_PREFIX + 'SDK key, flags filter criteria or flags spec version was modified. Updating cache');
       try {
         // if there is cache, clear it
         if (this.getChangeNumber() > -1) this.clear();
 
-        localStorage.setItem(storageHashKey, this.storageHash);
+        localStorage.setItem(storageHashKey, currentStorageHash);
       } catch (e) {
         this.log.error(LOG_PREFIX + e);
       }

src/storages/inLocalStorage/__tests__/SplitsCacheInLocal.spec.ts

@@ -7,7 +7,7 @@ import { fullSettings } from '../../../utils/settingsValidation/__tests__/settin
 
 test('SPLIT CACHE / LocalStorage', () => {
   const cache = new SplitsCacheInLocal(fullSettings, new KeyBuilderCS('SPLITIO', 'user'));
-  cache.validateCache();
+  cache.validateCache(fullSettings);
 
   cache.clear();
 
@@ -41,7 +41,7 @@ test('SPLIT CACHE / LocalStorage', () => {
 
 test('SPLIT CACHE / LocalStorage / Get Keys', () => {
   const cache = new SplitsCacheInLocal(fullSettings, new KeyBuilderCS('SPLITIO', 'user'));
-  cache.validateCache();
+  cache.validateCache(fullSettings);
 
   cache.addSplit('lol1', something);
   cache.addSplit('lol2', somethingElse);
@@ -54,7 +54,7 @@ test('SPLIT CACHE / LocalStorage / Get Keys', () => {
 
 test('SPLIT CACHE / LocalStorage / Add Splits', () => {
   const cache = new SplitsCacheInLocal(fullSettings, new KeyBuilderCS('SPLITIO', 'user'));
-  cache.validateCache();
+  cache.validateCache(fullSettings);
 
   cache.addSplits([
     ['lol1', something],
@@ -69,7 +69,7 @@ test('SPLIT CACHE / LocalStorage / Add Splits', () => {
 
 test('SPLIT CACHE / LocalStorage / trafficTypeExists and ttcache tests', () => {
   const cache = new SplitsCacheInLocal(fullSettings, new KeyBuilderCS('SPLITIO', 'user'));
-  cache.validateCache();
+  cache.validateCache(fullSettings);
 
   cache.addSplits([ // loop of addSplit
     ['split1', splitWithUserTT],
@@ -108,7 +108,7 @@ test('SPLIT CACHE / LocalStorage / trafficTypeExists and ttcache tests', () => {
 
 test('SPLIT CACHE / LocalStorage / killLocally', () => {
   const cache = new SplitsCacheInLocal(fullSettings, new KeyBuilderCS('SPLITIO', 'user'));
-  cache.validateCache();
+  cache.validateCache(fullSettings);
 
   cache.addSplit('lol1', something);
   cache.addSplit('lol2', somethingElse);
@@ -142,7 +142,7 @@ test('SPLIT CACHE / LocalStorage / killLocally', () => {
 
 test('SPLIT CACHE / LocalStorage / usesSegments', () => {
   const cache = new SplitsCacheInLocal(fullSettings, new KeyBuilderCS('SPLITIO', 'user'));
-  cache.validateCache();
+  cache.validateCache(fullSettings);
 
   expect(cache.usesSegments()).toBe(true); // true initially, until data is synchronized
   cache.setChangeNumber(1); // to indicate that data has been synced.
@@ -174,7 +174,7 @@ test('SPLIT CACHE / LocalStorage / flag set cache tests', () => {
       }
     }
   }, new KeyBuilderCS('SPLITIO', 'user'));
-  cache.validateCache();
+  cache.validateCache(fullSettings);
 
   const emptySet = new Set([]);
 
@@ -216,7 +216,7 @@ test('SPLIT CACHE / LocalStorage / flag set cache tests', () => {
 // if FlagSets are not defined, it should store all FlagSets in memory.
 test('SPLIT CACHE / LocalStorage / flag set cache tests without filters', () => {
   const cache = new SplitsCacheInLocal(fullSettings, new KeyBuilderCS('SPLITIO', 'user'));
-  cache.validateCache();
+  cache.validateCache(fullSettings);
 
   const emptySet = new Set([]);
 

src/storages/inLocalStorage/index.ts

@@ -55,7 +55,7 @@ export function InLocalStorage(options: InLocalStorageOptions = {}): IStorageSyn
 
       // @TODO implement
       validateCache() {
-        return splits.validateCache(expirationTimestamp);
+        return splits.validateCache(settings, expirationTimestamp);
       },
 
       destroy() { },