Skip to content

Commit dd9a447

Browse files
split impressionsDisabled from properties
1 parent 23818e1 commit dd9a447

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

src/utils/inputValidation/eventProperties.ts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,12 @@ export function validateEventProperties(log: ILogger, maybeProperties: any, meth
7070
export function validateEvaluationOptions(log: ILogger, maybeOptions: any, method: string): SplitIO.EvaluationOptions | undefined {
7171
if (isObject(maybeOptions)) {
7272
const properties = validateEventProperties(log, maybeOptions.properties, method).properties;
73-
return properties && Object.keys(properties).length > 0 ? { properties } : undefined;
73+
let options = properties && Object.keys(properties).length > 0 ? { properties } : undefined;
74+
75+
const impressionsDisabled = maybeOptions.impressionsDisabled;
76+
if (!impressionsDisabled) return options;
77+
78+
return options ? { ...options, impressionsDisabled } : { impressionsDisabled };
7479
} else if (maybeOptions) {
7580
log.error(ERROR_NOT_PLAIN_OBJECT, [method, 'evaluation options']);
7681
}

0 commit comments

Comments
 (0)