Move methods from KeyBuilder to KeyBuilderCS

Author: EmilianoSanchez

src/storages/KeyBuilder.ts

@@ -1,5 +1,4 @@
 import { ISettings } from '../types';
-import { startsWith } from '../utils/lang';
 import { hash } from '../utils/murmur3/murmur3';
 
 const everythingAtTheEnd = /[^.]+$/;
@@ -34,24 +33,10 @@ export class KeyBuilder {
     return `${this.prefix}.splits.till`;
   }
 
-  // NOT USED
-  // buildSplitsReady() {
-  //   return `${this.prefix}.splits.ready`;
-  // }
-
-  isSplitKey(key: string) {
-    return startsWith(key, `${this.prefix}.split.`);
-  }
-
   buildSplitKeyPrefix() {
     return `${this.prefix}.split.`;
   }
 
-  // Only used by InLocalStorage.
-  buildSplitsWithSegmentCountKey() {
-    return `${this.prefix}.splits.usingSegments`;
-  }
-
   buildSegmentNameKey(segmentName: string) {
     return `${this.prefix}.segment.${segmentName}`;
   }
@@ -60,11 +45,6 @@ export class KeyBuilder {
     return `${this.prefix}.segment.${segmentName}.till`;
   }
 
-  // NOT USED
-  // buildSegmentsReady() {
-  //   return `${this.prefix}.segments.ready`;
-  // }
-
   extractKey(builtKey: string) {
     const s = builtKey.match(everythingAtTheEnd);
 

src/storages/KeyBuilderCS.ts

@@ -42,6 +42,14 @@ export class KeyBuilderCS extends KeyBuilder implements MySegmentsKeyBuilder {
   buildTillKey() {
     return `${this.prefix}.${this.matchingKey}.segments.till`;
   }
+
+  isSplitKey(key: string) {
+    return startsWith(key, `${this.prefix}.split.`);
+  }
+
+  buildSplitsWithSegmentCountKey() {
+    return `${this.prefix}.splits.usingSegments`;
+  }
 }
 
 export function myLargeSegmentsKeyBuilder(prefix: string, matchingKey: string): MySegmentsKeyBuilder {

src/storages/__tests__/KeyBuilder.spec.ts

@@ -9,14 +9,9 @@ test('KEYS / splits keys', () => {
   const expectedKey = `SPLITIO.split.${splitName}`;
   const expectedTill = 'SPLITIO.splits.till';
 
-  expect(builder.isSplitKey(expectedKey)).toBe(true);
-  expect(builder.buildSplitKey(splitName) === expectedKey).toBe(true);
-  expect(builder.buildSplitsTillKey() === expectedTill).toBe(true);
-  expect(builder.extractKey(builder.buildSplitKey(splitName)) === splitName).toBe(true);
-
-  // NOT USED
-  // const expectedReady = 'SPLITIO.splits.ready';
-  // expect(builder.buildSplitsReady() === expectedReady).toBe(true);
+  expect(builder.buildSplitKey(splitName)).toBe(expectedKey);
+  expect(builder.buildSplitsTillKey()).toBe(expectedTill);
+  expect(builder.extractKey(builder.buildSplitKey(splitName))).toBe(splitName);
 });
 
 test('KEYS / splits keys with custom prefix', () => {
@@ -27,13 +22,8 @@ test('KEYS / splits keys with custom prefix', () => {
   const expectedKey = `${prefix}.split.${splitName}`;
   const expectedTill = `${prefix}.splits.till`;
 
-  expect(builder.isSplitKey(expectedKey)).toBe(true);
   expect(builder.buildSplitKey(splitName)).toBe(expectedKey);
   expect(builder.buildSplitsTillKey() === expectedTill).toBe(true);
-
-  // NOT USED
-  // const expectedReady = `${prefix}.SPLITIO.splits.ready`;
-  // expect(builder.buildSplitsReady() === expectedReady).toBe(true);
 });
 
 const prefix = 'SPLITIO';