Merge branch 'rb_segments_polishing' into prerequisites_refactors

Author: EmilianoSanchez

CHANGES.txt

@@ -1,3 +1,6 @@
+2.3.0 (April XXX, 2025)
+ - Added support for targeting rules based on rule-based segments.
+
 2.2.0 (March 28, 2025)
  - Added a new optional argument to the client `getTreatment` methods to allow passing additional evaluation options, such as a map of properties to append to the generated impressions sent to Split backend. Read more in our docs.
  - Added two new configuration options for the SDK storage in browsers when using storage type `LOCALSTORAGE`:

src/dtos/types.ts

@@ -203,10 +203,10 @@ export interface IRBSegment {
   name: string,
   changeNumber: number,
   status: 'ACTIVE' | 'ARCHIVED',
-  conditions: ISplitCondition[],
-  excluded: {
-    keys: string[],
-    segments: string[]
+  conditions?: ISplitCondition[],
+  excluded?: {
+    keys?: string[],
+    segments?: string[]
   }
 }
 

src/evaluator/matchers/rbsegment.ts

@@ -12,7 +12,7 @@ export function ruleBasedSegmentMatcherContext(segmentName: string, storage: ISt
   return function ruleBasedSegmentMatcher({ key, attributes }: IDependencyMatcherValue, splitEvaluator: ISplitEvaluator): MaybeThenable<boolean> {
 
     function matchConditions(rbsegment: IRBSegment) {
-      const conditions = rbsegment.conditions;
+      const conditions = rbsegment.conditions || [];
       const evaluator = parser(log, conditions, storage);
 
       const evaluation = evaluator(
@@ -31,10 +31,11 @@ export function ruleBasedSegmentMatcherContext(segmentName: string, storage: ISt
 
     function isExcluded(rbSegment: IRBSegment) {
       const matchingKey = getMatching(key);
+      const excluded = rbSegment.excluded || {};
 
-      if (rbSegment.excluded.keys.indexOf(matchingKey) !== -1) return true;
+      if (excluded.keys && excluded.keys.indexOf(matchingKey) !== -1) return true;
 
-      const isInSegment = rbSegment.excluded.segments.map(segmentName => {
+      const isInSegment = (excluded.segments || []).map(segmentName => {
         return storage.segments.isInSegment(segmentName, matchingKey);
       });
 

src/sync/polling/updaters/splitChangesUpdater.ts

@@ -30,7 +30,7 @@ function checkAllSegmentsExist(segments: ISegmentsCacheBase): Promise<boolean> {
  * Exported for testing purposes.
  */
 export function parseSegments(ruleEntity: ISplit | IRBSegment, matcherType: typeof IN_SEGMENT | typeof IN_RULE_BASED_SEGMENT = IN_SEGMENT): Set<string> {
-  const { conditions, excluded } = ruleEntity as IRBSegment;
+  const { conditions = [], excluded } = ruleEntity as IRBSegment;
   const segments = new Set<string>(excluded && excluded.segments);
 
   for (let i = 0; i < conditions.length; i++) {