Merge pull request #298 from splitio/tests_refactor

EmilianoSanchez · web-flow · commit 6b5bd8605e67 · 2024-04-10T16:22:19.000-03:00
Tests refactor: removed unnecessary comments
diff --git a/src/evaluator/matchers/__tests__/all.spec.ts b/src/evaluator/matchers/__tests__/all.spec.ts
@@ -4,8 +4,7 @@ import { IMatcher, IMatcherDto } from '../../types';
 import { loggerMock } from '../../../logger/__tests__/sdkLogger.mock';
 
 test('MATCHER ALL_KEYS / should always return true', function () {
-  // @ts-ignore
-  let matcher = matcherFactory(loggerMock, {
+  const matcher = matcherFactory(loggerMock, {
     type: matcherTypes.ALL_KEYS,
     value: undefined
   } as IMatcherDto) as IMatcher;
diff --git a/src/evaluator/matchers/__tests__/between.spec.ts b/src/evaluator/matchers/__tests__/between.spec.ts
@@ -4,8 +4,7 @@ import { IMatcher, IMatcherDto } from '../../types';
 import { loggerMock } from '../../../logger/__tests__/sdkLogger.mock';
 
 test('MATCHER BETWEEN / should return true ONLY when the value is between 10 and 20', function () {
-  // @ts-ignore
-  let matcher = matcherFactory(loggerMock, {
+  const matcher = matcherFactory(loggerMock, {
     negate: false,
     type: matcherTypes.BETWEEN,
     value: {
diff --git a/src/evaluator/matchers/__tests__/boolean.spec.ts b/src/evaluator/matchers/__tests__/boolean.spec.ts
@@ -4,7 +4,6 @@ import { IMatcher, IMatcherDto } from '../../types';
 import { loggerMock } from '../../../logger/__tests__/sdkLogger.mock';
 
 test('MATCHER BOOLEAN / should return true ONLY when the value is true', function () {
-  // @ts-ignore
   const matcher = matcherFactory(loggerMock, {
     type: matcherTypes.EQUAL_TO_BOOLEAN,
     value: true
diff --git a/src/evaluator/matchers/__tests__/cont_all.spec.ts b/src/evaluator/matchers/__tests__/cont_all.spec.ts
@@ -4,8 +4,7 @@ import { IMatcher, IMatcherDto } from '../../types';
 import { loggerMock } from '../../../logger/__tests__/sdkLogger.mock';
 
 test('MATCHER CONTAINS_ALL_OF_SET / should return true ONLY when value contains all of set ["update", "add"]', function () {
-  // @ts-ignore
-  let matcher = matcherFactory(loggerMock, {
+  const matcher = matcherFactory(loggerMock, {
     negate: false,
     type: matcherTypes.CONTAINS_ALL_OF_SET,
     value: ['update', 'add']
diff --git a/src/evaluator/matchers/__tests__/cont_any.spec.ts b/src/evaluator/matchers/__tests__/cont_any.spec.ts
@@ -4,8 +4,7 @@ import { IMatcher, IMatcherDto } from '../../types';
 import { loggerMock } from '../../../logger/__tests__/sdkLogger.mock';
 
 test('MATCHER CONTAINS_ANY_OF_SET / should return true ONLY when value contains any of set ["update", "add"]', function () {
-  // @ts-ignore
-  let matcher = matcherFactory(loggerMock, {
+  const matcher = matcherFactory(loggerMock, {
     negate: false,
     type: matcherTypes.CONTAINS_ANY_OF_SET,
     value: ['update', 'add']
diff --git a/src/evaluator/matchers/__tests__/cont_str.spec.ts b/src/evaluator/matchers/__tests__/cont_str.spec.ts
@@ -4,8 +4,7 @@ import { IMatcher, IMatcherDto } from '../../types';
 import { loggerMock } from '../../../logger/__tests__/sdkLogger.mock';
 
 test('MATCHER CONTAINS_STRING / should return true ONLY when the value is contained in ["roni", "bad", "ar"]', function () {
-  // @ts-ignore
-  let matcher = matcherFactory(loggerMock, {
+  const matcher = matcherFactory(loggerMock, {
     negate: false,
     type: matcherTypes.CONTAINS_STRING,
     value: ['roni', 'bad', 'ar']
diff --git a/src/evaluator/matchers/__tests__/dependency.spec.ts b/src/evaluator/matchers/__tests__/dependency.spec.ts
@@ -107,7 +107,6 @@ test('MATCHER IN_SPLIT_TREATMENT / Edge cases', function () {
     type: matcherTypes.IN_SPLIT_TREATMENT,
     value: {
       split: 'always-off',
-      // @ts-ignore
       treatments: [null, [1, 2], 3, {}, true, 'on']
     }
   } as IMatcherDto, mockStorage as IStorageSync) as IMatcher;
diff --git a/src/evaluator/matchers/__tests__/eq.spec.ts b/src/evaluator/matchers/__tests__/eq.spec.ts
@@ -4,8 +4,7 @@ import { IMatcher, IMatcherDto } from '../../types';
 import { loggerMock } from '../../../logger/__tests__/sdkLogger.mock';
 
 test('MATCHER EQUAL / should return true ONLY when the value is equal to 10', function () {
-  // @ts-ignore
-  let matcher = matcherFactory(loggerMock, {
+  const matcher = matcherFactory(loggerMock, {
     negate: false,
     type: matcherTypes.EQUAL_TO,
     value: 10
diff --git a/src/evaluator/matchers/__tests__/eq_set.spec.ts b/src/evaluator/matchers/__tests__/eq_set.spec.ts
@@ -4,8 +4,7 @@ import { IMatcher, IMatcherDto } from '../../types';
 import { loggerMock } from '../../../logger/__tests__/sdkLogger.mock';
 
 test('MATCHER EQUAL_TO_SET / should return true ONLY when value is equal to set ["update", "add"]', function () {
-  // @ts-ignore
-  let matcher = matcherFactory(loggerMock, {
+  const matcher = matcherFactory(loggerMock, {
     negate: false,
     type: matcherTypes.EQUAL_TO_SET,
     value: ['update', 'add']
diff --git a/src/evaluator/matchers/__tests__/ew.spec.ts b/src/evaluator/matchers/__tests__/ew.spec.ts
@@ -4,8 +4,7 @@ import { IMatcher, IMatcherDto } from '../../types';
 import { loggerMock } from '../../../logger/__tests__/sdkLogger.mock';
 
 test('MATCHER ENDS_WITH / should return true ONLY when the value ends with ["a", "b", "c"]', function () {
-  // @ts-ignore
-  let matcher = matcherFactory(loggerMock, {
+  const matcher = matcherFactory(loggerMock, {
     negate: false,
     type: matcherTypes.ENDS_WITH,
     value: ['a', 'b', 'c']
@@ -19,8 +18,7 @@ test('MATCHER ENDS_WITH / should return true ONLY when the value ends with ["a",
 });
 
 test('MATCHER ENDS_WITH / should return true ONLY when the value ends with ["demo.test.org"]', function () {
-  // @ts-ignore
-  let matcher = matcherFactory(loggerMock, {
+  const matcher = matcherFactory(loggerMock, {
     negate: false,
     type: matcherTypes.ENDS_WITH,
     value: ['demo.test.org']
diff --git a/src/evaluator/matchers/__tests__/gte.spec.ts b/src/evaluator/matchers/__tests__/gte.spec.ts
@@ -4,8 +4,7 @@ import { IMatcher, IMatcherDto } from '../../types';
 import { loggerMock } from '../../../logger/__tests__/sdkLogger.mock';
 
 test('MATCHER GREATER THAN OR EQUAL / should return true ONLY when the value is greater than or equal to 10', function () {
-  // @ts-ignore
-  let matcher = matcherFactory(loggerMock, {
+  const matcher = matcherFactory(loggerMock, {
     negate: false,
     type: matcherTypes.GREATER_THAN_OR_EQUAL_TO,
     value: 10
diff --git a/src/evaluator/matchers/__tests__/lte.spec.ts b/src/evaluator/matchers/__tests__/lte.spec.ts
@@ -4,8 +4,7 @@ import { IMatcher, IMatcherDto } from '../../types';
 import { loggerMock } from '../../../logger/__tests__/sdkLogger.mock';
 
 test('MATCHER LESS THAN OR EQUAL / should return true ONLY when the value is less than or equal to 10', function () {
-  // @ts-ignore
-  let matcher = matcherFactory(loggerMock, {
+  const matcher = matcherFactory(loggerMock, {
     negate: false,
     type: matcherTypes.LESS_THAN_OR_EQUAL_TO,
     value: 10
diff --git a/src/evaluator/matchers/__tests__/part_of.spec.ts b/src/evaluator/matchers/__tests__/part_of.spec.ts
@@ -4,8 +4,7 @@ import { IMatcher, IMatcherDto } from '../../types';
 import { loggerMock } from '../../../logger/__tests__/sdkLogger.mock';
 
 test('MATCHER PART_OF_SET / should return true ONLY when value is part of of set ["update", "add", "delete"]', function () {
-  // @ts-ignore
-  let matcher = matcherFactory(loggerMock, {
+  const matcher = matcherFactory(loggerMock, {
     negate: false,
     type: matcherTypes.PART_OF_SET,
     value: ['update', 'add', 'delete']
diff --git a/src/evaluator/matchers/__tests__/regex.spec.ts b/src/evaluator/matchers/__tests__/regex.spec.ts
@@ -5,7 +5,6 @@ import { loggerMock } from '../../../logger/__tests__/sdkLogger.mock';
 import { readCSV } from '../../../__tests__/testUtils/csv';
 
 test('MATCHER REGEX (STRING) / should match the attribute value only with the string starts with hello', () => {
-  // @ts-ignore
   const matcher = matcherFactory(loggerMock, {
     type: matcherTypes.MATCHES_STRING,
     value: '^hello'
@@ -16,7 +15,6 @@ test('MATCHER REGEX (STRING) / should match the attribute value only with the st
 });
 
 test('MATCHER REGEX (STRING) / incorrectly matches unicode characters', () => {
-  // @ts-ignore
   const matcher = matcherFactory(loggerMock, {
     type: matcherTypes.MATCHES_STRING,
     value: 'a.b'
@@ -36,7 +34,6 @@ test('MATCHER REGEX (STRING) / incorrectly matches unicode characters', () => {
     for (const [regex, input, test] of lines) {
       const isTestTrue = test === 'true';
 
-      // @ts-ignore
       const matcher = matcherFactory(loggerMock, {
         type: matcherTypes.MATCHES_STRING,
         value: regex
diff --git a/src/evaluator/matchers/__tests__/sw.spec.ts b/src/evaluator/matchers/__tests__/sw.spec.ts
@@ -4,8 +4,7 @@ import { IMatcher, IMatcherDto } from '../../types';
 import { loggerMock } from '../../../logger/__tests__/sdkLogger.mock';
 
 test('MATCHER STARTS_WITH / should return true ONLY when the value starts with ["a", "b", "c"]', function () {
-  // @ts-ignore
-  let matcher = matcherFactory(loggerMock, {
+  const matcher = matcherFactory(loggerMock, {
     negate: false,
     type: matcherTypes.STARTS_WITH,
     value: ['a', 'b', 'c']
diff --git a/src/evaluator/matchers/__tests__/whitelist.spec.ts b/src/evaluator/matchers/__tests__/whitelist.spec.ts
@@ -5,8 +5,7 @@ import { IMatcher, IMatcherDto } from '../../types';
 import { loggerMock } from '../../../logger/__tests__/sdkLogger.mock';
 
 test('MATCHER WHITELIST / should return true ONLY when the key is defined', function () {
-  // @ts-ignore
-  let matcher = matcherFactory(loggerMock, {
+  const matcher = matcherFactory(loggerMock, {
     type: matcherTypes.WHITELIST,
     value: new _Set().add('key')
   } as IMatcherDto) as IMatcher;

Original file line number	Diff line number	Diff line change
`@@ -107,7 +107,6 @@ test('MATCHER IN_SPLIT_TREATMENT / Edge cases', function () {`
`107`	`107`	`type: matcherTypes.IN_SPLIT_TREATMENT,`
`108`	`108`	`value: {`
`109`	`109`	`split: 'always-off',`
`110`		`- // @ts-ignore`
`111`	`110`	`treatments: [null, [1, 2], 3, {}, true, 'on']`
`112`	`111`	`}`
`113`	`112`	`} as IMatcherDto, mockStorage as IStorageSync) as IMatcher;`