rc

Author: EmilianoSanchez

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "@splitsoftware/splitio-commons",
-  "version": "2.1.1-rc.1",
+  "version": "2.1.1-rc.2",
   "description": "Split JavaScript SDK common components",
   "main": "cjs/index.js",
   "module": "esm/index.js",

package.json

@@ -2,7 +2,6 @@
 import { parser } from '..';
 import { keyParser } from '../../../utils/key';
 import { ISplitCondition } from '../../../dtos/types';
-import { bucket } from '../../../utils/murmur3/murmur3';
 import { loggerMock } from '../../../logger/__tests__/sdkLogger.mock';
 
 test('PARSER / if user is in segment all 100%:on', async function () {
@@ -662,8 +661,6 @@ test('PARSER / if user is in segment all then split 20%:A,20%:B,60%:A', async fu
   let evaluation = await evaluator(keyParser('aa'), 31, 100, 31);
   expect(evaluation.treatment).toBe('A'); // 20%:A // bucket 6 with murmur3
 
-  console.log(bucket('b297', 31));
-
   evaluation = await evaluator(keyParser('b297'), 31, 100, 31);
   expect(evaluation.treatment).toBe('B'); // 20%:B // bucket 34 with murmur3
 

src/evaluator/parser/__tests__/index.spec.ts

@@ -31,16 +31,14 @@ export class SplitsCacheInLocal extends AbstractSplitsCacheSync {
     else localStorage.removeItem(key);
   }
 
-  private _decrementCounts(split: ISplit | null) {
+  private _decrementCounts(split: ISplit) {
     try {
-      if (split) {
-        const ttKey = this.keys.buildTrafficTypeKey(split.trafficTypeName);
-        this._decrementCount(ttKey);
+      const ttKey = this.keys.buildTrafficTypeKey(split.trafficTypeName);
+      this._decrementCount(ttKey);
 
-        if (usesSegments(split)) {
-          const segmentsCountKey = this.keys.buildSplitsWithSegmentCountKey();
-          this._decrementCount(segmentsCountKey);
-        }
+      if (usesSegments(split)) {
+        const segmentsCountKey = this.keys.buildSplitsWithSegmentCountKey();
+        this._decrementCount(segmentsCountKey);
       }
     } catch (e) {
       this.log.error(LOG_PREFIX + e);
@@ -93,12 +91,14 @@ export class SplitsCacheInLocal extends AbstractSplitsCacheSync {
       const splitFromLocalStorage = localStorage.getItem(splitKey);
       const previousSplit = splitFromLocalStorage ? JSON.parse(splitFromLocalStorage) : null;
 
+      if (previousSplit) {
+        this._decrementCounts(previousSplit);
+        this.removeFromFlagSets(previousSplit.name, previousSplit.sets);
+      }
+
       localStorage.setItem(splitKey, JSON.stringify(split));
 
       this._incrementCounts(split);
-      this._decrementCounts(previousSplit);
-
-      if (previousSplit) this.removeFromFlagSets(previousSplit.name, previousSplit.sets);
       this.addToFlagSets(split);
 
       return true;
@@ -116,7 +116,7 @@ export class SplitsCacheInLocal extends AbstractSplitsCacheSync {
       localStorage.removeItem(this.keys.buildSplitKey(name));
 
       this._decrementCounts(split);
-      if (split) this.removeFromFlagSets(split.name, split.sets);
+      this.removeFromFlagSets(split.name, split.sets);
 
       return true;
     } catch (e) {