Polishing

Author: EmilianoSanchez

CHANGES.txt

@@ -5,7 +5,7 @@
  - Updated the handling of timers and async operations inside an `init` factory method to enable lazy initialization of the SDK in standalone mode. This update is intended for the React SDK.
  - Bugfixing - Fixed an issue with the server-side polling manager that caused dangling timers when the SDK was destroyed before it was ready.
  - BREAKING CHANGES:
-   - Updated default flag spec version to 1.2.
+   - Updated default flag spec version to 1.2, which requires Split Proxy v5.9.0 or higher.
    - Removed `/mySegments` endpoint from SplitAPI module, as it is replaced by `/memberships` endpoint.
    - Removed support for MY_SEGMENTS_UPDATE and MY_SEGMENTS_UPDATE_V2 notification types, as they are replaced by MEMBERSHIPS_MS_UPDATE and MEMBERSHIPS_LS_UPDATE notification types.
    - Removed the deprecated `GOOGLE_ANALYTICS_TO_SPLIT` and `SPLIT_TO_GOOGLE_ANALYTICS` integrations.

src/__tests__/testUtils/fetchMock.ts

@@ -1,5 +1,4 @@
-// @TODO upgrade fetch-mock when fetch-mock-jest vulnerabilities are fixed
-// https://www.wheresrhys.co.uk/fetch-mock/docs/fetch-mock/Usage/cheatsheet#local-fetch-with-jest
+// @TODO upgrade fetch-mock to fix vulnerabilities
 import fetchMockLib from 'fetch-mock';
 
 const fetchMock = fetchMockLib.sandbox();

src/readiness/readinessManager.ts

@@ -8,7 +8,7 @@ function splitsEventEmitterFactory(EventEmitter: new () => SplitIO.IEventEmitter
   const splitsEventEmitter = objectAssign(new EventEmitter(), {
     splitsArrived: false,
     splitsCacheLoaded: false,
-    initialized: false,
+    hasInit: false,
     initCallbacks: []
   });
 
@@ -68,7 +68,7 @@ export function readinessManagerFactory(
 
   let readyTimeoutId: ReturnType<typeof setTimeout>;
   if (readyTimeout > 0) {
-    if (splits.initialized) readyTimeoutId = setTimeout(timeout, readyTimeout);
+    if (splits.hasInit) readyTimeoutId = setTimeout(timeout, readyTimeout);
     else splits.initCallbacks.push(() => { readyTimeoutId = setTimeout(timeout, readyTimeout); });
   }
 
@@ -137,8 +137,8 @@ export function readinessManagerFactory(
     setDestroyed() { isDestroyed = true; },
 
     init() {
-      if (splits.initialized) return;
-      splits.initialized = true;
+      if (splits.hasInit) return;
+      splits.hasInit = true;
       splits.initCallbacks.forEach(cb => cb());
     },
 

src/readiness/types.ts

@@ -13,7 +13,7 @@ export interface ISplitsEventEmitter extends SplitIO.IEventEmitter {
   once(event: ISplitsEvent, listener: (...args: any[]) => void): this;
   splitsArrived: boolean
   splitsCacheLoaded: boolean
-  initialized: boolean,
+  hasInit: boolean,
   initCallbacks: (() => void)[]
 }