Remove innecesary boolean validation

Author: ZamoraEmmanuel

src/utils/inputValidation/__tests__/eventProperties.spec.ts

@@ -1,7 +1,7 @@
 import { ERROR_NOT_BOOLEAN, ERROR_NOT_PLAIN_OBJECT, ERROR_SIZE_EXCEEDED, WARN_SETTING_NULL, WARN_TRIMMING_PROPERTIES } from '../../../logger/constants';
 import { loggerMock } from '../../../logger/__tests__/sdkLogger.mock';
 
-import { validateEventProperties, validateImpressionsDisabled } from '../eventProperties';
+import { validateEventProperties } from '../eventProperties';
 
 function calculateSize(obj: any) {
   // we calculate the expected size.
@@ -210,30 +210,4 @@ describe('INPUT VALIDATION for Impressions disabled', () => {
     new Map()
   ];
 
-  test('Not setting impressionsDisabled is acceptable', () => {
-    expect(validateImpressionsDisabled(loggerMock, undefined, 'some_method_eventProps')).toBeUndefined();
-
-    expect(loggerMock.error).not.toBeCalled(); // Should not log any errors.
-    expect(loggerMock.warn).not.toBeCalled(); // It should have not logged any warnings.
-  });
-
-  test('When setting a value for impressionsDisabled, only booleans are acceptable', () => {
-
-    impressionsDisabledInvalidValues.forEach(val => {
-      expect(validateImpressionsDisabled(loggerMock, val, 'some_method_eventProps')).toBeUndefined();
-      expect(loggerMock.error).toBeCalledWith(ERROR_NOT_BOOLEAN, ['some_method_eventProps', 'impressionsDisabled']); // Should log an error.
-      loggerMock.error.mockClear();
-    });
-
-    expect(loggerMock.warn).not.toBeCalled(); // It should have not logged any warnings.
-  });
-
-  test('It should return the impressionsDisabled value when valid', () => {
-    expect(validateImpressionsDisabled(loggerMock, true, 'some_method_eventProps')).toBeTruthy();
-    expect(validateImpressionsDisabled(loggerMock, false, 'some_method_eventProps')).toBeFalsy();
-
-    expect(loggerMock.error).not.toBeCalled(); // Should not log any errors.
-    expect(loggerMock.warn).not.toBeCalled(); // It should have not logged any warnings.
-  });
-
 });

src/utils/inputValidation/eventProperties.ts

@@ -14,17 +14,6 @@ const MAX_PROPERTIES_AMOUNT = 300;
 const MAX_EVENT_SIZE = 1024 * 32;
 const BASE_EVENT_SIZE = 1024; // We assume 1kb events without properties (avg measured)
 
-export function validateImpressionsDisabled(log: ILogger, maybeImpressionsDisabled: any, method: string): boolean | undefined {
-  if (maybeImpressionsDisabled === undefined) return;
-
-  if (maybeImpressionsDisabled === null || !isBoolean(maybeImpressionsDisabled)) {
-    log.error(ERROR_NOT_BOOLEAN, [method, 'impressionsDisabled']);
-    return;
-  }
-
-  return maybeImpressionsDisabled;
-}
-
 export function validateEventProperties(log: ILogger, maybeProperties: any, method: string): { properties: SplitIO.Properties | null | false, size: number } {
   if (maybeProperties == undefined) return { properties: null, size: BASE_EVENT_SIZE }; // eslint-disable-line eqeqeq
 
@@ -83,7 +72,7 @@ export function validateEvaluationOptions(log: ILogger, maybeOptions: any, metho
     const properties = validateEventProperties(log, maybeOptions.properties, method).properties;
     let options =  properties && Object.keys(properties).length > 0 ? { properties } : undefined;
 
-    const impressionsDisabled = validateImpressionsDisabled(log, maybeOptions.impressionsDisabled, method);
+    const impressionsDisabled = maybeOptions.impressionsDisabled;
     if (!impressionsDisabled) return options;
 
     return options ? { ...options, impressionsDisabled } : { impressionsDisabled };