Rename method

Author: EmilianoSanchez

src/storages/KeyBuilder.ts

@@ -41,7 +41,7 @@ export class KeyBuilder {
     return `${this.prefix}.rbsegment.${splitName}`;
   }
 
-  buildRBSegmentTillKey() {
+  buildRBSegmentsTillKey() {
     return `${this.prefix}.rbsegments.till`;
   }
 

src/storages/__tests__/testUtils.ts

@@ -1,4 +1,4 @@
-import { ISplit } from '../../dtos/types';
+import { IRBSegment, ISplit } from '../../dtos/types';
 import { IStorageSync, IStorageAsync, IImpressionsCacheSync, IEventsCacheSync } from '../types';
 
 // Assert that instances created by storage factories have the expected interface
@@ -45,3 +45,9 @@ export const featureFlagTwo: ISplit = { name: 'ff_two', sets: ['t','w','o'] };
 export const featureFlagThree: ISplit = { name: 'ff_three', sets: ['t','h','r','e'] };
 //@ts-ignore
 export const featureFlagWithoutFS: ISplit = { name: 'ff_four' };
+
+// Rule-based segments
+//@ts-ignore
+export const rbSegment: IRBSegment = { name: 'rb_segment', conditions: [{ matcherGroup: { matchers: [{ matcherType: 'EQUAL_TO', unaryNumericMatcherData: { value: 10 } }] } }] };
+//@ts-ignore
+export const rbSegmentWithInSegmentMatcher: IRBSegment = { name: 'rb_segment_with_in_segment_matcher', conditions: [{ matcherGroup: { matchers: [{ matcherType: 'IN_SEGMENT', userDefinedSegmentMatcherData: { segmentName: 'employees' } }] } }] };

src/storages/inRedis/RBSegmentsCacheInRedis.ts

@@ -55,13 +55,13 @@ export class RBSegmentsCacheInRedis implements IRBSegmentsCacheAsync {
   }
 
   setChangeNumber(changeNumber: number) {
-    return this.redis.set(this.keys.buildRBSegmentTillKey(), changeNumber + '').then(
+    return this.redis.set(this.keys.buildRBSegmentsTillKey(), changeNumber + '').then(
       status => status === 'OK'
     );
   }
 
   getChangeNumber(): Promise<number> {
-    return this.redis.get(this.keys.buildRBSegmentTillKey()).then((value: string | null) => {
+    return this.redis.get(this.keys.buildRBSegmentsTillKey()).then((value: string | null) => {
       const i = parseInt(value as string, 10);
 
       return isNaNNumber(i) ? -1 : i;

src/storages/pluggable/RBSegmentsCachePluggable.ts

@@ -54,11 +54,11 @@ export class RBSegmentsCachePluggable implements IRBSegmentsCacheAsync {
   }
 
   setChangeNumber(changeNumber: number) {
-    return this.wrapper.set(this.keys.buildRBSegmentTillKey(), changeNumber + '');
+    return this.wrapper.set(this.keys.buildRBSegmentsTillKey(), changeNumber + '');
   }
 
   getChangeNumber(): Promise<number> {
-    return this.wrapper.get(this.keys.buildRBSegmentTillKey()).then((value) => {
+    return this.wrapper.get(this.keys.buildRBSegmentsTillKey()).then((value) => {
       const i = parseInt(value as string, 10);
 
       return isNaNNumber(i) ? -1 : i;