refactor: use segment type constants instead of string literals

Author: EmilianoSanchez

src/evaluator/matchers/rbsegment.ts

@@ -5,6 +5,7 @@ import { IDependencyMatcherValue, ISplitEvaluator } from '../types';
 import { thenable } from '../../utils/promise/thenable';
 import { getMatching, keyParser } from '../../utils/key';
 import { parser } from '../parser';
+import { STANDARD_SEGMENT, RULE_BASED_SEGMENT, LARGE_SEGMENT } from '../../utils/constants';
 
 
 export function ruleBasedSegmentMatcherContext(segmentName: string, storage: IStorageSync | IStorageAsync, log: ILogger) {
@@ -36,11 +37,11 @@ export function ruleBasedSegmentMatcherContext(segmentName: string, storage: ISt
       if (excluded.keys && excluded.keys.indexOf(matchingKey) !== -1) return true;
 
       const isInSegment = (excluded.segments || []).map(({ type, name }) => {
-        return type === 'standard' ?
+        return type === STANDARD_SEGMENT ?
           storage.segments.isInSegment(name, matchingKey) :
-          type === 'rule-based' ?
+          type === RULE_BASED_SEGMENT ?
             ruleBasedSegmentMatcherContext(name, storage, log)({ key, attributes }, splitEvaluator) :
-            type === 'large' && (storage as IStorageSync).largeSegments ?
+            type === LARGE_SEGMENT && (storage as IStorageSync).largeSegments ?
               (storage as IStorageSync).largeSegments!.isInSegment(name, matchingKey) :
               false;
       });

src/sync/polling/updaters/splitChangesUpdater.ts

@@ -7,7 +7,7 @@ import { SDK_SPLITS_ARRIVED } from '../../../readiness/constants';
 import { ILogger } from '../../../logger/types';
 import { SYNC_SPLITS_FETCH, SYNC_SPLITS_UPDATE, SYNC_RBS_UPDATE, SYNC_SPLITS_FETCH_FAILS, SYNC_SPLITS_FETCH_RETRY } from '../../../logger/constants';
 import { startsWith } from '../../../utils/lang';
-import { IN_RULE_BASED_SEGMENT, IN_SEGMENT } from '../../../utils/constants';
+import { IN_RULE_BASED_SEGMENT, IN_SEGMENT, RULE_BASED_SEGMENT, STANDARD_SEGMENT } from '../../../utils/constants';
 import { setToArray } from '../../../utils/lang/sets';
 import { SPLIT_UPDATE } from '../../streaming/constants';
 
@@ -35,7 +35,7 @@ export function parseSegments(ruleEntity: ISplit | IRBSegment, matcherType: type
   const segments = new Set<string>();
   if (excluded && excluded.segments) {
     excluded.segments.forEach(({ type, name }) => {
-      if ((type === 'standard' && matcherType === IN_SEGMENT) || (type === 'rule-based' && matcherType === IN_RULE_BASED_SEGMENT)) {
+      if ((type === STANDARD_SEGMENT && matcherType === IN_SEGMENT) || (type === RULE_BASED_SEGMENT && matcherType === IN_RULE_BASED_SEGMENT)) {
         segments.add(name);
       }
     });

src/utils/constants/index.ts

@@ -110,3 +110,7 @@ export const FLAG_SPEC_VERSION = '1.3';
 export const IN_SEGMENT = 'IN_SEGMENT';
 export const IN_LARGE_SEGMENT = 'IN_LARGE_SEGMENT';
 export const IN_RULE_BASED_SEGMENT = 'IN_RULE_BASED_SEGMENT';
+
+export const STANDARD_SEGMENT = 'standard';
+export const LARGE_SEGMENT = 'large';
+export const RULE_BASED_SEGMENT = 'rule-based';