Merge pull request #290 from splitio/update_node_version

Update NodeJS version for scripts

Author: EmilianoSanchez

.github/workflows/ci.yml

@@ -19,12 +19,12 @@ jobs:
           - 6379:6379
     steps:
       - name: Checkout code
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
 
       - name: Set up nodejs
         uses: actions/setup-node@v2
         with:
-          node-version: '16.16.0'
+          node-version: 'lts/*'
           cache: 'npm'
 
       - name: npm CI

.nvmrc

@@ -1 +1 @@
-v16.16.0
+lts/*

CHANGES.txt

@@ -1,3 +1,6 @@
+1.13.1 (January 11, 2024)
+ - Updated client `destroy` method to release SDK key immediately and avoid unexpected warning logs when a factory is created with the same SDK key after the previous one was destroyed.
+
 1.13.0 (January 4, 2024)
  - Removed the `getOptions` method from the `IPlatform` interface to simplify implementation. Request options can be handled within the `getFetch` method.
 

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "@splitsoftware/splitio-commons",
-  "version": "1.13.0",
+  "version": "1.13.1",
   "description": "Split Javascript SDK common components",
   "main": "cjs/index.js",
   "module": "esm/index.js",

package.json

@@ -56,8 +56,11 @@ export function sdkClientFactory(params: ISdkFactoryContext, isSharedClient?: bo
         // Mark the SDK as destroyed immediately
         sdkReadinessManager.readinessManager.destroy();
 
-        // record stat before flushing data
-        if (!isSharedClient) telemetryTracker.sessionLength();
+        // For main client, release the SDK Key and record stat before flushing data
+        if (!isSharedClient) {
+          releaseApiKey(settings.core.authorizationKey);
+          telemetryTracker.sessionLength();
+        }
 
         // Stop background jobs
         syncManager && syncManager.stop();
@@ -66,9 +69,6 @@ export function sdkClientFactory(params: ISdkFactoryContext, isSharedClient?: bo
           // Cleanup event listeners
           signalListener && signalListener.stop();
 
-          // Release the SDK Key if it is the main client
-          if (!isSharedClient) releaseApiKey(settings.core.authorizationKey);
-
           // @TODO stop only if last client is destroyed
           if (uniqueKeysTracker) uniqueKeysTracker.stop();