Skip to content

Commit d842d6c

Browse files
Move telemery tests to bottom
1 parent 2b26ced commit d842d6c

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

src/__tests__/nodeSuites/evaluations-fallback.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ export default async function (fetchMock, assert) {
113113

114114
await client.ready();
115115

116-
t.equal(client.getTreatment('emma@harness.io', 'real_split'), 'on', 'The evaluation will return the treatment defined in the flag if it exists');
116+
t.equal(client.getTreatment('emma@harness.io', 'user_account_in_whitelist'), 'off', 'The evaluation will return the treatment defined in the flag if it exists');
117117
t.equal(client.getTreatment('emma@harness.io', 'non_existent_flag'), 'OFF_FALLBACK', 'The evaluation will return `OFF_FALLBACK` if the flag does not exist and no fallbackTreatment is defined');
118118

119119
await client.destroy();

src/__tests__/online/node.spec.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -61,15 +61,14 @@ tape('## Node.js - E2E CI Tests ##', async function (assert) {
6161
/* Check client evaluations. */
6262
assert.test('E2E / In Memory', evaluationsSuite.bind(null, config, key));
6363
assert.test('E2E / In Memory - Semver', evaluationsSemverSuite.bind(null, fetchMock));
64+
assert.test('E2E / In Memory - Fallback treatment', evaluationsFallbackSuite.bind(null, fetchMock));
6465

6566
/* Check impressions */
6667
assert.test('E2E / Impressions', impressionsSuite.bind(null, key, fetchMock));
6768
assert.test('E2E / Impressions Debug Mode', impressionsSuiteDebug.bind(null, key, fetchMock));
6869
assert.test('E2E / Impressions None Mode', impressionsSuiteNone.bind(null, key, fetchMock));
6970
assert.test('E2E / Impressions listener', impressionsListenerSuite);
7071

71-
/* Check telemetry */
72-
assert.test('E2E / Telemetry', telemetrySuite.bind(null, key, fetchMock));
7372

7473
/* Check events in memory */
7574
assert.test('E2E / Events', eventsSuite.bind(null, fetchMock));
@@ -90,9 +89,6 @@ tape('## Node.js - E2E CI Tests ##', async function (assert) {
9089
/* Validate readiness with ready promises */
9190
assert.test('E2E / Ready promise', readyPromiseSuite.bind(null, key, fetchMock));
9291

93-
/* Check evaluations fallback */
94-
assert.test('E2E / In Memory - Fallback treatment', evaluationsFallbackSuite.bind(null, fetchMock));
95-
9692
/* Validate fetching specific splits */
9793
assert.test('E2E / Fetch specific splits', fetchSpecificSplits.bind(null, fetchMock));
9894
assert.test('E2E / Fetch specific splits for flag sets', fetchSpecificSplitsForFlagSets.bind(null, fetchMock));
@@ -105,5 +101,9 @@ tape('## Node.js - E2E CI Tests ##', async function (assert) {
105101
// @TODO remove when dropping support for Split Proxy v5.10.0 or below
106102
assert.test('E2E / Proxy fallback', proxyFallbackSuite.bind(null, fetchMock));
107103

104+
105+
/* Check telemetry */
106+
assert.test('E2E / Telemetry', telemetrySuite.bind(null, key, fetchMock));
107+
108108
assert.end();
109109
});

0 commit comments

Comments
 (0)