Skip to content

Commit c046061

Browse files
Fix localhost mode tests
1 parent f4c2de6 commit c046061

File tree

2 files changed

+17
-13
lines changed

2 files changed

+17
-13
lines changed

src/__tests__/offline/browser.spec.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -168,10 +168,10 @@ tape('Browser offline mode', function (assert) {
168168

169169
// Manager tests
170170
const expectedSplitView1 = {
171-
name: 'testing_split', trafficType: 'localhost', killed: false, changeNumber: 0, treatments: ['on'], configs: {}, defaultTreatment: 'control', sets: []
171+
name: 'testing_split', trafficType: 'localhost', killed: false, changeNumber: 0, treatments: ['on'], configs: {}, defaultTreatment: 'control', sets: [], trackImpressions: true
172172
};
173173
const expectedSplitView2 = {
174-
name: 'testing_split_with_config', trafficType: 'localhost', killed: false, changeNumber: 0, treatments: ['off'], configs: { off: '{ "color": "blue" }' }, defaultTreatment: 'control', sets: []
174+
name: 'testing_split_with_config', trafficType: 'localhost', killed: false, changeNumber: 0, treatments: ['off'], configs: { off: '{ "color": "blue" }' }, defaultTreatment: 'control', sets: [], trackImpressions: true
175175
};
176176
assert.deepEqual(manager.names(), ['testing_split', 'testing_split_with_config']);
177177
assert.deepEqual(manager.split('testing_split'), expectedSplitView1);
@@ -282,7 +282,7 @@ tape('Browser offline mode', function (assert) {
282282

283283
// Manager tests
284284
const expectedSplitView3 = {
285-
name: 'testing_split_with_config', trafficType: 'localhost', killed: false, changeNumber: 0, treatments: ['nope'], configs: {}, defaultTreatment: 'control', sets: []
285+
name: 'testing_split_with_config', trafficType: 'localhost', killed: false, changeNumber: 0, treatments: ['nope'], configs: {}, defaultTreatment: 'control', sets: [], trackImpressions: true
286286
};
287287
assert.deepEqual(manager.names(), ['testing_split', 'testing_split_2', 'testing_split_3', 'testing_split_with_config']);
288288
assert.deepEqual(manager.split('testing_split'), expectedSplitView1);

src/__tests__/offline/node.spec.js

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -250,17 +250,17 @@ function ManagerDotSplitTests(assert) {
250250
const expectedView1 = {
251251
name: 'testing_split', changeNumber: 0, killed: false, trafficType: 'localhost',
252252
treatments: ['on'], configs: {}, defaultTreatment: 'control',
253-
sets: []
253+
sets: [], trackImpressions: true
254254
};
255255
const expectedView2 = {
256256
name: 'testing_split2', changeNumber: 0, killed: false, trafficType: 'localhost',
257257
treatments: ['off'], configs: {}, defaultTreatment: 'control',
258-
sets: []
258+
sets: [], trackImpressions: true
259259
};
260260
const expectedView3 = {
261261
name: 'testing_split3', changeNumber: 0, killed: false, trafficType: 'localhost',
262262
treatments: ['custom_treatment'], configs: {}, defaultTreatment: 'control',
263-
sets: []
263+
sets: [], trackImpressions: true
264264
};
265265

266266
assert.deepEqual(manager.split('testing_split'), expectedView1);
@@ -294,7 +294,8 @@ function ManagerDotYamlTests(mockFileName, assert) {
294294
treatments: ['on'],
295295
configs: {},
296296
sets: [],
297-
defaultTreatment: 'control'
297+
defaultTreatment: 'control',
298+
trackImpressions: true
298299
};
299300
const expectedView2 = {
300301
name: 'testing_split_only_wl',
@@ -304,7 +305,8 @@ function ManagerDotYamlTests(mockFileName, assert) {
304305
treatments: ['whitelisted'],
305306
configs: {},
306307
sets: [],
307-
defaultTreatment: 'control'
308+
defaultTreatment: 'control',
309+
trackImpressions: true
308310
};
309311
const expectedView3 = {
310312
name: 'testing_split_with_wl',
@@ -317,7 +319,8 @@ function ManagerDotYamlTests(mockFileName, assert) {
317319
multi_key_wl: '{"color": "brown"}'
318320
},
319321
sets: [],
320-
defaultTreatment: 'control'
322+
defaultTreatment: 'control',
323+
trackImpressions: true
321324
};
322325
const expectedView4 = {
323326
name: 'testing_split_off_with_config',
@@ -329,7 +332,8 @@ function ManagerDotYamlTests(mockFileName, assert) {
329332
off: '{"color": "green"}'
330333
},
331334
sets: [],
332-
defaultTreatment: 'control'
335+
defaultTreatment: 'control',
336+
trackImpressions: true
333337
};
334338

335339
assert.deepEqual(manager.split('testing_split_on'), expectedView1);
@@ -410,15 +414,15 @@ function MultipleInstancesTests(assert) {
410414

411415
const expectedView1 = {
412416
name: 'testing_split', changeNumber: 0, killed: false, trafficType: 'localhost',
413-
treatments: ['on'], configs: {}, sets: []
417+
treatments: ['on'], configs: {}, sets: [], trackImpressions: true
414418
};
415419
const expectedView2 = {
416420
name: 'testing_split2', changeNumber: 0, killed: false, trafficType: 'localhost',
417-
treatments: ['off'], configs: {}, sets: []
421+
treatments: ['off'], configs: {}, sets: [], trackImpressions: true
418422
};
419423
const expectedView3 = {
420424
name: 'testing_split3', changeNumber: 0, killed: false, trafficType: 'localhost',
421-
treatments: ['custom_treatment'], configs: {}, sets: []
425+
treatments: ['custom_treatment'], configs: {}, sets: [], trackImpressions: true
422426
};
423427

424428
assert.deepEqual(manager.split('testing_split'), expectedView1);

0 commit comments

Comments
 (0)