Merge pull request #833 from splitio/remove_pluggable_localhost_mode

Refactor: updated internal modules

Author: EmilianoSanchez

.eslintrc

@@ -46,7 +46,7 @@
       ],
       "rules": {
         "no-restricted-syntax": ["error", "ForOfStatement", "ForInStatement", "ArrayPattern"],
-        "compat/compat": ["error", "defaults, ie 10, node 6"],
+        "compat/compat": ["error", "defaults, node >=14"],
         "no-throw-literal": "error",
         "import/no-default-export": "error",
         "import/no-self-import": "error"

package-lock.json

@@ -38,7 +38,7 @@
     "node": ">=14.0.0"
   },
   "dependencies": {
-    "@splitsoftware/splitio-commons": "2.0.0-rc.1",
+    "@splitsoftware/splitio-commons": "2.0.0-rc.3",
     "@types/ioredis": "^4.28.0",
     "bloom-filters": "^3.0.0",
     "ioredis": "^4.28.0",

package.json

@@ -11,6 +11,7 @@ import { __InLocalStorageMockFactory } from '@splitsoftware/splitio-commons/src/
 import { sdkFactory } from '@splitsoftware/splitio-commons/src/sdkFactory';
 import { LOCALHOST_MODE, STORAGE_LOCALSTORAGE } from '@splitsoftware/splitio-commons/src/utils/constants';
 import { createUserConsentAPI } from '@splitsoftware/splitio-commons/src/consent/sdkUserConsent';
+import { localhostFromObjectFactory } from '@splitsoftware/splitio-commons/src/sync/offline/LocalhostFromObject';
 
 import { settingsFactory } from '../settings/browser';
 import { platform, SignalListener } from '../platform';
@@ -60,7 +61,7 @@ function getModules(settings) {
   switch (settings.mode) {
     case LOCALHOST_MODE:
       modules.splitApiFactory = undefined;
-      modules.syncManagerFactory = settings.sync.localhostMode;
+      modules.syncManagerFactory = localhostFromObjectFactory;
       modules.SignalListener = undefined;
       break;
   }

src/factory/browser.js

@@ -10,6 +10,7 @@ import { impressionObserverSSFactory } from '@splitsoftware/splitio-commons/src/
 import { sdkFactory } from '@splitsoftware/splitio-commons/src/sdkFactory';
 import { CONSUMER_MODE, LOCALHOST_MODE } from '@splitsoftware/splitio-commons/src/utils/constants';
 
+import { localhostFromFileFactory } from '../sync/offline/LocalhostFromFile';
 import { settingsFactory } from '../settings/node';
 import { platform, SignalListener } from '../platform';
 import { bloomFilterFactory } from '../platform/filter/bloomFilter';
@@ -53,7 +54,7 @@ function getModules(settings) {
   switch (settings.mode) {
     case LOCALHOST_MODE:
       modules.splitApiFactory = undefined;
-      modules.syncManagerFactory = settings.sync.localhostMode;
+      modules.syncManagerFactory = localhostFromFileFactory;
       modules.SignalListener = undefined;
       break;
     case CONSUMER_MODE:

src/factory/node.js

@@ -1,7 +1,6 @@
 import { settingsValidation } from '@splitsoftware/splitio-commons/src/utils/settingsValidation';
 import { validateRuntime } from '@splitsoftware/splitio-commons/src/utils/settingsValidation/runtime';
 import { validateLogger } from '@splitsoftware/splitio-commons/src/utils/settingsValidation/logger/builtinLogger';
-import { LocalhostFromObject } from '@splitsoftware/splitio-commons/src/sync/offline/LocalhostFromObject';
 import { validateConsent } from '@splitsoftware/splitio-commons/src/utils/settingsValidation/consent';
 
 import { defaults } from './defaults/browser';
@@ -13,7 +12,6 @@ const params = {
   runtime: validateRuntime,
   storage: validateStorage,
   logger: validateLogger,
-  localhost: () => LocalhostFromObject(),
   consent: validateConsent,
 };
 

src/settings/browser.js

@@ -1,6 +1,5 @@
 import { settingsValidation } from '@splitsoftware/splitio-commons/src/utils/settingsValidation';
 import { validateLogger } from '@splitsoftware/splitio-commons/src/utils/settingsValidation/logger/builtinLogger';
-import { LocalhostFromFile } from '../sync/offline/LocalhostFromFile';
 
 import { defaults } from './defaults/node';
 import { validateStorage } from './storage/node';
@@ -13,7 +12,6 @@ const params = {
   runtime: validateRuntime,
   storage: validateStorage,
   logger: validateLogger,
-  localhost: () => LocalhostFromFile(),
   flagSpec: () => FLAG_SPEC_VERSION
   // In Node.js the SDK ignores `config.integrations`, so a validator for integrations is not required
 };

src/settings/node.js

@@ -1,11 +1,6 @@
 import { splitsParserFromFileFactory } from './splitsParserFromFile';
 import { syncManagerOfflineFactory } from '@splitsoftware/splitio-commons/src/sync/offline/syncManagerOffline';
 
-// Singleton instance of the factory function for offline SyncManager from YAML file (a.k.a. localhostFromFile)
+// Singleton instance of the factory function for offline SyncManager from YAML file
 // It uses NodeJS APIs.
-const localhostFromFile = syncManagerOfflineFactory(splitsParserFromFileFactory);
-localhostFromFile.type = 'LocalhostFromFile';
-
-export function LocalhostFromFile() {
-  return localhostFromFile;
-}
+export const localhostFromFileFactory = syncManagerOfflineFactory(splitsParserFromFileFactory);