Skip to content

Commit 71e0fec

Browse files
Handle localhost mode
1 parent 0fd1d58 commit 71e0fec

File tree

2 files changed

+12
-2
lines changed

2 files changed

+12
-2
lines changed

src/__tests__/offline/browser.spec.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,11 @@ tape('Browser offline mode', function (assert) {
5959
startup: {
6060
eventsFirstPushWindow: 0
6161
},
62-
features: originalFeaturesMap
62+
features: originalFeaturesMap,
63+
sync: {
64+
// ignored
65+
largeSegmentsEnabled: true
66+
}
6367
};
6468
const factory = SplitFactory(config);
6569
const manager = factory.manager();

src/settings/browser.js

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ import { validateRuntime } from '@splitsoftware/splitio-commons/src/utils/settin
33
import { validateLogger } from '@splitsoftware/splitio-commons/src/utils/settingsValidation/logger/builtinLogger';
44
import { LocalhostFromObject } from '@splitsoftware/splitio-commons/src/sync/offline/LocalhostFromObject';
55
import { validateConsent } from '@splitsoftware/splitio-commons/src/utils/settingsValidation/consent';
6+
import { STANDALONE_MODE } from '@splitsoftware/splitio-commons/src/utils/constants';
67

78
import { defaults } from './defaults/browser';
89
import { validateStorage } from './storage/browser';
@@ -20,5 +21,10 @@ const params = {
2021
};
2122

2223
export function settingsFactory(config) {
23-
return settingsValidation(config, params);
24+
const settings = settingsValidation(config, params);
25+
26+
// Override in localhost mode to properly emit SDK_READY
27+
if (settings.mode !== STANDALONE_MODE) settings.sync.largeSegmentsEnabled = false;
28+
29+
return settings;
2430
}

0 commit comments

Comments
 (0)