Skip to content

Commit 62723ec

Browse files
EmilianoSanchezEmilianoSanchez
committed
Update server-side tests with flag spec 1.1
1 parent 5211a8a commit 62723ec

23 files changed

+130
-130
lines changed

‎src/__tests__/destroy/node.spec.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@ import splitChangesMock1 from '../mocks/splitChanges.since.-1.till.1500492097547
1717
import splitChangesMock2 from '../mocks/splitChanges.since.1500492097547.json';
1818
import impressionsMock from '../mocks/impressions.json';
1919

20-
fetchMock.get(url(settings, '/splitChanges?s=1.2&since=-1'), { status: 200, body: splitChangesMock1 });
21-
fetchMock.get(url(settings, '/splitChanges?s=1.2&since=1500492097547'), { status: 200, body: splitChangesMock2 });
20+
fetchMock.get(url(settings, '/splitChanges?s=1.1&since=-1'), { status: 200, body: splitChangesMock1 });
21+
fetchMock.get(url(settings, '/splitChanges?s=1.1&since=1500492097547'), { status: 200, body: splitChangesMock2 });
2222
fetchMock.postOnce(url(settings, '/v1/metrics/config'), 200);
2323

2424
tape('SDK destroy for NodeJS', async function (assert) {

‎src/__tests__/errorCatching/node.spec.js‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,9 @@ const settings = settingsFactory({
2121
streamingEnabled: false
2222
});
2323

24-
fetchMock.get(url(settings, '/splitChanges?s=1.2&since=-1'), { status: 200, body: splitChangesMock1 }, responseDelay);
25-
fetchMock.get(url(settings, '/splitChanges?s=1.2&since=1500492097547'), { status: 200, body: splitChangesMock2 }, responseDelay);
26-
fetchMock.get(url(settings, '/splitChanges?s=1.2&since=1500492297547'), { status: 200, body: splitChangesMock3 }, responseDelay);
24+
fetchMock.get(url(settings, '/splitChanges?s=1.1&since=-1'), { status: 200, body: splitChangesMock1 }, responseDelay);
25+
fetchMock.get(url(settings, '/splitChanges?s=1.1&since=1500492097547'), { status: 200, body: splitChangesMock2 }, responseDelay);
26+
fetchMock.get(url(settings, '/splitChanges?s=1.1&since=1500492297547'), { status: 200, body: splitChangesMock3 }, responseDelay);
2727
fetchMock.postOnce(url(settings, '/v1/metrics/config'), 200); // SDK_READY
2828
fetchMock.postOnce(url(settings, '/v1/metrics/usage'), 200); // SDK destroyed
2929

‎src/__tests__/nodeSuites/evaluations-semver.spec.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@ const config = {
2424

2525
export default async function (fetchMock, assert) {
2626

27-
fetchMock.getOnce(config.urls.sdk + '/splitChanges?s=1.2&since=-1', { status: 200, body: splitChangesMock1 });
28-
fetchMock.get(config.urls.sdk + '/splitChanges?s=1.2&since=1675259356568', { status: 200, body: { splits: [], since: 1675259356568, till: 1675259356568 } });
27+
fetchMock.getOnce(config.urls.sdk + '/splitChanges?s=1.1&since=-1', { status: 200, body: splitChangesMock1 });
28+
fetchMock.get(config.urls.sdk + '/splitChanges?s=1.1&since=1675259356568', { status: 200, body: { splits: [], since: 1675259356568, till: 1675259356568 } });
2929

3030
const splitio = SplitFactory(config);
3131
const client = splitio.client();

‎src/__tests__/nodeSuites/expected-treatments.spec.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import { url } from '../testUtils';
66
import splitChangesMockReal from '../mocks/splitchanges.real.json';
77

88
export default async function (config, settings, fetchMock, assert) {
9-
fetchMock.get({ url: url(settings, '/splitChanges?s=1.2&since=-1'), overwriteRoutes: true }, { status: 200, body: splitChangesMockReal });
9+
fetchMock.get({ url: url(settings, '/splitChanges?s=1.1&since=-1'), overwriteRoutes: true }, { status: 200, body: splitChangesMockReal });
1010

1111
const splitio = SplitFactory({
1212
...config,

‎src/__tests__/nodeSuites/fetch-specific-splits.spec.js‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,9 @@ export function fetchSpecificSplits(fetchMock, assert) {
2323
const queryString = queryStrings[i] || '';
2424
let factory;
2525

26-
fetchMock.getOnce(urls.sdk + '/splitChanges?s=1.2&since=-1' + queryString, { status: 200, body: { splits: [], since: -1, till: 1457552620999 } });
27-
fetchMock.getOnce(urls.sdk + '/splitChanges?s=1.2&since=1457552620999' + queryString, { status: 200, body: { splits: [], since: 1457552620999, till: 1457552620999 } });
28-
fetchMock.getOnce(urls.sdk + '/splitChanges?s=1.2&since=1457552620999' + queryString, function () {
26+
fetchMock.getOnce(urls.sdk + '/splitChanges?s=1.1&since=-1' + queryString, { status: 200, body: { splits: [], since: -1, till: 1457552620999 } });
27+
fetchMock.getOnce(urls.sdk + '/splitChanges?s=1.1&since=1457552620999' + queryString, { status: 200, body: { splits: [], since: 1457552620999, till: 1457552620999 } });
28+
fetchMock.getOnce(urls.sdk + '/splitChanges?s=1.1&since=1457552620999' + queryString, function () {
2929
factory.client().destroy().then(() => {
3030
assert.pass(`splitFilters #${i}`);
3131
});
@@ -64,8 +64,8 @@ export function fetchSpecificSplitsForFlagSets(fetchMock, assert) {
6464
let factory;
6565
const queryString = '&sets=4_valid,set_2,set_3,set_ww,set_x';
6666

67-
fetchMock.getOnce(baseUrls.sdk + '/splitChanges?s=1.2&since=-1' + queryString, { status: 200, body: { splits: [], since: 1457552620999, till: 1457552620999 }});
68-
fetchMock.getOnce(baseUrls.sdk + '/splitChanges?s=1.2&since=1457552620999' + queryString, async function () {
67+
fetchMock.getOnce(baseUrls.sdk + '/splitChanges?s=1.1&since=-1' + queryString, { status: 200, body: { splits: [], since: 1457552620999, till: 1457552620999 }});
68+
fetchMock.getOnce(baseUrls.sdk + '/splitChanges?s=1.1&since=1457552620999' + queryString, async function () {
6969
t.pass('flag set query correctly formed');
7070
factory.client().destroy().then(() => {
7171
t.end();

‎src/__tests__/nodeSuites/flag-sets.spec.js‎

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -26,12 +26,12 @@ export default function flagSets(fetchMock, t) {
2626
let factory, manager, client = [];
2727

2828
// Receive split change with 1 split belonging to set_1 & set_2 and one belonging to set_3
29-
fetchMock.getOnce(baseUrls.sdk + '/splitChanges?s=1.2&since=-1&sets=set_1,set_2', function () {
29+
fetchMock.getOnce(baseUrls.sdk + '/splitChanges?s=1.1&since=-1&sets=set_1,set_2', function () {
3030
return { status: 200, body: splitChange2};
3131
});
3232

3333
// Receive split change with 1 split belonging to set_1 only
34-
fetchMock.getOnce(baseUrls.sdk + '/splitChanges?s=1.2&since=1602796638344&sets=set_1,set_2', function () {
34+
fetchMock.getOnce(baseUrls.sdk + '/splitChanges?s=1.1&since=1602796638344&sets=set_1,set_2', function () {
3535
// stored feature flags before update
3636
const storedFlags = manager.splits();
3737
assert.true(storedFlags.length === 1, 'only one feature flag should be added');
@@ -43,7 +43,7 @@ export default function flagSets(fetchMock, t) {
4343
});
4444

4545
// Receive split change with 1 split belonging to set_3 only
46-
fetchMock.getOnce(baseUrls.sdk + '/splitChanges?s=1.2&since=1602797638344&sets=set_1,set_2', function () {
46+
fetchMock.getOnce(baseUrls.sdk + '/splitChanges?s=1.1&since=1602797638344&sets=set_1,set_2', function () {
4747
// stored feature flags before update
4848
const storedFlags = manager.splits();
4949
assert.true(storedFlags.length === 1);
@@ -54,7 +54,7 @@ export default function flagSets(fetchMock, t) {
5454
return { status: 200, body: splitChange0};
5555
});
5656

57-
fetchMock.getOnce(baseUrls.sdk + '/splitChanges?s=1.2&since=1602798638344&sets=set_1,set_2', async function () {
57+
fetchMock.getOnce(baseUrls.sdk + '/splitChanges?s=1.1&since=1602798638344&sets=set_1,set_2', async function () {
5858
// stored feature flags before update
5959
const storedFlags = manager.splits();
6060
assert.true(storedFlags.length === 0, 'the feature flag should be removed');
@@ -79,12 +79,12 @@ export default function flagSets(fetchMock, t) {
7979
let factory, manager, client = [];
8080

8181
// Receive split change with 1 split belonging to set_1 & set_2 and one belonging to set_3
82-
fetchMock.getOnce(baseUrls.sdk + '/splitChanges?s=1.2&since=-1', function () {
82+
fetchMock.getOnce(baseUrls.sdk + '/splitChanges?s=1.1&since=-1', function () {
8383
return { status: 200, body: splitChange2};
8484
});
8585

8686
// Receive split change with 1 split belonging to set_1 only
87-
fetchMock.getOnce(baseUrls.sdk + '/splitChanges?s=1.2&since=1602796638344', function () {
87+
fetchMock.getOnce(baseUrls.sdk + '/splitChanges?s=1.1&since=1602796638344', function () {
8888
// stored feature flags before update
8989
const storedFlags = manager.splits();
9090
assert.true(storedFlags.length === 2, 'every feature flag should be added');
@@ -98,7 +98,7 @@ export default function flagSets(fetchMock, t) {
9898
});
9999

100100
// Receive split change with 1 split belonging to set_3 only
101-
fetchMock.getOnce(baseUrls.sdk + '/splitChanges?s=1.2&since=1602797638344', function () {
101+
fetchMock.getOnce(baseUrls.sdk + '/splitChanges?s=1.1&since=1602797638344', function () {
102102
// stored feature flags before update
103103
const storedFlags = manager.splits();
104104
assert.true(storedFlags.length === 2);
@@ -111,7 +111,7 @@ export default function flagSets(fetchMock, t) {
111111
return { status: 200, body: splitChange0};
112112
});
113113

114-
fetchMock.getOnce(baseUrls.sdk + '/splitChanges?s=1.2&since=1602798638344', async function () {
114+
fetchMock.getOnce(baseUrls.sdk + '/splitChanges?s=1.1&since=1602798638344', async function () {
115115
// stored feature flags before update
116116
const storedFlags = manager.splits();
117117
assert.true(storedFlags.length === 2);
@@ -142,11 +142,11 @@ export default function flagSets(fetchMock, t) {
142142
mockSegmentChanges(fetchMock, new RegExp(baseUrls.sdk + '/segmentChanges/*'), []);
143143
fetchMock.post('*', 200);
144144
// Receive split change with 1 split belonging to set_1 & set_2 and one belonging to set_3
145-
fetchMock.getOnce(baseUrls.sdk + '/splitChanges?s=1.2&since=-1&sets=set_1', function () {
145+
fetchMock.getOnce(baseUrls.sdk + '/splitChanges?s=1.1&since=-1&sets=set_1', function () {
146146
return { status: 200, body: splitChange2};
147147
});
148148

149-
fetchMock.getOnce(baseUrls.sdk + '/splitChanges?s=1.2&since=1602796638344&sets=set_1', async function () {
149+
fetchMock.getOnce(baseUrls.sdk + '/splitChanges?s=1.1&since=1602796638344&sets=set_1', async function () {
150150
// stored feature flags before update
151151
assert.deepEqual(client.getTreatmentsByFlagSet(key, 'set_1'), {workm: 'on'}, 'only the flag in set_1 can be evaluated');
152152
assert.deepEqual(client.getTreatmentsByFlagSet(key, 'set_2'), {}, 'only the flag in set_1 can be evaluated');
@@ -180,11 +180,11 @@ export default function flagSets(fetchMock, t) {
180180
fetchMock.post('*', 200);
181181

182182
// Receive split change with 1 split belonging to set_1 & set_2 and one belonging to set_3
183-
fetchMock.getOnce(baseUrls.sdk + '/splitChanges?s=1.2&since=-1', function () {
183+
fetchMock.getOnce(baseUrls.sdk + '/splitChanges?s=1.1&since=-1', function () {
184184
return { status: 200, body: splitChange2};
185185
});
186186

187-
fetchMock.getOnce(baseUrls.sdk + '/splitChanges?s=1.2&since=1602796638344', async function () {
187+
fetchMock.getOnce(baseUrls.sdk + '/splitChanges?s=1.1&since=1602796638344', async function () {
188188
// stored feature flags before update
189189
assert.deepEqual(client.getTreatmentsByFlagSet(key, 'set_1'), {workm: 'on'}, 'all flags can be evaluated');
190190
assert.deepEqual(client.getTreatmentsByFlagSet(key, 'set_2'), {workm: 'on'}, 'all flags can be evaluated');

‎src/__tests__/nodeSuites/impressions.debug.spec.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,8 @@ const config = {
4040

4141
export default async function (key, fetchMock, assert) {
4242
// Mocking this specific route to make sure we only get the items we want to test from the handlers.
43-
fetchMock.getOnce(url(settings, '/splitChanges?s=1.2&since=-1'), { status: 200, body: splitChangesMock1 });
44-
fetchMock.get(url(settings, '/splitChanges?s=1.2&since=1457552620999'), { status: 200, body: splitChangesMock2 });
43+
fetchMock.getOnce(url(settings, '/splitChanges?s=1.1&since=-1'), { status: 200, body: splitChangesMock1 });
44+
fetchMock.get(url(settings, '/splitChanges?s=1.1&since=1457552620999'), { status: 200, body: splitChangesMock2 });
4545
fetchMock.get(new RegExp(`${url(settings, '/segmentChanges/')}.*`), { status: 200, body: { since: 10, till: 10, name: 'segmentName', added: [], removed: [] } });
4646

4747
const splitio = SplitFactory(config);

‎src/__tests__/nodeSuites/impressions.none.spec.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,8 @@ const config = {
3939

4040
export default async function (key, fetchMock, assert) {
4141
// Mocking this specific route to make sure we only get the items we want to test from the handlers.
42-
fetchMock.getOnce(url(settings, '/splitChanges?s=1.2&since=-1'), { status: 200, body: splitChangesMock1 });
43-
fetchMock.get(url(settings, '/splitChanges?s=1.2&since=1457552620999'), { status: 200, body: splitChangesMock2 });
42+
fetchMock.getOnce(url(settings, '/splitChanges?s=1.1&since=-1'), { status: 200, body: splitChangesMock1 });
43+
fetchMock.get(url(settings, '/splitChanges?s=1.1&since=1457552620999'), { status: 200, body: splitChangesMock2 });
4444
fetchMock.get(new RegExp(`${url(settings, '/segmentChanges/')}.*`), { status: 200, body: { since: 10, till: 10, name: 'segmentName', added: [], removed: [] } });
4545

4646
const splitio = SplitFactory(config);

‎src/__tests__/nodeSuites/impressions.spec.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,8 @@ let truncatedTimeFrame;
3737

3838
export default async function (key, fetchMock, assert) {
3939
// Mocking this specific route to make sure we only get the items we want to test from the handlers.
40-
fetchMock.getOnce(url(settings, '/splitChanges?s=1.2&since=-1'), { status: 200, body: splitChangesMock1 });
41-
fetchMock.get(url(settings, '/splitChanges?s=1.2&since=1457552620999'), { status: 200, body: splitChangesMock2 });
40+
fetchMock.getOnce(url(settings, '/splitChanges?s=1.1&since=-1'), { status: 200, body: splitChangesMock1 });
41+
fetchMock.get(url(settings, '/splitChanges?s=1.1&since=1457552620999'), { status: 200, body: splitChangesMock2 });
4242
fetchMock.get(new RegExp(`${url(settings, '/segmentChanges/')}.*`), { status: 200, body: { since: 10, till: 10, name: 'segmentName', added: [], removed: [] } });
4343

4444
const splitio = SplitFactory(config);

‎src/__tests__/nodeSuites/ip-addresses-setting.debug.spec.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,8 +77,8 @@ export default function ipAddressesSettingAssertions(fetchMock, assert) {
7777
})();
7878

7979
// Mock GET endpoints to run client normally
80-
fetchMock.getOnce(url(settings, '/splitChanges?s=1.2&since=-1'), { status: 200, body: splitChangesMock1 });
81-
fetchMock.getOnce(url(settings, '/splitChanges?s=1.2&since=1457552620999'), { status: 200, body: { splits: [], since: 1457552620999, till: 1457552620999 } });
80+
fetchMock.getOnce(url(settings, '/splitChanges?s=1.1&since=-1'), { status: 200, body: splitChangesMock1 });
81+
fetchMock.getOnce(url(settings, '/splitChanges?s=1.1&since=1457552620999'), { status: 200, body: { splits: [], since: 1457552620999, till: 1457552620999 } });
8282
fetchMock.get(new RegExp(`${url(settings, '/segmentChanges/')}.*`), { status: 200, body: { since: 10, till: 10, name: 'segmentName', added: [], removed: [] } });
8383

8484
// Mock and assert POST endpoints

0 commit comments

Comments
 (0)