Merge pull request #751 from splitio/development

Release v10.22.6

Author: EmilianoSanchez

.github/CODEOWNERS

@@ -0,0 +1 @@
+* @splitio/sdk

CHANGES.txt

@@ -1,3 +1,8 @@
+10.22.6 (July 6, 2023)
+ - Updated some transitive dependencies for vulnerability fixes.
+ - Updated @splitsoftware/splitio-commons package to version 1.8.3 that includes the following bug fix:
+    - Bugfix - The `destroy` method has been updated to immediately flag the SDK client as destroyed, to prevent access to the storage when `getTreatment` and `track` methods are called after the SDK is destroyed.
+
 10.22.5 (May 15, 2023)
  - Updated @splitsoftware/splitio-commons package to version 1.8.2 that includes minor improvements.
     - Updated terminology on the SDKs codebase to be more aligned with current standard without causing a breaking change. The core change is the term split for feature flag on things like logs and IntelliSense comments.

README.md

@@ -64,6 +64,7 @@ Split has built and maintains SDKs for:
 
 * .NET [Github](https://github.com/splitio/dotnet-client) [Docs](https://help.split.io/hc/en-us/articles/360020240172--NET-SDK)
 * Android [Github](https://github.com/splitio/android-client) [Docs](https://help.split.io/hc/en-us/articles/360020343291-Android-SDK)
+* Angular [Github](https://github.com/splitio/angular-sdk-plugin) [Docs](https://help.split.io/hc/en-us/articles/6495326064397-Angular-utilities)
 * GO [Github](https://github.com/splitio/go-client) [Docs](https://help.split.io/hc/en-us/articles/360020093652-Go-SDK)
 * iOS [Github](https://github.com/splitio/ios-client) [Docs](https://help.split.io/hc/en-us/articles/360020401491-iOS-SDK)
 * Java [Github](https://github.com/splitio/java-client) [Docs](https://help.split.io/hc/en-us/articles/360020405151-Java-SDK)

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "@splitsoftware/splitio",
-  "version": "10.22.5",
+  "version": "10.22.6",
   "description": "Split SDK",
   "files": [
     "README.md",
@@ -40,7 +40,7 @@
     "node": ">=6"
   },
   "dependencies": {
-    "@splitsoftware/splitio-commons": "1.8.2",
+    "@splitsoftware/splitio-commons": "1.8.3",
     "@types/google.analytics": "0.0.40",
     "@types/ioredis": "^4.28.0",
     "bloom-filters": "^3.0.0",
@@ -59,7 +59,7 @@
     "cross-env": "^7.0.3",
     "csv-streamify": "4.0.0",
     "eslint": "^8.0.1",
-    "eslint-plugin-compat": "^4.0.2",
+    "eslint-plugin-compat": "^4.1.4",
     "eslint-plugin-import": "^2.25.4",
     "fetch-mock": "^9.11.0",
     "karma": "^6.3.16",

package.json

@@ -130,8 +130,7 @@ tape('SDK destroy for BrowserJS', async function (assert) {
   assert.ok(manager.names().length > 0, 'control assertion');
   assert.notOk(client2.track('tt', 'eventType', 2), 'After destroy, track calls return false.');
 
-  await client.destroy();
-  fetchMock.restore();
+  const destroyPromise = client.destroy();
 
   assert.equal(client.getTreatment('Single_Test'), 'control', 'After destroy, getTreatment returns control for every destroyed client.');
   assert.deepEqual(client.getTreatments(['Single_Test']), { 'Single_Test': 'control' }, 'After destroy, getTreatments returns map of controls for every destroyed client.');
@@ -141,5 +140,8 @@ tape('SDK destroy for BrowserJS', async function (assert) {
   assert.equal(manager.names().length, 0, 'After the main client is destroyed, manager.names will return empty array');
   assert.equal(manager.split('Single_Test'), null, 'After the main client is destroyed, manager.split will return null');
 
+  await destroyPromise;
+  fetchMock.restore();
+
   assert.end();
 });

src/__tests__/destroy/browser.spec.js

@@ -109,10 +109,6 @@ tape('SDK destroy for NodeJS', async function (assert) {
 
   const destroyPromise = client.destroy();
 
-  assert.true(destroyPromise instanceof Promise, 'client.destroy() should return a promise.');
-
-  await destroyPromise;
-
   assert.equal(client.getTreatment('ut1', 'Single_Test'), 'control', 'After destroy, getTreatment returns control.');
   assert.deepEqual(client.getTreatments('ut1', ['Single_Test', 'another_split']), {
     Single_Test: 'control', another_split: 'control'
@@ -122,5 +118,9 @@ tape('SDK destroy for NodeJS', async function (assert) {
   assert.equal(manager.names().length, 0, 'After destroy, manager.names returns empty array.');
   assert.equal(manager.split('Single_Test'), null, 'After destroy, manager.split returns null.');
 
+  assert.true(destroyPromise instanceof Promise, 'client.destroy() should return a promise.');
+
+  await destroyPromise;
+
   assert.end();
 });

src/__tests__/destroy/node.spec.js

@@ -1 +1 @@
-export const packageVersion = '10.22.5';
+export const packageVersion = '10.22.6';

src/settings/defaults/version.js

@@ -1,7 +1,7 @@
 import { LOCALHOST_MODE, STORAGE_MEMORY, STORAGE_REDIS, CONSUMER_MODE, STANDALONE_MODE } from '@splitsoftware/splitio-commons/src/utils/constants';
 
 export function validateStorage(settings) {
-  let {
+  const {
     log,
     mode,
     storage: {

src/settings/storage/node.js

@@ -6,7 +6,7 @@
   "license": "Apache-2.0",
   "repository": "splitio/javascript-client",
   "dependencies": {
-    "@types/node": "^14.18.46",
+    "@types/node": "^14.18.52",
     "typescript": "^3.7.4"
   }
 }