Skip to content

Commit 5143841

Browse files
EmilianoSanchezEmilianoSanchez
authored
Merge pull request #856 from splitio/development
Release v11.0.4
2 parents 61ff938 + b291279 commit 5143841

File tree

13 files changed

+36
-33
lines changed

13 files changed

+36
-33
lines changed

‎.github/workflows/ci-cd.yml‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ jobs:
3434
run: redis-cli ping
3535

3636
- name: Setup Node.js
37-
uses: actions/setup-node@v3
37+
uses: actions/setup-node@v4
3838
with:
3939
node-version: 'lts/*'
4040
cache: 'npm'
@@ -59,7 +59,7 @@ jobs:
5959

6060
- name: Store assets
6161
if: ${{ github.event_name == 'push' && (github.ref == 'refs/heads/development' || github.ref == 'refs/heads/master') }}
62-
uses: actions/upload-artifact@v3
62+
uses: actions/upload-artifact@v4
6363
with:
6464
name: assets
6565
path: umd/
@@ -81,7 +81,7 @@ jobs:
8181

8282
steps:
8383
- name: Download assets
84-
uses: actions/download-artifact@v3
84+
uses: actions/download-artifact@v4
8585
with:
8686
name: assets
8787
path: umd
@@ -91,7 +91,7 @@ jobs:
9191
working-directory: umd
9292

9393
- name: Configure AWS credentials
94-
uses: aws-actions/configure-aws-credentials@v1-node16
94+
uses: aws-actions/configure-aws-credentials@v4
9595
with:
9696
role-to-assume: arn:aws:iam::${{ matrix.account_id }}:role/gha-public-assets-role
9797
aws-region: us-east-1
@@ -120,7 +120,7 @@ jobs:
120120

121121
steps:
122122
- name: Download assets
123-
uses: actions/download-artifact@v3
123+
uses: actions/download-artifact@v4
124124
with:
125125
name: assets
126126
path: umd
@@ -130,7 +130,7 @@ jobs:
130130
working-directory: umd
131131

132132
- name: Configure AWS credentials
133-
uses: aws-actions/configure-aws-credentials@v1-node16
133+
uses: aws-actions/configure-aws-credentials@v4
134134
with:
135135
role-to-assume: arn:aws:iam::${{ matrix.account_id }}:role/gha-public-assets-role
136136
aws-region: us-east-1

‎CHANGES.txt‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
11.0.4 (January 9, 2025)
2+
- Bugfixing - Updated @splitsoftware/splitio-commons package to version 2.0.3, which properly handles rejected promises when using targeting rules with segment matchers in consumer modes (e.g., Redis and Pluggable storages).
3+
14
11.0.3 (December 4, 2024)
25
- Bugfixing - Updated @splitsoftware/splitio-commons package to version 2.0.2 that sanitizes the `SplitSDKMachineName` header value to avoid exceptions on HTTP/S requests when it contains non ISO-8859-1 characters (Related to issue https://github.com/splitio/javascript-client/issues/847).
36

‎LICENSE‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
Copyright © 2024 Split Software, Inc.
1+
Copyright © 2025 Split Software, Inc.
22

33
Licensed under the Apache License, Version 2.0 (the "License");
44
you may not use this file except in compliance with the License.

‎README.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,4 +84,4 @@ For a comprehensive list of open source projects visit our [Github page](https:/
8484

8585
**Learn more about Split:**
8686

87-
Visit [split.io/product](https://www.split.io/product) for an overview of Split, or visit our documentation at [help.split.io](http://help.split.io) for more detailed information.
87+
Visit [split.io/product](https://www.split.io/product) for an overview of Split, or visit our documentation at [help.split.io](https://help.split.io) for more detailed information.

‎package-lock.json‎

Lines changed: 9 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎package.json‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@splitsoftware/splitio",
3-
"version": "11.0.3",
3+
"version": "11.0.4",
44
"description": "Split SDK",
55
"files": [
66
"README.md",
@@ -38,7 +38,7 @@
3838
"node": ">=14.0.0"
3939
},
4040
"dependencies": {
41-
"@splitsoftware/splitio-commons": "2.0.2",
41+
"@splitsoftware/splitio-commons": "2.0.3",
4242
"bloom-filters": "^3.0.4",
4343
"ioredis": "^4.28.0",
4444
"js-yaml": "^3.13.1",

‎src/__tests__/browserSuites/ready-from-cache.spec.js‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -564,7 +564,7 @@ export default function (fetchMock, assert) {
564564
});
565565

566566
client.once(client.Event.SDK_READY, () => {
567-
t.deepEqual(manager.names(), ['p1__split', 'p2__split'], 'p1__split should be added for evaluation');
567+
t.deepEqual(manager.names().sort(), ['p1__split', 'p2__split'], 'p1__split should be added for evaluation');
568568

569569
client.destroy().then(() => {
570570
t.equal(localStorage.getItem('readyFromCache_5B.SPLITIO.splits.till'), '1457552620999', 'splits.till must correspond to the till of the last successfully fetched Splits');
@@ -610,11 +610,11 @@ export default function (fetchMock, assert) {
610610
const manager = splitio.manager();
611611

612612
client.once(client.Event.SDK_READY_FROM_CACHE, () => {
613-
t.deepEqual(manager.names(), ['p2__split', 'p1__split'], 'splits shouldn\'t be removed for evaluation');
613+
t.deepEqual(manager.names().sort(), ['p1__split', 'p2__split'], 'splits shouldn\'t be removed for evaluation');
614614
});
615615

616616
client.once(client.Event.SDK_READY, () => {
617-
t.deepEqual(manager.names(), ['p2__split', 'p1__split'], 'active splits should be present for evaluation');
617+
t.deepEqual(manager.names().sort(), ['p1__split', 'p2__split'], 'active splits should be present for evaluation');
618618

619619
client.destroy().then(() => {
620620
t.equal(localStorage.getItem('some_user_item'), 'user_item', 'user items at localStorage must not be changed');
@@ -667,7 +667,7 @@ export default function (fetchMock, assert) {
667667
});
668668

669669
client.once(client.Event.SDK_READY, () => {
670-
t.deepEqual(manager.names(), ['p2__split', 'p1__split'], 'active splits should be present for evaluation');
670+
t.deepEqual(manager.names().sort(), ['p1__split', 'p2__split'], 'active splits should be present for evaluation');
671671

672672
client.destroy().then(() => {
673673
t.equal(localStorage.getItem('some_user_item'), 'user_item', 'user items at localStorage must not be changed');
@@ -780,7 +780,7 @@ export default function (fetchMock, assert) {
780780
const manager = splitio.manager();
781781

782782
client.once(client.Event.SDK_READY, () => {
783-
t.deepEqual(manager.names(), ['p3__split', 'p2__split'], 'active splits should be present for evaluation');
783+
t.deepEqual(manager.names().sort(), ['p2__split', 'p3__split'], 'active splits should be present for evaluation');
784784

785785
client.destroy().then(() => {
786786
t.equal(localStorage.getItem('some_user_item'), 'user_item', 'user items at localStorage must not be changed');

‎src/__tests__/consumer/node_redis.spec.js‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,7 @@ tape('Node.js Redis', function (t) {
181181
assert.deepEqual(trackedImpressionsAndEvents, [TOTAL_RAW_IMPRESSIONS, TOTAL_EVENTS], 'Tracked impressions and events should be stored in Redis');
182182

183183
// Validate stored telemetry
184-
exec(`echo "HLEN ${config.storage.prefix}.SPLITIO.telemetry.latencies \n HLEN ${config.storage.prefix}.SPLITIO.telemetry.exceptions \n HGET ${config.storage.prefix}.SPLITIO.telemetry.init nodejs-${version}/${HOSTNAME_VALUE}/${IP_VALUE}" | redis-cli -p ${redisPort}`, (error, stdout) => {
184+
exec(`echo "HLEN ${config.storage.prefix}.SPLITIO.telemetry.latencies \n HLEN ${config.storage.prefix}.SPLITIO.telemetry.exceptions \n HGET ${config.storage.prefix}.SPLITIO.telemetry.init 'nodejs-${version}/${HOSTNAME_VALUE}/${IP_VALUE}'" | redis-cli -p ${redisPort}`, (error, stdout) => {
185185
if (error) assert.fail('Redis server should be reachable');
186186

187187
const [latencies, exceptions, configValue] = stdout.split('\n').filter(line => line !== '').map(JSON.parse);
@@ -304,7 +304,7 @@ tape('Node.js Redis', function (t) {
304304
assert.deepEqual(trackedImpressionsAndEvents, [TOTAL_RAW_IMPRESSIONS - DEDUPED_IMPRESSIONS, TOTAL_EVENTS], 'Tracked impressions and events should be stored in Redis');
305305

306306
// Validate stored telemetry
307-
exec(`echo "HLEN ${config.storage.prefix}.SPLITIO.telemetry.latencies \n HLEN ${config.storage.prefix}.SPLITIO.telemetry.exceptions \n HGET ${config.storage.prefix}.SPLITIO.telemetry.init nodejs-${version}/${HOSTNAME_VALUE}/${IP_VALUE}" | redis-cli -p ${redisPort}`, (error, stdout) => {
307+
exec(`echo "HLEN ${config.storage.prefix}.SPLITIO.telemetry.latencies \n HLEN ${config.storage.prefix}.SPLITIO.telemetry.exceptions \n HGET ${config.storage.prefix}.SPLITIO.telemetry.init 'nodejs-${version}/${HOSTNAME_VALUE}/${IP_VALUE}'" | redis-cli -p ${redisPort}`, (error, stdout) => {
308308
if (error) assert.fail('Redis server should be reachable');
309309

310310
const [latencies, exceptions, configValue] = stdout.split('\n').filter(line => line !== '').map(JSON.parse);
@@ -406,7 +406,7 @@ tape('Node.js Redis', function (t) {
406406
assert.deepEqual(trackedImpressionsAndEvents, [0, TOTAL_EVENTS], 'No impressions are stored in Redis in NONE impressions mode');
407407

408408
// Validate stored telemetry
409-
exec(`echo "HLEN ${config.storage.prefix}.SPLITIO.telemetry.latencies \n HLEN ${config.storage.prefix}.SPLITIO.telemetry.exceptions \n HGET ${config.storage.prefix}.SPLITIO.telemetry.init nodejs-${version}/${HOSTNAME_VALUE}/${IP_VALUE}" | redis-cli -p ${redisPort}`, (error, stdout) => {
409+
exec(`echo "HLEN ${config.storage.prefix}.SPLITIO.telemetry.latencies \n HLEN ${config.storage.prefix}.SPLITIO.telemetry.exceptions \n HGET ${config.storage.prefix}.SPLITIO.telemetry.init 'nodejs-${version}/${HOSTNAME_VALUE}/${IP_VALUE}'" | redis-cli -p ${redisPort}`, (error, stdout) => {
410410
if (error) assert.fail('Redis server should be reachable');
411411

412412
const [latencies, exceptions, configValue] = stdout.split('\n').filter(line => line !== '').map(JSON.parse);

‎src/__tests__/testUtils/index.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@ export function nearlyEqual(actual, expected, epsilon = DEFAULT_ERROR_MARGIN) {
1818
* - when `?since=-1`, it returns the given segment `keys` in `added` list.
1919
* - otherwise, it returns empty `added` and `removed` lists, and the same since and till values.
2020
*
21-
* @param {Object} fetchMock see http://www.wheresrhys.co.uk/fetch-mock
22-
* @param {string|RegExp|...} matcher see http://www.wheresrhys.co.uk/fetch-mock/#api-mockingmock_matcher
21+
* @param {Object} fetchMock see https://www.wheresrhys.co.uk/fetch-mock
22+
* @param {string|RegExp|...} matcher see https://www.wheresrhys.co.uk/fetch-mock/#api-mockingmock_matcher
2323
* @param {string[]} keys array of segment keys to fetch
2424
* @param {number} changeNumber optional changeNumber
2525
*/

‎src/settings/defaults/version.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
export const packageVersion = '11.0.3';
1+
export const packageVersion = '11.0.4';

0 commit comments

Comments
 (0)