update ci-cd to simplify RC releases

Author: EmilianoSanchez

.github/workflows/ci-cd.yml

@@ -55,7 +55,7 @@ jobs:
         run: npm run test-node
 
       - name: npm build
-        run: BUILD_BRANCH=$(echo "${GITHUB_REF#refs/heads/}") BUILD_COMMIT=${{ github.sha }} npm run build
+        run: BUILD_BRANCH=$(echo "${GITHUB_REF#refs/heads/}") npm run build
 
       - name: Store assets
         if: ${{ github.event_name == 'push' && (github.ref == 'refs/heads/development' || github.ref == 'refs/heads/master') }}

.github/workflows/sonar-scan.yml

@@ -32,7 +32,7 @@ jobs:
         run: npm run check
 
       - name: npm Build
-        run: BUILD_BRANCH=$(echo "${GITHUB_REF#refs/heads/}") BUILD_COMMIT=${{ github.sha }} npm run build
+        run: BUILD_BRANCH=$(echo "${GITHUB_REF#refs/heads/}") npm run build
 
       - name: SonarQube Scan (Push)
         if: github.event_name == 'push'

package.json

@@ -91,7 +91,7 @@
     "build-umd:stats": "webpack --progress --env production --json > ./stats/stat_results.json",
     "build-cjs": "rimraf lib && tsc -outDir lib -m CommonJS",
     "postbuild-cjs": "cross-env NODE_ENV=cjs node scripts/copy.packages.json.js && ./scripts/build_cjs_replace_imports.sh",
-    "build-umd": "webpack --config webpack.dev.js --env branch=$BUILD_BRANCH --env commit_hash=$BUILD_COMMIT && webpack --config webpack.prod.js --env branch=$BUILD_BRANCH --env commit_hash=$BUILD_COMMIT && ./scripts/clean_umd_build.sh",
+    "build-umd": "webpack --config webpack.dev.js --env branch=$BUILD_BRANCH && webpack --config webpack.prod.js --env branch=$BUILD_BRANCH && ./scripts/clean_umd_build.sh",
     "build:npm": "rimraf lib es && npm run build-cjs && npm run build-esm",
     "build:ga-to-split-autorequire": "terser ./node_modules/@splitsoftware/splitio-commons/src/integrations/ga/autoRequire.js --mangle --output ./scripts/ga-to-split-autorequire.js && cp ./scripts/ga-to-split-autorequire.js umd/ga-to-split-autorequire.js",
     "build": "rimraf lib umd es && npm run build-cjs && npm run build-esm && npm run build-umd",

types/splitio.d.ts

@@ -158,7 +158,7 @@ interface ILoggerAPI {
  */
 interface IUserConsentAPI {
   /**
-   * Set or update the user consent status. Possible values are `true` and `false`, which represent user consent `'GRANTED'` and `'DECLINED'` respectively.
+   * Sets or updates the user consent status. Possible values are `true` and `false`, which represent user consent `'GRANTED'` and `'DECLINED'` respectively.
    * - `true ('GRANTED')`: the user has granted consent for tracking events and impressions. The SDK will send them to Split cloud.
    * - `false ('DECLINED')`: the user has declined consent for tracking events and impressions. The SDK will not send them to Split cloud.
    *
@@ -170,7 +170,7 @@ interface IUserConsentAPI {
    */
   setStatus(userConsent: boolean): boolean;
   /**
-   * Get the user consent status.
+   * Gets the user consent status.
    *
    * @function getStatus
    * @returns {ConsentStatus} The user consent status.

webpack.dev.js

@@ -7,6 +7,6 @@ const VERSION = pkg.version;
 module.exports = env => merge(common, {
   mode: 'development',
   output: {
-    filename: `[name]${env.branch !== 'master' ? `-dev-${env.commit_hash || VERSION}` : `-${VERSION}`}.js`
+    filename: `[name]${env.branch !== 'master' ? `-dev-${VERSION}` : `-${VERSION}`}.js`
   }
 });

webpack.prod.js

@@ -7,7 +7,7 @@ const VERSION = pkg.version;
 module.exports = env => merge(common, {
   mode: 'production',
   output: {
-    filename: `[name]${env.branch !== 'master' ? `-dev-${env.commit_hash || VERSION}` : `-${VERSION}`}.min.js`
+    filename: `[name]${env.branch !== 'master' ? `-dev-${VERSION}` : `-${VERSION}`}.min.js`
   },
   performance: {
     hints: 'error', // build fails if asset size exceeded