Fixing sonarqube errors

Author: ldecheverz-split

client/src/main/java/io/split/client/jmx/SplitJmxMonitor.java

@@ -24,7 +24,7 @@ public class SplitJmxMonitor implements SplitJmxMonitorMBean {
     private final SegmentSynchronizationTask _segmentSynchronizationTask;
     private SegmentCache _segmentCache;
 
-    public SplitJmxMonitor(SplitClient splitClient, SplitFetcher featureFetcher, SplitCache splitCache, SegmentFetcher segmentFetcher, SegmentSynchronizationTask segmentSynchronizationTask, SegmentCache segmentCache) {
+    public SplitJmxMonitor(SplitClient splitClient, SplitFetcher featureFetcher, SplitCache splitCache, SegmentSynchronizationTask segmentSynchronizationTask, SegmentCache segmentCache) {
         _client = checkNotNull(splitClient);
         _featureFetcher = checkNotNull(featureFetcher);
         _splitCache = checkNotNull(splitCache);

client/src/main/java/io/split/engine/common/SynchronizerImp.java

@@ -1,15 +1,12 @@
 package io.split.engine.common;
 
 import com.google.common.util.concurrent.ThreadFactoryBuilder;
-
 import io.split.cache.SegmentCache;
 import io.split.cache.SplitCache;
 import io.split.engine.experiments.SplitFetcherImp;
 import io.split.engine.experiments.SplitSynchronizationTask;
 import io.split.engine.segments.SegmentFetcher;
-import io.split.engine.segments.SegmentFetcherImp;
 import io.split.engine.segments.SegmentSynchronizationTask;
-import io.split.engine.segments.SegmentSynchronizationTaskImp;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 

client/src/main/java/io/split/engine/segments/SegmentSynchronizationTaskImp.java

@@ -9,6 +9,7 @@
 
 import java.io.Closeable;
 import java.util.List;
+import java.util.Map;
 import java.util.concurrent.ConcurrentMap;
 import java.util.concurrent.ScheduledExecutorService;
 import java.util.concurrent.ScheduledFuture;
@@ -57,7 +58,7 @@ public SegmentSynchronizationTaskImp(SegmentChangeFetcher segmentChangeFetcher,
 
     @Override
     public void run() {
-        for (ConcurrentMap.Entry<String, SegmentFetcherImp> entry : _segmentFetchers.entrySet()) {
+        for (Map.Entry<String, SegmentFetcherImp> entry : _segmentFetchers.entrySet()) {
             SegmentFetcherImp fetcher = entry.getValue();
 
             if (fetcher == null) {

client/src/test/java/io/split/cache/SegmentCacheInMemoryImplTest.java

@@ -1,6 +1,5 @@
 package io.split.cache;
 
-import io.split.cache.SegmentCacheInMemoryImpl;
 import junit.framework.TestCase;
 import org.junit.Test;
 

client/src/test/java/io/split/engine/common/SynchronizerTest.java

@@ -7,7 +7,6 @@
 import io.split.engine.segments.SegmentSynchronizationTask;
 import org.junit.Before;
 import org.junit.Test;
-import org.mockito.Mock;
 import org.mockito.Mockito;
 
 public class SynchronizerTest {
@@ -16,15 +15,14 @@ public class SynchronizerTest {
     private SplitFetcherImp _splitFetcher;
     private SplitCache _splitCache;
     private Synchronizer _synchronizer;
-    private SegmentCache _segmentCache;
 
     @Before
     public void beforeMethod() {
         _refreshableSplitFetcherTask = Mockito.mock(SplitSynchronizationTask.class);
         _segmentFetcher = Mockito.mock(SegmentSynchronizationTask.class);
         _splitFetcher = Mockito.mock(SplitFetcherImp.class);
         _splitCache = Mockito.mock(SplitCache.class);
-        _segmentCache = Mockito.mock(SegmentCache.class);
+        SegmentCache _segmentCache = Mockito.mock(SegmentCache.class);
 
         _synchronizer = new SynchronizerImp(_refreshableSplitFetcherTask, _splitFetcher, _segmentFetcher, _splitCache, _segmentCache);
     }

client/src/test/java/io/split/engine/segments/SegmentSynchronizationTaskImpTest.java

@@ -30,8 +30,8 @@ public class SegmentSynchronizationTaskImpTest {
 
     @Before
     public void beforeMethod() {
-        fetcher1 = new AtomicReference<SegmentFetcher>(null);
-        fetcher2 = new AtomicReference<SegmentFetcher>(null);
+        fetcher1 = new AtomicReference<>(null);
+        fetcher2 = new AtomicReference<>(null);
     }
 
     @Test