Files forgotten

Author: ldecheverz-split

client/src/main/java/io/split/client/SplitFactoryImpl.java

@@ -72,7 +72,6 @@ public class SplitFactoryImpl implements SplitFactory {
     private final URI _eventsRootTarget;
     private final CloseableHttpClient _httpclient;
     private final SDKReadinessGates _gates;
-    private final HttpMetrics _httpMetrics;
     private final SegmentSynchronizationTaskImp _segmentSynchronizationTaskImp;
     private final SplitFetcher _splitFetcher;
     private final SplitSynchronizationTask _splitSynchronizationTask;
@@ -122,9 +121,6 @@ public SplitFactoryImpl(String apiToken, SplitClientConfig config) throws URISyn
         _rootTarget = URI.create(config.endpoint());
         _eventsRootTarget = URI.create(config.eventsEndpoint());
 
-        // HttpMetrics
-        _httpMetrics = HttpMetrics.create(_httpclient, _eventsRootTarget);
-
         // Cache Initialisations
         _segmentCache = new SegmentCacheInMemoryImpl();
         _splitCache = new InMemoryCacheImp();
@@ -147,7 +143,7 @@ public SplitFactoryImpl(String apiToken, SplitClientConfig config) throws URISyn
         _eventClient = EventClientImpl.create(_httpclient, _eventsRootTarget, config.eventsQueueSize(), config.eventFlushIntervalInMillis(), config.waitBeforeShutdown(), _telemetryStorage);
 
         // SyncManager
-        _syncManager = SyncManagerImp.build(config.streamingEnabled(), _splitSynchronizationTask, _splitFetcher, _segmentSynchronizationTaskImp, _splitCache, config.authServiceURL(), _httpclient, config.streamingServiceURL(), config.authRetryBackoffBase(), buildSSEdHttpClient(apiToken, config), _segmentCache, config.streamingRetryDelay(), _gates, _telemetryStorage));
+        _syncManager = SyncManagerImp.build(config.streamingEnabled(), _splitSynchronizationTask, _splitFetcher, _segmentSynchronizationTaskImp, _splitCache, config.authServiceURL(), _httpclient, config.streamingServiceURL(), config.authRetryBackoffBase(), buildSSEdHttpClient(apiToken, config), _segmentCache, config.streamingRetryDelay(), _gates, _telemetryStorage);
         _syncManager.start();
 
         // Evaluator

client/src/test/java/io/split/telemetry/utils/AtomicLongArrayTest.java

@@ -2,35 +2,36 @@
 
 import org.junit.Assert;
 import org.junit.Test;
+import org.mockito.Mockito;
+import org.slf4j.Logger;
 
 public class AtomicLongArrayTest {
 
     private static final int SIZE = 23;
 
     @Test
-    public void testAtomicLong() throws Exception {
+    public void testAtomicLong() {
         AtomicLongArray atomicLongArray = new AtomicLongArray(SIZE);
         Assert.assertNotNull(atomicLongArray);
     }
 
     @Test
     public void testArraySizeError() {
-        Exception exception = Assert.assertThrows(Exception.class, () -> {
-            AtomicLongArray atomicLongArray = new AtomicLongArray(0);
-        });
-        String messageExpected = "Invalid array size";
-        Assert.assertEquals(messageExpected, exception.getMessage());
+        AtomicLongArray atomicLongArray = new AtomicLongArray(0);
+        Logger log = Mockito.mock(Logger.class);
+        atomicLongArray.increment(2);
+        Assert.assertEquals(1, atomicLongArray.fetchAndClearAll().stream().mapToInt(Long::intValue).sum());
     }
 
     @Test
-    public void testIncrement() throws Exception {
+    public void testIncrement() {
         AtomicLongArray atomicLongArray = new AtomicLongArray(SIZE);
         atomicLongArray.increment(2);
         Assert.assertEquals(1, atomicLongArray.fetchAndClearAll().stream().mapToInt(Long::intValue).sum());
     }
 
     @Test(expected = ArrayIndexOutOfBoundsException.class)
-    public void testIncrementError() throws Exception {
+    public void testIncrementError() {
         AtomicLongArray atomicLongArray = new AtomicLongArray(SIZE);
         atomicLongArray.increment(25);
     }