Skip to content

Commit a101e67

Browse files
committed
pr feedback
1 parent b768213 commit a101e67

File tree

4 files changed

+4
-5
lines changed

4 files changed

+4
-5
lines changed

client/src/main/java/io/split/client/SplitClientConfig.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -688,7 +688,7 @@ public SplitClientConfig build() {
688688
_impressionsRefreshRate = (_impressionsRefreshRate <= 0) ? 300 : Math.max(60, _impressionsRefreshRate);
689689
break;
690690
case DEBUG:
691-
_impressionsRefreshRate = (_impressionsRefreshRate <= 0) ? 30 : _impressionsRefreshRate;
691+
_impressionsRefreshRate = (_impressionsRefreshRate <= 0) ? 60 : _impressionsRefreshRate;
692692
break;
693693
}
694694

client/src/main/java/io/split/client/dtos/ImpressionCount.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ public boolean equals(Object o) {
4141
public static class CountPerFeature {
4242

4343
private static final String FIELD_FEATURE = "f";
44-
private static final String FIELD_TIMEFRAME = "t";
44+
private static final String FIELD_TIMEFRAME = "m";
4545
private static final String FIELD_COUNT = "c";
4646

4747
@SerializedName(FIELD_FEATURE)

client/src/main/java/io/split/client/impressions/HttpImpressionsSender.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ public class HttpImpressionsSender implements ImpressionsSender {
2525

2626
private static final String BULK_ENDPOINT_PATH = "api/testImpressions/bulk";
2727
private static final String COUNT_ENDPOINT_PATH = "api/testImpressions/count";
28-
private static final String IMPRESSIONS_MODE_HEADER = "SplitImpressionsMode";
28+
private static final String IMPRESSIONS_MODE_HEADER = "SplitSDKImpressionsMode";
2929

3030
private static final Logger _logger = LoggerFactory.getLogger(HttpImpressionsSender.class);
3131

client/src/test/java/io/split/client/impressions/ImpressionsManagerImplTest.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -270,5 +270,4 @@ public void testImpressionsOptimizedMode() throws URISyntaxException {
270270
treatmentLog.sendImpressionCounters();
271271
verify(senderMock, Mockito.times(0)).postCounters(Mockito.any());
272272
}
273-
274-
}
273+
}

0 commit comments

Comments
 (0)