FIxing PR comments

Author: ldecheverz-split

client/pom.xml

@@ -5,7 +5,7 @@
     <parent>
         <groupId>io.split.client</groupId>
         <artifactId>java-client-parent</artifactId>
-        <version>4.2.0-rc1</version>
+        <version>4.2.0</version>
     </parent>
     <artifactId>java-client</artifactId>
     <packaging>jar</packaging>

client/src/main/java/io/split/client/EventClientImpl.java

@@ -127,6 +127,7 @@ public boolean track(Event event, int eventSize) {
                 _telemetryRuntimeProducer.recordEventStats(EventsDataRecordsEnum.EVENTS_QUEUED, 1);
             }
             else {
+                _log.warn("Event dropped.");
                 _telemetryRuntimeProducer.recordEventStats(EventsDataRecordsEnum.EVENTS_DROPPED, 1);
             }
 

client/src/main/java/io/split/client/impressions/ImpressionsManagerImpl.java

@@ -105,14 +105,13 @@ public void track(Impression impression) {
         }
 
         if (Mode.DEBUG.equals(_mode) || shouldQueueImpression(impression)) {
-            if (!shouldQueueImpression(impression)) {
-                _telemetryRuntimeProducer.recordImpressionStats(ImpressionsDataTypeEnum.IMPRESSIONS_DEDUPED, 1);
-            }
             if (_storage.put(KeyImpression.fromImpression(impression))) {
                 _telemetryRuntimeProducer.recordImpressionStats(ImpressionsDataTypeEnum.IMPRESSIONS_QUEUED, 1);
+            } else {
+                _telemetryRuntimeProducer.recordImpressionStats(ImpressionsDataTypeEnum.IMPRESSIONS_DROPPED, 1);
             }
-            else {
-                _telemetryRuntimeProducer.recordImpressionStats(ImpressionsDataTypeEnum.IMPRESSIONS_DROPPED, 1);            }
+        } else {
+            _telemetryRuntimeProducer.recordImpressionStats(ImpressionsDataTypeEnum.IMPRESSIONS_DEDUPED, 1);
         }
     }
 

pom.xml

@@ -4,7 +4,7 @@
     <modelVersion>4.0.0</modelVersion>
     <groupId>io.split.client</groupId>
     <artifactId>java-client-parent</artifactId>
-    <version>4.2.0-rc1</version>
+    <version>4.2.0</version>
     <dependencyManagement>
         <dependencies>
             <dependency>

testing/pom.xml

@@ -6,7 +6,7 @@
     <parent>
         <groupId>io.split.client</groupId>
         <artifactId>java-client-parent</artifactId>
-        <version>4.2.0-rc1</version>
+        <version>4.2.0</version>
     </parent>
 
     <artifactId>java-client-testing</artifactId>