use treatment as well

Author: mredolatti

client/src/main/java/io/split/client/impressions/ImpressionHasher.java

@@ -5,7 +5,7 @@
 
 public class ImpressionHasher {
 
-    private static final String HASHABLE_FORMAT = "%s:%s:%s:%d";
+    private static final String HASHABLE_FORMAT = "%s:%s:%s:%s:%d";
     private static final String UNKNOWN = "UNKNOWN";
 
     private static String unknownIfNull(String s) {
@@ -23,6 +23,7 @@ public static Long process(KeyImpression impression) {
         return MurmurHash3.hash128x64(String.format(HASHABLE_FORMAT,
                 unknownIfNull(impression.keyName),
                 unknownIfNull(impression.feature),
+                unknownIfNull(impression.treatment),
                 unknownIfNull(impression.label),
                 zeroIfNull(impression.changeNumber)).getBytes())[0];
     }

client/src/test/java/io/split/client/impressions/ImpressionHasherTest.java

@@ -16,6 +16,7 @@ public void works() {
         imp1.keyName = "someKey";
         imp1.changeNumber = 123L;
         imp1.label = "someLabel";
+        imp1.treatment = "someTreatment";
 
         // Different feature
         KeyImpression imp2 = new KeyImpression();
@@ -39,6 +40,11 @@ public void works() {
         imp2.changeNumber = imp1.changeNumber;
         imp2.label = "someOtherLabel";
         assertThat(ImpressionHasher.process(imp1), not(equalTo(ImpressionHasher.process(imp2))));
+
+        // different treatment
+        imp2.label = imp1.label;
+        imp2.treatment = "someOtherTreatment";
+        assertThat(ImpressionHasher.process(imp1), not(equalTo(ImpressionHasher.process(imp2))));
     }
 
     @Test
@@ -59,6 +65,9 @@ public void doesNotCrash() {
         imp1.label = null;
         assertNotNull(ImpressionHasher.process(imp1));
 
+        imp1.treatment = null;
+        assertNotNull(ImpressionHasher.process(imp1));
+        
         assertNull(ImpressionHasher.process(null));
     }
 }