Skip to content

Commit 739ef88

Browse files
committed
fix sonarqube comments
1 parent 3328d7b commit 739ef88

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

client/src/main/java/io/split/engine/sse/client/SSEClient.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,9 @@ public synchronized boolean open(URI uri) {
7070
thread.setDaemon(true);
7171
thread.start();
7272
try {
73-
signal.await(CONNECT_TIMEOUT, TimeUnit.SECONDS);
73+
if (!signal.await(CONNECT_TIMEOUT, TimeUnit.SECONDS)) {
74+
return false;
75+
};
7476
} catch (InterruptedException e) {
7577
Thread.currentThread().interrupt();
7678
_log.warn(e.getMessage());
@@ -151,8 +153,7 @@ private boolean establishConnection(URI uri, CountDownLatch signal) {
151153
_state.set(ConnectionState.OPEN);
152154
_statusCallback.apply(StatusMessage.CONNECTED);
153155
} catch (IOException exc) {
154-
_log.warn(String.format("Error establishConnection: %s", exc.getMessage()));
155-
exc.printStackTrace();
156+
_log.warn(String.format("Error establishConnection: %s", exc));
156157
return false;
157158
} finally {
158159
signal.countDown();

0 commit comments

Comments
 (0)