Skip to content

Commit 495332f

Browse files
sanzmaurosanzmauro
committed
cleaning sonarqube warnings
1 parent 71b3fe5 commit 495332f

File tree

1 file changed

+62
-116
lines changed

1 file changed

+62
-116
lines changed

‎client/src/test/java/io/split/engine/evaluator/EvaluatorTest.java‎

Lines changed: 62 additions & 116 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
import io.split.engine.experiments.SplitFetcher;
1313
import io.split.engine.matchers.CombiningMatcher;
1414
import io.split.engine.metrics.Metrics;
15+
import org.junit.Before;
1516
import org.junit.Test;
1617
import org.mockito.Mockito;
1718

@@ -23,183 +24,128 @@
2324
import static org.junit.Assert.assertEquals;
2425

2526
public class EvaluatorTest {
27+
private SplitFetcher _splitFetcher;
28+
private SDKReadinessGates _gates;
29+
private Evaluator _evaluator;
30+
private SplitClientImpl _splitClient;
31+
private CombiningMatcher _matcher;
32+
private Map<String, String> _configurations;
33+
private List<ParsedCondition> _conditions;
34+
private List<Partition> _partitions;
35+
36+
private String _matchingKey = "test";
37+
private String _bucketingKey = "test";
38+
private String _splitName = "split_name_test";
39+
private Long _changeNumber = 123123L;
40+
41+
@Before
42+
public void before() {
43+
_splitFetcher = Mockito.mock(SplitFetcher.class);
44+
_gates = Mockito.mock(SDKReadinessGates.class);
45+
_evaluator = new EvaluatorImp(_gates, _splitFetcher);
46+
_splitClient = getSplitClient(_splitFetcher, _gates, _evaluator);
47+
_matcher = Mockito.mock(CombiningMatcher.class);
48+
49+
_configurations = new HashMap<>();
50+
_conditions = new ArrayList<>();
51+
_partitions = new ArrayList<>();
52+
}
53+
2654
@Test
2755
public void evaluateWhenSplitNameDoesNotExistReturnControl() throws ChangeNumberExceptionWrapper {
28-
SplitFetcher splitFetcher = Mockito.mock(SplitFetcher.class);
29-
SDKReadinessGates gates = Mockito.mock(SDKReadinessGates.class);
30-
Evaluator evaluator = new EvaluatorImp(gates, splitFetcher);
31-
32-
SplitClientImpl splitClient = getSplitClient(splitFetcher, gates, evaluator);
56+
Mockito.when(_splitFetcher.fetch(_splitName)).thenReturn(null);
3357

34-
String matchingKey = "test";
35-
String bucketingKey = "test";
36-
String split = "split_name_test";
37-
38-
Mockito.when(splitFetcher.fetch(split)).thenReturn(null);
39-
40-
TreatmentLabelAndChangeNumber result = evaluator.evaluateFeature(matchingKey, bucketingKey, split, null, splitClient);
58+
TreatmentLabelAndChangeNumber result = _evaluator.evaluateFeature(_matchingKey, _bucketingKey, _splitName, null, _splitClient);
4159

4260
assertEquals("control", result.treatment);
4361
assertEquals("definition not found", result.label);
4462
}
4563

4664
@Test
4765
public void evaluateWhenSplitIsKilledReturnDefaultTreatment() throws ChangeNumberExceptionWrapper {
48-
SplitFetcher splitFetcher = Mockito.mock(SplitFetcher.class);
49-
SDKReadinessGates gates = Mockito.mock(SDKReadinessGates.class);
50-
Evaluator evaluator = new EvaluatorImp(gates, splitFetcher);
51-
52-
SplitClientImpl splitClient = getSplitClient(splitFetcher, gates, evaluator);
66+
ParsedSplit split = ParsedSplit.createParsedSplitForTests(_splitName, 0, true, "defaultTreatment", _conditions, "tt", _changeNumber, 2);
67+
Mockito.when(_splitFetcher.fetch(_splitName)).thenReturn(split);
5368

54-
String matchingKey = "test";
55-
String bucketingKey = "test";
56-
String splitName = "split_name_test";
57-
Long changeNumber = 123123L;
58-
List<ParsedCondition> conditions = new ArrayList<>();
59-
60-
ParsedSplit split = ParsedSplit.createParsedSplitForTests(splitName, 0, true, "defaultTreatment", conditions, "tt", changeNumber, 2);
61-
62-
Mockito.when(splitFetcher.fetch(splitName)).thenReturn(split);
63-
64-
TreatmentLabelAndChangeNumber result = evaluator.evaluateFeature(matchingKey, bucketingKey, splitName, null, splitClient);
69+
TreatmentLabelAndChangeNumber result = _evaluator.evaluateFeature(_matchingKey, _bucketingKey, _splitName, null, _splitClient);
6570

6671
assertEquals("defaultTreatment", result.treatment);
6772
assertEquals("killed", result.label);
68-
assertEquals(changeNumber, result.changeNumber);
73+
assertEquals(_changeNumber, result.changeNumber);
6974
}
7075

7176
@Test
7277
public void evaluateWithoutConditionsReturnDefaultTreatment() throws ChangeNumberExceptionWrapper {
73-
SplitFetcher splitFetcher = Mockito.mock(SplitFetcher.class);
74-
SDKReadinessGates gates = Mockito.mock(SDKReadinessGates.class);
75-
Evaluator evaluator = new EvaluatorImp(gates, splitFetcher);
76-
77-
SplitClientImpl splitClient = getSplitClient(splitFetcher, gates, evaluator);
78-
79-
String matchingKey = "test";
80-
String bucketingKey = "test";
81-
String splitName = "split_name_test";
82-
Long changeNumber = 123123L;
83-
List<ParsedCondition> conditions = new ArrayList<>();
84-
85-
ParsedSplit split = ParsedSplit.createParsedSplitForTests(splitName, 0, false, "defaultTreatment", conditions, "tt", changeNumber, 2);
78+
ParsedSplit split = ParsedSplit.createParsedSplitForTests(_splitName, 0, false, "defaultTreatment", _conditions, "tt", _changeNumber, 2);
79+
Mockito.when(_splitFetcher.fetch(_splitName)).thenReturn(split);
8680

87-
Mockito.when(splitFetcher.fetch(splitName)).thenReturn(split);
88-
89-
TreatmentLabelAndChangeNumber result = evaluator.evaluateFeature(matchingKey, bucketingKey, splitName, null, splitClient);
81+
TreatmentLabelAndChangeNumber result = _evaluator.evaluateFeature(_matchingKey, _bucketingKey, _splitName, null, _splitClient);
9082

9183
assertEquals("defaultTreatment", result.treatment);
9284
assertEquals("default rule", result.label);
93-
assertEquals(changeNumber, result.changeNumber);
85+
assertEquals(_changeNumber, result.changeNumber);
9486
}
9587

9688
@Test
9789
public void evaluateWithRollOutConditionBucketIsBiggerTrafficAllocationReturnDefaultTreatment() throws ChangeNumberExceptionWrapper {
98-
SplitFetcher splitFetcher = Mockito.mock(SplitFetcher.class);
99-
SDKReadinessGates gates = Mockito.mock(SDKReadinessGates.class);
100-
Evaluator evaluator = new EvaluatorImp(gates, splitFetcher);
101-
102-
SplitClientImpl splitClient = getSplitClient(splitFetcher, gates, evaluator);
103-
104-
String matchingKey = "test";
105-
String bucketingKey = "test";
106-
String splitName = "split_name_test";
107-
Long changeNumber = 123123L;
108-
Map<String, String> configurations = new HashMap<>();
109-
List<ParsedCondition> conditions = new ArrayList<>();
110-
111-
CombiningMatcher matcher = Mockito.mock(CombiningMatcher.class);
112-
113-
List<Partition> partitions = new ArrayList<>();
11490
Partition partition = new Partition();
11591
partition.treatment = "treatment_test";
11692
partition.size = 100;
117-
partitions.add(partition);
118-
ParsedCondition condition = new ParsedCondition(ConditionType.ROLLOUT, matcher, partitions, "test label");
119-
conditions.add(condition);
93+
_partitions.add(partition);
94+
ParsedCondition condition = new ParsedCondition(ConditionType.ROLLOUT, _matcher,_partitions, "test label");
95+
_conditions.add(condition);
12096

121-
ParsedSplit split = new ParsedSplit(splitName, 0, false, "default_treatment", conditions, "tt", changeNumber, 10, 12, 2, configurations);
97+
ParsedSplit split = new ParsedSplit(_splitName, 0, false, "default_treatment", _conditions, "tt", _changeNumber, 10, 12, 2, _configurations);
12298

123-
Mockito.when(splitFetcher.fetch(splitName)).thenReturn(split);
124-
Mockito.when(condition.matcher().match(matchingKey, bucketingKey, null, splitClient)).thenReturn(true);
99+
Mockito.when(_splitFetcher.fetch(_splitName)).thenReturn(split);
100+
Mockito.when(condition.matcher().match(_matchingKey, _bucketingKey, null, _splitClient)).thenReturn(true);
125101

126-
TreatmentLabelAndChangeNumber result = evaluator.evaluateFeature(matchingKey, bucketingKey, splitName, null, splitClient);
102+
TreatmentLabelAndChangeNumber result = _evaluator.evaluateFeature(_matchingKey, _bucketingKey, _splitName, null, _splitClient);
127103

128104
assertEquals("default_treatment", result.treatment);
129105
assertEquals("not in split", result.label);
130-
assertEquals(changeNumber, result.changeNumber);
106+
assertEquals(_changeNumber, result.changeNumber);
131107
}
132108

133109
@Test
134110
public void evaluateWithRollOutConditionTrafficAllocationIsBiggerBucketReturnTreatment() throws ChangeNumberExceptionWrapper {
135-
SplitFetcher splitFetcher = Mockito.mock(SplitFetcher.class);
136-
SDKReadinessGates gates = Mockito.mock(SDKReadinessGates.class);
137-
Evaluator evaluator = new EvaluatorImp(gates, splitFetcher);
138-
CombiningMatcher matcher = Mockito.mock(CombiningMatcher.class);
139-
140-
SplitClientImpl splitClient = getSplitClient(splitFetcher, gates, evaluator);
141-
142-
String matchingKey = "test";
143-
String bucketingKey = "test";
144-
String splitName = "split_name_test";
145-
Long changeNumber = 123123L;
146-
Map<String, String> configurations = new HashMap<>();
147-
List<ParsedCondition> conditions = new ArrayList<>();
148-
List<Partition> partitions = new ArrayList<>();
149-
150111
Partition partition = new Partition();
151112
partition.treatment = "treatment_test";
152113
partition.size = 100;
153-
partitions.add(partition);
154-
ParsedCondition condition = new ParsedCondition(ConditionType.ROLLOUT, matcher, partitions, "test label");
155-
conditions.add(condition);
114+
_partitions.add(partition);
115+
ParsedCondition condition = new ParsedCondition(ConditionType.ROLLOUT, _matcher, _partitions, "test label");
116+
_conditions.add(condition);
156117

157-
ParsedSplit split = new ParsedSplit(splitName, 0, false, "default_treatment", conditions, "tt", changeNumber, 60, 18, 2, configurations);
118+
ParsedSplit split = new ParsedSplit(_splitName, 0, false, "default_treatment", _conditions, "tt", _changeNumber, 60, 18, 2, _configurations);
158119

159-
Mockito.when(splitFetcher.fetch(splitName)).thenReturn(split);
160-
Mockito.when(condition.matcher().match(matchingKey, bucketingKey, null, splitClient)).thenReturn(true);
120+
Mockito.when(_splitFetcher.fetch(_splitName)).thenReturn(split);
121+
Mockito.when(condition.matcher().match(_matchingKey, _bucketingKey, null, _splitClient)).thenReturn(true);
161122

162-
TreatmentLabelAndChangeNumber result = evaluator.evaluateFeature(matchingKey, bucketingKey, splitName, null, splitClient);
123+
TreatmentLabelAndChangeNumber result = _evaluator.evaluateFeature(_matchingKey, _bucketingKey, _splitName, null, _splitClient);
163124

164125
assertEquals("treatment_test", result.treatment);
165126
assertEquals("test label", result.label);
166-
assertEquals(changeNumber, result.changeNumber);
127+
assertEquals(_changeNumber, result.changeNumber);
167128
}
168129

169130
@Test
170131
public void evaluateWithWhitelistConditionReturnTreatment() throws ChangeNumberExceptionWrapper {
171-
SplitFetcher splitFetcher = Mockito.mock(SplitFetcher.class);
172-
SDKReadinessGates gates = Mockito.mock(SDKReadinessGates.class);
173-
Evaluator evaluator = new EvaluatorImp(gates, splitFetcher);
174-
CombiningMatcher matcher = Mockito.mock(CombiningMatcher.class);
175-
176-
SplitClientImpl splitClient = getSplitClient(splitFetcher, gates, evaluator);
177-
178-
String matchingKey = "test";
179-
String bucketingKey = "test";
180-
String splitName = "split_name_test";
181-
Long changeNumber = 123123L;
182-
Map<String, String> configurations = new HashMap<>();
183-
List<ParsedCondition> conditions = new ArrayList<>();
184-
List<Partition> partitions = new ArrayList<>();
185-
186132
Partition partition = new Partition();
187133
partition.treatment = "treatment_test";
188134
partition.size = 100;
189-
partitions.add(partition);
190-
ParsedCondition condition = new ParsedCondition(ConditionType.WHITELIST, matcher, partitions, "test whitelist label");
191-
conditions.add(condition);
135+
_partitions.add(partition);
136+
ParsedCondition condition = new ParsedCondition(ConditionType.WHITELIST, _matcher, _partitions, "test whitelist label");
137+
_conditions.add(condition);
192138

193-
ParsedSplit split = new ParsedSplit(splitName, 0, false, "default_treatment", conditions, "tt", changeNumber, 60, 18, 2, configurations);
139+
ParsedSplit split = new ParsedSplit(_splitName, 0, false, "default_treatment", _conditions, "tt", _changeNumber, 60, 18, 2, _configurations);
194140

195-
Mockito.when(splitFetcher.fetch(splitName)).thenReturn(split);
196-
Mockito.when(condition.matcher().match(matchingKey, bucketingKey, null, splitClient)).thenReturn(true);
141+
Mockito.when(_splitFetcher.fetch(_splitName)).thenReturn(split);
142+
Mockito.when(condition.matcher().match(_matchingKey, _bucketingKey, null, _splitClient)).thenReturn(true);
197143

198-
TreatmentLabelAndChangeNumber result = evaluator.evaluateFeature(matchingKey, bucketingKey, splitName, null, splitClient);
144+
TreatmentLabelAndChangeNumber result = _evaluator.evaluateFeature(_matchingKey, _bucketingKey, _splitName, null, _splitClient);
199145

200146
assertEquals("treatment_test", result.treatment);
201147
assertEquals("test whitelist label", result.label);
202-
assertEquals(changeNumber, result.changeNumber);
148+
assertEquals(_changeNumber, result.changeNumber);
203149
}
204150

205151
private SplitClientImpl getSplitClient(SplitFetcher splitFetcher, SDKReadinessGates gates, Evaluator evaluator) {

0 commit comments

Comments
 (0)