pr feedback

sanzmauro · sanzmauro · commit 1c45e7776103 · 2020-12-11T11:59:59.000-03:00
diff --git a/client/src/main/java/io/split/client/SplitFactoryImpl.java b/client/src/main/java/io/split/client/SplitFactoryImpl.java
@@ -202,7 +202,7 @@ public SplitFactoryImpl(String apiToken, SplitClientConfig config) throws URISyn
         // Feature Changes
         SplitChangeFetcher splitChangeFetcher = HttpSplitChangeFetcher.create(httpclient, rootTarget, uncachedFireAndForget);
 
-        final SplitCache cache = new InMemoryCacheImp(-1);
+        final SplitCache cache = new InMemoryCacheImp();
         final RefreshableSplitFetcherProvider splitFetcherProvider = new RefreshableSplitFetcherProvider(splitChangeFetcher, splitParser, findPollingPeriod(RANDOM, config.featuresRefreshRate()), gates, cache);
 
 
diff --git a/client/src/main/java/io/split/engine/experiments/RefreshableSplitFetcher.java b/client/src/main/java/io/split/engine/experiments/RefreshableSplitFetcher.java
@@ -137,7 +137,7 @@ public void run() {
         }
     }
 
-    public void runWithoutExceptionHandling() throws InterruptedException {
+    private void runWithoutExceptionHandling() throws InterruptedException {
         SplitChange change = _splitChangeFetcher.fetch(_splitCache.getChangeNumber());
 
         if (change == null) {

Original file line number	Diff line number	Diff line change
`@@ -137,7 +137,7 @@ public void run() {`
`137`	`137`	`}`
`138`	`138`	`}`
`139`	`139`
`140`		`- public void runWithoutExceptionHandling() throws InterruptedException {`
	`140`	`+ private void runWithoutExceptionHandling() throws InterruptedException {`
`141`	`141`	`SplitChange change = _splitChangeFetcher.fetch(_splitCache.getChangeNumber());`
`142`	`142`
`143`	`143`	`if (change == null) {`