feedback

Author: sanzmauro

client/src/main/java/io/split/engine/segments/SegmentSynchronizationTaskImp.java

@@ -10,7 +10,12 @@
 import java.io.Closeable;
 import java.util.List;
 import java.util.Map;
-import java.util.concurrent.*;
+import java.util.concurrent.ConcurrentMap;
+import java.util.concurrent.Executors;
+import java.util.concurrent.ScheduledExecutorService;
+import java.util.concurrent.ScheduledFuture;
+import java.util.concurrent.ThreadFactory;
+import java.util.concurrent.TimeUnit;
 import java.util.concurrent.atomic.AtomicBoolean;
 import java.util.concurrent.atomic.AtomicLong;
 import java.util.stream.Collectors;
@@ -54,7 +59,6 @@ public SegmentSynchronizationTaskImp(SegmentChangeFetcher segmentChangeFetcher,
 
     @Override
     public void run() {
-        _log.debug("Starting PeriodicFetching Segments ...");
         this.fetchAll(false);
     }
 
@@ -104,6 +108,7 @@ public void startPeriodicFetching() {
             return;
         }
 
+        _log.debug("Starting PeriodicFetching Segments ...");
         _scheduledFuture = _scheduledExecutorService.scheduleWithFixedDelay(this, 0L, _refreshEveryNSeconds.get(), TimeUnit.SECONDS);
     }
 

client/src/test/java/io/split/engine/experiments/SplitFetcherTest.java

@@ -54,7 +54,6 @@ public void works_when_we_start_with_any_state() throws InterruptedException {
     private void works(long startingChangeNumber) throws InterruptedException {
         AChangePerCallSplitChangeFetcher splitChangeFetcher = new AChangePerCallSplitChangeFetcher();
         SDKReadinessGates gates = new SDKReadinessGates();
-        gates.sdkInternalReady();
         SegmentCache segmentCache = new SegmentCacheInMemoryImpl();
         SegmentChangeFetcher segmentChangeFetcher = Mockito.mock(SegmentChangeFetcher.class);
         SegmentSynchronizationTask segmentSynchronizationTask = new SegmentSynchronizationTaskImp(segmentChangeFetcher,1,10, gates, segmentCache);
@@ -86,7 +85,6 @@ private void works(long startingChangeNumber) throws InterruptedException {
     @Test
     public void when_parser_fails_we_remove_the_experiment() throws InterruptedException {
         SDKReadinessGates gates = new SDKReadinessGates();
-        gates.sdkInternalReady();
         Split validSplit = new Split();
         validSplit.status = Status.ACTIVE;
         validSplit.seed = (int) -1;
@@ -147,7 +145,6 @@ public void when_parser_fails_we_remove_the_experiment() throws InterruptedExcep
     @Test
     public void if_there_is_a_problem_talking_to_split_change_count_down_latch_is_not_decremented() throws Exception {
         SDKReadinessGates gates = new SDKReadinessGates();
-        gates.sdkInternalReady();
         SplitCache cache = new InMemoryCacheImp(-1);
 
         SplitChangeFetcher splitChangeFetcher = mock(SplitChangeFetcher.class);
@@ -191,7 +188,6 @@ public void works_with_user_defined_segments() throws Exception {
         String segmentName = "foosegment";
         AChangePerCallSplitChangeFetcher experimentChangeFetcher = new AChangePerCallSplitChangeFetcher(segmentName);
         SDKReadinessGates gates = new SDKReadinessGates();
-        gates.sdkInternalReady();
         SplitCache cache = new InMemoryCacheImp(startingChangeNumber);
         SegmentCache segmentCache = new SegmentCacheInMemoryImpl();