From 0ce5a4e0de755d8630344c947049cef98944ec8e Mon Sep 17 00:00:00 2001 From: Mauro Antonio Sanz Date: Fri, 12 May 2023 17:28:04 -0300 Subject: [PATCH] disco week --- app/services/splitio.js | 6 +++--- app/view1/view1.js | 6 +++--- app/view1/view1_test.js | 6 +++--- app/view2/view2.js | 6 +++--- app/view2/view2_test.js | 6 +++--- 5 files changed, 15 insertions(+), 15 deletions(-) diff --git a/app/services/splitio.js b/app/services/splitio.js index 73e0ebe..69b14ec 100644 --- a/app/services/splitio.js +++ b/app/services/splitio.js @@ -12,9 +12,9 @@ splitService.factory('splitio', function() { }, // In non-localhost mode, this map is ignored. features: { - feature_1: 'off', - feature_2: 'on', - feature_3: 'v2' + feature_flag_1: 'off', + feature_flag_2: 'on', + feature_flag_3: 'v2' } }); diff --git a/app/view1/view1.js b/app/view1/view1.js index 3ff0132..8f312da 100644 --- a/app/view1/view1.js +++ b/app/view1/view1.js @@ -10,7 +10,7 @@ angular.module('myApp.view1', ['ngRoute', 'splitModule']) }]) .controller('View1Ctrl', ['$scope', 'splitio', function($scope, splitio) { - $scope.feature_1 = splitio.getTreatment('feature_1'); - $scope.feature_2 = splitio.getTreatment('feature_2'); - $scope.feature_3 = splitio.getTreatment('feature_3'); + $scope.feature_flag_1 = splitio.getTreatment('feature_flag_1'); + $scope.feature_flag_2 = splitio.getTreatment('feature_flag_2'); + $scope.feature_flag_3 = splitio.getTreatment('feature_flag_3'); }]); diff --git a/app/view1/view1_test.js b/app/view1/view1_test.js index 3bf99aa..688505d 100644 --- a/app/view1/view1_test.js +++ b/app/view1/view1_test.js @@ -15,9 +15,9 @@ describe('myApp.view1 module', function() { it('Scneario where splitio sdk use off-the-grid mode', inject(function($controller) { var $scope = {}; var view1Ctrl = $controller('View1Ctrl', { $scope }); - expect($scope.feature_1).toEqual('off'); - expect($scope.feature_2).toEqual('on'); - expect($scope.feature_3).toEqual('v2'); + expect($scope.feature_flag_1).toEqual('off'); + expect($scope.feature_flag_2).toEqual('on'); + expect($scope.feature_flag_3).toEqual('v2'); })); }); diff --git a/app/view2/view2.js b/app/view2/view2.js index e9176f3..54fa4fd 100644 --- a/app/view2/view2.js +++ b/app/view2/view2.js @@ -10,7 +10,7 @@ angular.module('myApp.view2', ['ngRoute', 'splitModule']) }]) .controller('View2Ctrl', ['$scope', 'splitio', function($scope, splitio) { - $scope.feature_1 = splitio.getTreatment('feature_1'); - $scope.feature_2 = splitio.getTreatment('feature_2'); - $scope.feature_3 = splitio.getTreatment('feature_3'); + $scope.feature_flag_1 = splitio.getTreatment('feature_flag_1'); + $scope.feature_flag_2 = splitio.getTreatment('feature_flag_2'); + $scope.feature_flag_3 = splitio.getTreatment('feature_flag_3'); }]); diff --git a/app/view2/view2_test.js b/app/view2/view2_test.js index 531cbf8..6c6ccce 100644 --- a/app/view2/view2_test.js +++ b/app/view2/view2_test.js @@ -32,9 +32,9 @@ describe('View 2 Module', function() { var $scope = {}; // $controller calls getTreatment internally var view1Ctrl = $controller('View2Ctrl', { $scope }); - expect($scope.feature_1).toEqual('off'); - expect($scope.feature_2).toEqual('off'); - expect($scope.feature_3).toEqual('off'); + expect($scope.feature_flag_1).toEqual('off'); + expect($scope.feature_flag_2).toEqual('off'); + expect($scope.feature_flag_3).toEqual('off'); })); });