Skip to content

Commit 40be93f

Browse files
committed
Rebase fixup
Signed-off-by: Caleb Schoepp <caleb.schoepp@fermyon.com>
1 parent 413a512 commit 40be93f

File tree

5 files changed

+161
-34
lines changed

5 files changed

+161
-34
lines changed

crates/factor-otel/src/host.rs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ use anyhow::Result;
55
use opentelemetry::trace::TraceContextExt;
66
use opentelemetry::Context;
77
use opentelemetry_sdk::trace::SpanProcessor;
8-
use spin_core::async_trait;
98
use spin_world::wasi::otel::tracing as wasi_otel;
109
use spin_world::wasi::otel::tracing::SpanContext;
1110
use tracing::span;
@@ -14,7 +13,6 @@ use tracing_opentelemetry::OpenTelemetrySpanExt;
1413

1514
use crate::InstanceState;
1615

17-
#[async_trait]
1816
impl wasi_otel::Host for InstanceState {
1917
async fn on_start(
2018
&mut self,
@@ -115,5 +113,3 @@ impl wasi_otel::Host for InstanceState {
115113
.into())
116114
}
117115
}
118-
119-
// TODO: Rename module to otel

crates/world/src/conversions.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -609,7 +609,7 @@ mod otel {
609609
match value {
610610
wasi_otel::Value::String(v) => v.into(),
611611
wasi_otel::Value::Bool(v) => v.into(),
612-
wasi_otel::Value::Float64(v) => v.into(),
612+
wasi_otel::Value::F64(v) => v.into(),
613613
wasi_otel::Value::S64(v) => v.into(),
614614
wasi_otel::Value::StringArray(v) => opentelemetry::Value::Array(
615615
v.into_iter()
@@ -618,7 +618,7 @@ mod otel {
618618
.into(),
619619
),
620620
wasi_otel::Value::BoolArray(v) => opentelemetry::Value::Array(v.into()),
621-
wasi_otel::Value::Float64Array(v) => opentelemetry::Value::Array(v.into()),
621+
wasi_otel::Value::F64Array(v) => opentelemetry::Value::Array(v.into()),
622622
wasi_otel::Value::S64Array(v) => opentelemetry::Value::Array(v.into()),
623623
}
624624
}

tests/test-components/components/Cargo.lock

Lines changed: 156 additions & 25 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

tests/test-components/components/wasi-otel-tracing/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,6 @@ anyhow = "1"
1111
http = "0.2"
1212
opentelemetry = "0.27.0"
1313
opentelemetry_sdk = "0.27.0"
14-
opentelemetry-wasi = { git = "https://github.com/calebschoepp/opentelemetry-wasi", rev = "bf4a6bf93b93bec48835360cc4d2f4155858a697" }
14+
opentelemetry-wasi = { git = "https://github.com/calebschoepp/opentelemetry-wasi", rev = "78d0cf0d1e2674591ab0dfdca8443a81a1e402bd" }
1515
spin-sdk = "3.1.0"
1616
wit-bindgen = "0.30.0"

wit/deps/otel/tracing.wit

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -108,15 +108,15 @@ interface tracing {
108108
/// A boolean value.
109109
%bool(bool),
110110
/// A double precision floating point value.
111-
%float64(float64),
111+
%f64(f64),
112112
/// A signed 64 bit integer value.
113113
%s64(s64),
114114
/// A homogeneous array of string values.
115115
string-array(list<string>),
116116
/// A homogeneous array of boolean values.
117117
bool-array(list<bool>),
118118
/// A homogeneous array of double precision floating point values.
119-
float64-array(list<float64>),
119+
f64-array(list<f64>),
120120
/// A homogeneous array of 64 bit integer values.
121121
s64-array(list<s64>),
122122
}

0 commit comments

Comments
 (0)