refactor AbstractTransaction

Author: vananiev

src/main/java/org/spacious_team/broker/report_parser/api/AbstractTransaction.java

@@ -76,7 +76,7 @@ public List<TransactionCashFlow> getTransactionCashFlows() {
     }
 
     protected Optional<TransactionCashFlow> getValueCashFlow(CashFlowType type) {
-        if (value != null && valueCurrency != null && Math.abs(value.floatValue()) >= 0.0001) {
+        if (value != null && valueCurrency != null && isNotZero(value)) {
         return Optional.of(TransactionCashFlow.builder()
                 .transactionId(id)
                 .eventType(type)
@@ -88,7 +88,7 @@ protected Optional<TransactionCashFlow> getValueCashFlow(CashFlowType type) {
     }
 
     protected Optional<TransactionCashFlow> getFeeCashFlow() {
-        if (fee != null && feeCurrency != null && Math.abs(fee.floatValue()) >= 0.0001) {
+        if (fee != null && feeCurrency != null && isNotZero(fee)) {
             return Optional.of(TransactionCashFlow.builder()
                     .transactionId(id)
                     .eventType(FEE)
@@ -99,6 +99,10 @@ protected Optional<TransactionCashFlow> getFeeCashFlow() {
         return Optional.empty();
     }
 
+    protected boolean isNotZero(BigDecimal value) {
+        return Math.abs(value.floatValue()) >= 0.0001;
+    }
+
     @EqualsAndHashCode.Include
     @SuppressWarnings("unused")
     private  @Nullable BigDecimal getValueForEquals() {

src/main/java/org/spacious_team/broker/report_parser/api/SecurityTransaction.java

@@ -52,7 +52,7 @@ public List<TransactionCashFlow> getTransactionCashFlows() {
 
     private Optional<TransactionCashFlow> getAccruedInterestCashFlow() {
         // for securities accrued interest = 0
-        if (accruedInterest != null && valueCurrency != null && Math.abs(accruedInterest.floatValue()) >= 0.0001) {
+        if (accruedInterest != null && valueCurrency != null && isNotZero(accruedInterest)) {
             return Optional.of(TransactionCashFlow.builder()
                     .transactionId(id)
                     .eventType(CashFlowType.ACCRUED_INTEREST)