Merge pull request #24 from spacious-team/improvement-lazy-wrapping-report-table

Отложенная инициализация WrappingReportTable

Author: vananiev

src/main/java/org/spacious_team/broker/report_parser/api/WrappingReportTable.java

@@ -18,66 +18,81 @@
 
 package org.spacious_team.broker.report_parser.api;
 
+import lombok.AccessLevel;
 import lombok.Getter;
+import lombok.RequiredArgsConstructor;
 
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.Collection;
 import java.util.Collections;
 import java.util.List;
 
+@RequiredArgsConstructor(access = AccessLevel.PRIVATE)
 public class WrappingReportTable<RowType> implements ReportTable<RowType> {
-    @Getter
-    private final BrokerReport report;
-    private final List<RowType> data;
+    private final ReportTable<RowType> reportTable;
+
+    @SafeVarargs
+    public static <T> WrappingReportTable<T> of(BrokerReport report, Collection<T>... dataset) {
+        return new WrappingReportTable<>(new EagerWrappingReportTable<>(report, dataset));
+    }
 
     @SafeVarargs
     public static <T> WrappingReportTable<T> of(ReportTable<T>... tables) {
         assertIsTrue(tables.length > 0, "Can't wrap, report tables not provided");
         BrokerReport report = tables[0].getReport();
         boolean isAllReportsIsSame = Arrays.stream(tables)
                 .map(ReportTable::getReport)
-                .filter(tableReport -> tableReport != report)
-                .findAny()
-                .isEmpty();
+                .allMatch(tableReport -> tableReport == report);
         assertIsTrue(isAllReportsIsSame, "Wrapping report tables should be built for same broker report");
-        return new WrappingReportTable<>(report, tables);
-
+        return new WrappingReportTable<>(new LazyWrappingReportTable<>(report, tables));
     }
 
-    @SafeVarargs
-    public WrappingReportTable(BrokerReport report, ReportTable<RowType>... tables) {
-        List<RowType> data = new ArrayList<>();
-        for (ReportTable<RowType> table : tables) {
-            data.addAll(table.getData());
+    private static void assertIsTrue(boolean expression, String message) {
+        if (!expression) {
+            throw new IllegalArgumentException(message);
         }
-        this.report = report;
-        this.data = data;
     }
 
-    @SafeVarargs
-    public static <T> WrappingReportTable<T> of(BrokerReport report, Collection<T>... dataset) {
-        return new WrappingReportTable<>(report, dataset);
+    @Override
+    public BrokerReport getReport() {
+        return reportTable.getReport();
     }
 
-    @SafeVarargs
-    public WrappingReportTable(BrokerReport report, Collection<RowType>... dataset) {
-        List<RowType> data = new ArrayList<>();
-        for (Collection<RowType> d : dataset) {
-            data.addAll(d);
-        }
-        this.report = report;
-        this.data = data;
+    @Override
+    public List<RowType> getData() {
+        return reportTable.getData();
     }
 
-    private static void assertIsTrue(boolean expression, String message) {
-        if (!expression) {
-            throw new IllegalArgumentException(message);
+    @Getter
+    private static class EagerWrappingReportTable<RowType> implements ReportTable<RowType> {
+        private final BrokerReport report;
+        private final List<RowType> data;
+
+        @SafeVarargs
+        public EagerWrappingReportTable(BrokerReport report, Collection<RowType>... dataset) {
+            List<RowType> data = new ArrayList<>();
+            for (Collection<RowType> d : dataset) {
+                data.addAll(d);
+            }
+            this.report = report;
+            this.data = Collections.unmodifiableList(data);
         }
     }
 
-    @Override
-    public List<RowType> getData() {
-        return Collections.unmodifiableList(data);
+    @RequiredArgsConstructor
+    private static class LazyWrappingReportTable<RowType> implements ReportTable<RowType> {
+        @Getter
+        private final BrokerReport report;
+        private final ReportTable<RowType>[] tables;
+
+        @Override
+        public List<RowType> getData() {
+            List<RowType> data = new ArrayList<>();
+            for (ReportTable<RowType> table : tables) {
+                data.addAll(table.getData());
+            }
+            return Collections.unmodifiableList(data);
+        }
     }
 }