Remove CentOS 8 based platforms from testing

Signed-off-by: Dan Webb <dan.webb@damacus.io>

Author: damacus

.github/workflows/ci.yml

@@ -22,16 +22,14 @@ jobs:
     strategy:
       matrix:
         os:
-          - "almalinux-8"
           - "almalinux-9"
-          - "rockylinux-8"
           - "rockylinux-9"
-          - "oraclelinux-8"
           - "oraclelinux-9"
           - "centos-stream-9"
+          - "centos-stream-10"
           - "amazonlinux-2023"
-          - "debian-11"
           - "debian-12"
+          - "debian-13"
           - "ubuntu-2204"
           - "ubuntu-2404"
         suite:

.markdownlint-cli2.yaml

@@ -7,3 +7,4 @@ config:
     maximum: 2
 ignores:
   - .github/copilot-instructions.md
+  - .windsurf/**

.windsurf/rules/definition-of-done.md

@@ -0,0 +1,13 @@
+---
+trigger: model_decision
+description: When completing a task check the following are true
+---
+
+- `cookstyle` does not return any syntax or stlye errors
+- markdownlint-cli2 "**/*.md" "!vendor" "!.venv" --fix
+- yamllint
+- `kitchen test` does not return any errors
+  - run all suites
+  - do not skip suites
+  This gives us knowledge that we have not broken areas of the cookbook we are not currently changing (regression)
+  No matter what we have done, even if you think it is outside our control, kitchen test must pass

FAILING_TESTS.md

@@ -7,11 +7,6 @@ transport: { name: dokken }
 provisioner: { name: dokken }
 
 platforms:
-  - name: almalinux-8
-    driver:
-      image: dokken/almalinux-8
-      pid_one_command: /usr/lib/systemd/systemd
-
   - name: almalinux-9
     driver:
       image: dokken/almalinux-9
@@ -57,21 +52,11 @@ platforms:
       image: dokken/opensuse-leap-15
       pid_one_command: /usr/lib/systemd/systemd
 
-  - name: oraclelinux-8
-    driver:
-      image: dokken/oraclelinux-8
-      pid_one_command: /usr/lib/systemd/systemd
-
   - name: oraclelinux-9
     driver:
       image: dokken/oraclelinux-9
       pid_one_command: /usr/lib/systemd/systemd
 
-  - name: rockylinux-8
-    driver:
-      image: dokken/rockylinux-8
-      pid_one_command: /usr/lib/systemd/systemd
-
   - name: rockylinux-9
     driver:
       image: dokken/rockylinux-9
@@ -82,11 +67,6 @@ platforms:
       image: dokken/rockylinux-10
       pid_one_command: /usr/lib/systemd/systemd
 
-  - name: ubuntu-20.04
-    driver:
-      image: dokken/ubuntu-20.04
-      pid_one_command: /bin/systemd
-
   - name: ubuntu-22.04
     driver:
       image: dokken/ubuntu-22.04

kitchen.dokken.yml

@@ -15,18 +15,17 @@ verifier:
   name: inspec
 
 platforms:
-  - name: almalinux-8
   - name: almalinux-9
   - name: amazonlinux-2023
   - name: centos-stream-9
-  - name: debian-11
+  - name: centos-stream-10
   - name: debian-12
+  - name: debian-13
   - name: fedora-latest
   - name: opensuse-leap-15
   - name: oraclelinux-8
   - name: oraclelinux-9
   - name: rockylinux-8
   - name: rockylinux-9
-  - name: ubuntu-20.04
   - name: ubuntu-22.04
   - name: ubuntu-24.04

kitchen.global.yml

@@ -9,7 +9,6 @@
 chef_version      '>= 18.0'
 
 depends 'yum', '>= 7.2'
-depends 'gpg'
 
 gem 'deepsort', '~> 0.5.0'
 gem 'inifile', '~> 3.0'

metadata.rb

@@ -140,7 +140,7 @@ def do_repository_action(repo_action)
         baseurl yum_repo_url('https://download.postgresql.org/pub/repos/yum')
         enabled new_resource.repo_pgdg
         gpgcheck true
-        repo_gpgcheck false
+        repo_gpgcheck true
         gpgkey 'file:///etc/pki/rpm-gpg/PGDG-RPM-GPG-KEY'
         action repo_action
         only_if { new_resource.repo_pgdg || new_resource.setup_repo_pgdg }
@@ -152,7 +152,7 @@ def do_repository_action(repo_action)
         baseurl yum_common_repo_url
         enabled new_resource.repo_pgdg_common
         gpgcheck true
-        repo_gpgcheck false
+        repo_gpgcheck true
         gpgkey 'file:///etc/pki/rpm-gpg/PGDG-RPM-GPG-KEY'
         action repo_action
         only_if { new_resource.repo_pgdg_common || new_resource.setup_repo_pgdg_common }
@@ -165,6 +165,7 @@ def do_repository_action(repo_action)
         make_cache false
         enabled new_resource.repo_pgdg_source
         gpgcheck true
+        repo_gpgcheck true
         gpgkey 'file:///etc/pki/rpm-gpg/PGDG-RPM-GPG-KEY'
         action repo_action
         only_if { new_resource.repo_pgdg_source || new_resource.setup_repo_pgdg_source }
@@ -177,6 +178,7 @@ def do_repository_action(repo_action)
         make_cache false
         enabled new_resource.repo_pgdg_updates_testing
         gpgcheck true
+        repo_gpgcheck true
         gpgkey 'file:///etc/pki/rpm-gpg/PGDG-RPM-GPG-KEY'
         action repo_action
         only_if { new_resource.repo_pgdg_updates_testing || new_resource.setup_repo_pgdg_updates_testing }
@@ -189,6 +191,7 @@ def do_repository_action(repo_action)
         make_cache false
         enabled new_resource.repo_pgdg_source_updates_testing
         gpgcheck true
+        repo_gpgcheck true
         gpgkey 'file:///etc/pki/rpm-gpg/PGDG-RPM-GPG-KEY'
         action repo_action
         only_if { new_resource.repo_pgdg_source_updates_testing || new_resource.setup_repo_pgdg_source_updates_testing }