Commit e215bde
authored
Comment out runAsUser and runAsGroup in values.yaml (#618)
Since [PR 2456](sourcegraph/sourcegraph#2456) in
the Sourcegraph repo, support for the default value of -1 for the
`KUBERNETES_RUN_AS_USER` and `KUBERNETES_RUN_AS_GROUP` Executor
environment variables has been removed - those environment variables now
require either blank values or non-negative integers in the range [0,
2147483647], to match the range for Unix UIDs and GIDs.
This PR updates `charts/sourcegraph-executor/k8s/values.yaml` so that
`runAsUser` and `runAsGroup` are commented out, with comments to explain
that the user can uncomment them to use them. Having those settings
commented out causes `KUBERNETES_RUN_AS_USER` and
`KUBERNETES_RUN_AS_GROUP` in
`charts/sourcegraph-executor/k8s/templates/executor.ConfigMap.yaml` to
be blank, which is the new default value.
### Checklist
- [ ] Follow the [manual testing
process](https://github.com/sourcegraph/deploy-sourcegraph-helm/blob/main/TEST.md)
- [ ] Update
[changelog](https://github.com/sourcegraph/deploy-sourcegraph-helm/blob/main/charts/sourcegraph/CHANGELOG.md)
- [ ] Update [Kubernetes update
doc](https://docs.sourcegraph.com/admin/updates/kubernetes)
### Test plan
A Helm deployment is successful and does not fail with errors like
`KUBERNETES_RUN_AS_USER must be a UID in the range 0 to 2,147,483,647,
but got "-1".`1 parent d1b1a39 commit e215bde
2 files changed
+8
-6
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
77 | 77 | | |
78 | 78 | | |
79 | 79 | | |
80 | | - | |
81 | | - | |
| 80 | + | |
| 81 | + | |
82 | 82 | | |
83 | 83 | | |
84 | 84 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
94 | 94 | | |
95 | 95 | | |
96 | 96 | | |
97 | | - | |
98 | | - | |
99 | | - | |
100 | | - | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
101 | 103 | | |
102 | 104 | | |
103 | 105 | | |
| |||
0 commit comments