Commit 4031ec0
fix: restore missing batch/jobs permissions and add PVC permissions to executor role (#553)
## Problem
Customer reported that batch changes are failing with the error:
```
running command "step.kubernetes.step.0.pre": persistentvolumeclaims is
forbidden: User "system:serviceaccount:sourcegraph-test:sg-executor" cannot
create resource "persistentvolumeclaims" in API group "" in the namespace
"sourcegraph-test"
```
## Solution
Add missing `persistentvolumeclaims` permissions (`create`/`delete` /
`get` / `list`) that the executor needs for batch change job execution,
based on customer's working role configuration.
### Checklist
- [x] Follow the [manual testing
process](https://github.com/sourcegraph/deploy-sourcegraph-helm/blob/main/TEST.md)
- [ ] Update
[changelog](https://github.com/sourcegraph/deploy-sourcegraph-helm/blob/main/charts/sourcegraph/CHANGELOG.md)
(NOT NECESSARY)
- [ ] Update [Kubernetes update
doc](https://docs.sourcegraph.com/admin/updates/kubernetes) (NOT
NECESSARY)
### Test plan
- [x] Follow the [manual testing
process](https://github.com/sourcegraph/deploy-sourcegraph-helm/blob/main/TEST.md)
<!--
As part of SOC2/GN-104 and SOC2/GN-105 requirements, all pull requests
are REQUIRED to
provide a "test plan". A test plan is a loose explanation of what you
have done or
implemented to test this, as outlined in our Testing principles and
guidelines:
https://docs.sourcegraph.com/dev/background-information/testing_principles
Write your test plan here after the "Test plan" header.
-->
---------
Co-authored-by: Alex Jean-Baptiste Jr <alex@Alexs-MacBook-Pro-3.local>
Co-authored-by: Enrique Gonzalez <enrique@sourcegraph.com>1 parent 3121258 commit 4031ec0
1 file changed
+3
-0
lines changedLines changed: 3 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
| 32 | + | |
32 | 33 | | |
| 34 | + | |
| 35 | + | |
33 | 36 | | |
34 | 37 | | |
35 | 38 | | |
0 commit comments