Provide the option to not define REDIS_CACHE_ENDPOINT or REDIS_STORE_ENDPOINT env vars at all, if they're not using k8s secrets, and need to inject custom endpoints (ex. external Redis, with creds in endpoint string) as env vars by their own external means

Author: marcleblanc2

charts/sourcegraph/templates/_helpers.tpl

@@ -248,12 +248,24 @@ app.kubernetes.io/name: jaeger
   value: "localhost:$(DATA_SOURCE_PORT)/$(DATA_SOURCE_DB)?sslmode=disable"
 {{- end }}
 
+{{/*
+Set redisCache and redisStore endpoints
+So that customers can configure them any of these ways:
+1. Create a new Kubernetes secret, with default values (default, no override config required)
+2. Use an existing Kubernetes secret, by configuring .Values.redisCache.connection.existingSecret
+3. Do not create or use Kubernetes secrets, just pass the default values directly as environment variables into the needed pods, by configuring .Values.sourcegraph.disableKubernetesSecrets = true
+4. Do not create or use Kubernetes secrets, but pass custom values (ex. external Redis) directly as environment variables into the needed pods, by configuring .Values.sourcegraph.disableKubernetesSecrets = true, .Values.redisCache.connection.endpoint = "", .Values.redisStore.connection.endpoint = "", and defining the REDIS_CACHE_ENDPOINT and REDIS_STORE_ENDPOINT env vars on frontend, gitserver, searcher, and worker pods
+*/}}
 {{- define "sourcegraph.redisConnection" -}}
 {{- if .Values.sourcegraph.disableKubernetesSecrets -}}
+{{- if .Values.redisCache.connection.endpoint -}}
 - name: REDIS_CACHE_ENDPOINT
   value: {{ .Values.redisCache.connection.endpoint }}
+{{- end -}}
+{{- if .Values.redisStore.connection.endpoint -}}
 - name: REDIS_STORE_ENDPOINT
   value: {{ .Values.redisStore.connection.endpoint }}
+{{- end -}}
 {{- else -}}
 - name: REDIS_CACHE_ENDPOINT
   valueFrom: