chore(e2e): review comments applied

Author: Krzysztof Wojnar

scripts/e2e/detox-utils.cjs

@@ -12,10 +12,10 @@ const apkBulidArchitecture = isRunningCI ? 'x86_64' : 'arm64-v8a';
 const testButlerApkPath = isRunningCI ? ['../Example/e2e/apps/test-butler-app-2.2.1.apk'] : undefined;
 
 function detectLocalAndroidEmulator() {
-  // "DETOX_ADB_NAME" can be set for local developement
-  const detoxAdbName = process.env.DETOX_ADB_NAME ?? null;
-  if (detoxAdbName !== null) {
-    return detoxAdbName
+  // "DETOX_AVD_NAME" can be set for local developement
+  const detoxAvdName = process.env.DETOX_AVD_NAME ?? null;
+  if (detoxAvdName !== null) {
+    return detoxAvdName
   }
 
   // Fallback: try to use Android SDK
@@ -37,14 +37,14 @@ function detectLocalAndroidEmulator() {
     // TODO: consider giving user a choice here.
     return avdList[0];
   } catch (error) {
-    const errorMessage = `Failed to find Android emulator. Set "DETOX_ADB_NAME" env variable pointing to one. Cause: ${error}`
+    const errorMessage = `Failed to find Android emulator. Set "DETOX_AVD_NAME" env variable pointing to one. Cause: ${error}`
     console.error(errorMessage);
     throw new Error(errorMessage);
   }
 }
 
 function detectAndroidEmulatorName() {
-  return isRunningCI ? CI_ADB_NAME : detectLocalAndroidEmulator();
+  return isRunningCI ? CI_ADB_NAME : detectLocalAndroidEmulator(); // ??
 }
 
 /**

scripts/e2e/ios-devices.js

@@ -1,19 +1,24 @@
-const DEFAULT_APPLE_MODEL = 'iPhone 17';
-const DEVICE_MODEL = process.env.E2E_APPLE_DEVICE || DEFEAULT_APPLE_MODEL
+const DEFAULT_APPLE_DEVICE = 'iPhone 17';
 const DEFEAULT_IOS_VERSION = 'iOS 26.2';
 
+/**
+ * @return {string}
+ */
+function getAppleDevice() {
+  return process.env.E2E_APPLE_DEVICE || DEFAULT_APPLE_DEVICE;
+}
 /**
  * @return {`iOS ${string}`} requested version of ios, or default if not specified
  */
 function getIOSVersion() {
-    const passedVersion = process.env.E2E_IOS_VERSION;
-    if (passedVersion) {
-        if (passedVersion.startsWith('iOS ')) {
-          return /** @type {`iOS ${string}`} */ (passedVersion);
-        }
-        return `iOS ${passedVersion}`;
+  const passedVersion = process.env.E2E_IOS_VERSION;
+  if (passedVersion) {
+    if (passedVersion.startsWith('iOS ')) {
+      return /** @type {`iOS ${string}`} */ (passedVersion);
     }
-    return DEFEAULT_IOS_VERSION;
+    return `iOS ${passedVersion}`;
+  }
+  return DEFEAULT_IOS_VERSION;
 }
 
 /**
@@ -22,16 +27,15 @@ function getIOSVersion() {
  * @property {`iOS ${string}`} os - operation system version
  */
 
-/** 
+/**
  * @satisfies {AppleDevice}
  * @readonly
  * */
 const iosDevice = {
-  type: DEVICE_MODEL,
-  os: getiosVersion(),
+  type: getAppleDevice(),
+  os: getIOSVersion(),
 };
 
 module.exports = {
   iosDevice,
-  getiosVersion,
 };