fix(iOS, Tabs): remove incorrect warning on none environment in Bottom Accessory (#3416)

## Description

Removes incorrect warning when bottom accessory enters `none`
environment. Reasoning is explained here:
#3411 (comment).

Thanks to @johankasperi for letting us know about the bug.

| before | after |
| --- | --- |
| <video
src="https://github.com/user-attachments/assets/92c04ce5-742c-4426-8354-595918e95132"
/> | <video
src="https://github.com/user-attachments/assets/6e7c191d-f76d-4640-80df-3d7514451bfe"
/>

Supersedes
#3411.

## Changes

- remove warning

## Test code and steps to reproduce

Run `Test3288`. Hide the bottom accessory.

## Checklist

- [x] Included code example that can be used to test this change
- [ ] Ensured that CI passes

Author: kligarski

ios/bottom-tabs/accessory/RNSBottomTabsAccessoryEventEmitter.mm

@@ -44,7 +44,12 @@ - (BOOL)emitOnEnvironmentChangeIfNeeded:(UITabAccessoryEnvironment)environment A
         rnscreens::conversion::RNSBottomTabsAccessoryOnEnvironmentChangePayloadFromUITabAccessoryEnvironment(
             environment);
 
-    _reactEventEmitter->onEnvironmentChange({.environment = payloadEnvironment});
+    // If environment is other than `regular` or `inline`, we don't emit the event.
+    if (!payloadEnvironment.has_value()) {
+      return NO;
+    }
+
+    _reactEventEmitter->onEnvironmentChange({.environment = payloadEnvironment.value()});
     return YES;
   } else {
     RCTLogWarn(@"[RNScreens] Skipped OnEnvironmentChange event emission due to nullish emitter");
@@ -56,6 +61,11 @@ - (BOOL)emitOnEnvironmentChangeIfNeeded:(UITabAccessoryEnvironment)environment A
         rnscreens::conversion::RNSBottomTabsAccessoryOnEnvironmentChangePayloadFromUITabAccessoryEnvironment(
             environment);
 
+    // If environment is other than `regular` or `inline`, we don't emit the event.
+    if (environmentString == nil) {
+      return NO;
+    }
+
     self.onEnvironmentChange(@{@"environment" : environmentString});
     return YES;
   } else {

ios/conversion/RNSConversions-BottomTabs.mm

@@ -405,7 +405,7 @@ RNSScrollEdgeEffect RNSBottomTabsScrollEdgeEffectFromBottomTabsScreenTopScrollEd
 
 #if RCT_NEW_ARCH_ENABLED
 API_AVAILABLE(ios(26.0))
-react::RNSBottomTabsAccessoryEventEmitter::OnEnvironmentChangeEnvironment
+std::optional<react::RNSBottomTabsAccessoryEventEmitter::OnEnvironmentChangeEnvironment>
 RNSBottomTabsAccessoryOnEnvironmentChangePayloadFromUITabAccessoryEnvironment(UITabAccessoryEnvironment environment)
 {
   switch (environment) {
@@ -414,8 +414,8 @@ RNSScrollEdgeEffect RNSBottomTabsScrollEdgeEffectFromBottomTabsScreenTopScrollEd
     case UITabAccessoryEnvironmentInline:
       return react::RNSBottomTabsAccessoryEventEmitter::OnEnvironmentChangeEnvironment::Inline;
     default:
-      RCTLogError(@"[RNScreens] Unsupported environment for onEnvironmentChange event");
-      return react::RNSBottomTabsAccessoryEventEmitter::OnEnvironmentChangeEnvironment::Regular;
+      // We want to ignore other environments (e.g. `none`), that's why there is no warning here.
+      return std::nullopt;
   }
 }
 
@@ -446,7 +446,7 @@ RNSBottomTabsAccessoryEnvironment RNSBottomTabsAccessoryEnvironmentFromCppEquiva
 NSString *RNSBottomTabsAccessoryOnEnvironmentChangePayloadFromUITabAccessoryEnvironment(
     UITabAccessoryEnvironment environment)
 {
-  NSString *environmentString = nil;
+  NSString *environmentString;
   switch (environment) {
     case UITabAccessoryEnvironmentRegular:
       environmentString = BOTTOM_TABS_ACCESSORY_REGULAR_ENVIRONMENT;
@@ -455,7 +455,8 @@ RNSBottomTabsAccessoryEnvironment RNSBottomTabsAccessoryEnvironmentFromCppEquiva
       environmentString = BOTTOM_TABS_ACCESSORY_INLINE_ENVIRONMENT;
       break;
     default:
-      RCTLogError(@"[RNScreens] Unsupported environment for onEnvironmentChange event");
+      // We want to ignore other environments (e.g. `none`), that's why there is no warning here.
+      environmentString = nil;
       break;
   }
 

ios/conversion/RNSConversions.h

@@ -77,7 +77,7 @@ RNSScrollEdgeEffect RNSBottomTabsScrollEdgeEffectFromBottomTabsScreenTopScrollEd
 
 #if RCT_NEW_ARCH_ENABLED
 API_AVAILABLE(ios(26.0))
-react::RNSBottomTabsAccessoryEventEmitter::OnEnvironmentChangeEnvironment
+std::optional<react::RNSBottomTabsAccessoryEventEmitter::OnEnvironmentChangeEnvironment>
 RNSBottomTabsAccessoryOnEnvironmentChangePayloadFromUITabAccessoryEnvironment(UITabAccessoryEnvironment environment);
 
 #if REACT_NATIVE_VERSION_MINOR >= 82