chore(e2e): avd name does NOT come from CI env variables

Author: Krzysztof Wojnar

.github/workflows/android-e2e-test-fabric.yml

@@ -86,7 +86,7 @@ jobs:
           disable-animations: false
           force-avd-creation: false
           emulator-options: -no-window -gpu swiftshader_indirect -noaudio -no-boot-anim -camera-back none
-          rns_e2e_avd_name: e2e_emulator
+          avd-name: e2e_emulator
           arch: x86_64
           script: echo "Generated AVD snapshot for caching."
 
@@ -102,7 +102,7 @@ jobs:
           disable-animations: false
           force-avd-creation: false
           emulator-options: -no-window -gpu swiftshader_indirect -noaudio -no-boot-anim -camera-back none
-          rns_e2e_avd_name: e2e_emulator
+          avd-name: e2e_emulator
           arch: x86_64
           script: yarn test-e2e-android
 

.github/workflows/android-e2e-test.yml

@@ -86,7 +86,7 @@ jobs:
           disable-animations: false
           force-avd-creation: false
           emulator-options: -no-window -gpu swiftshader_indirect -noaudio -no-boot-anim -camera-back none
-          rns_e2e_avd_name: e2e_emulator
+          avd-name: e2e_emulator
           arch: x86_64
           script: echo "Generated AVD snapshot for caching."
 
@@ -102,7 +102,7 @@ jobs:
           disable-animations: false
           force-avd-creation: false
           emulator-options: -no-window -gpu swiftshader_indirect -noaudio -no-boot-anim -camera-back none
-          rns_e2e_avd_name: e2e_emulator
+          avd-name: e2e_emulator
           arch: x86_64
           script: yarn test-e2e-android
 

scripts/e2e/detox-utils.cjs

@@ -39,9 +39,8 @@ function detectLocalAndroidEmulator() {
 
 function detectAndroidEmulatorName() {
   // "RNS_E2E_AVD_NAME" can be set for local developement
-  return process.env.RNS_E2E_AVD_NAME || isRunningCI
-    ? DEFAULT_CI_AVD_NAME
-    : detectLocalAndroidEmulator();
+  if (isRunningCI) return DEFAULT_CI_AVD_NAME;
+  return process.env.RNS_E2E_AVD_NAME || detectLocalAndroidEmulator();
 }
 
 /**