Skip to content

Change components implementation #3800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
m-bert merged 61 commits into from
Dec 3, 2025
Merged

Change components implementation #3800

m-bert merged 61 commits into from
Dec 3, 2025
+1,654 −488

Conversation

@m-bert
Copy link
Contributor

@m-bert m-bert commented Nov 4, 2025 •
edited
Loading

Description

This PR changes components implementations to use new hooks API.

Warning

It requires changes in module on iOS - call createGestureHandler immediately, not adding operation block.

Test plan

Example apps

@m-bert m-bert mentioned this pull request Nov 13, 2025
Merged
m-bert added a commit that referenced this pull request Nov 17, 2025
@m-bert
[iOS] Remove dropped native handlers (#3819)
2a90922 
## What is happening

While working on #3800 I've noticed frequent crashes on `iOS`. I'll
explain this using the demo from the test code, basically two screens,
second screen has a `RectButton`.

1. Navigate to second screen
2. Go back
3. Navigate to the second screen again
4. App crashes

Sometime it crashes immediately on startup.

## Why is it happening?

`Native` handlers are handled differently compared to others. The main
problem was that we tried to attach handler that was previously dropped,
but `NativeDetector` has no information that this happened. The flow
here looks as follows:

1. We navigate to screen with button
2. `addSubview` is called - at this point it won't attach anything as
`_nativeHandlers` is empty
3. `updateProps` is called - handlers are attached
4. We navigate back to first screen
5. Handler is dropped
6. We navigate again to second screen
7. `addSubview` is called - it tries to attach handler that was dropped,
therefore app crashes

## Solution

To fix this issue, we clear `_nativeHandlers` in `prepareForRecycle`
method.

## Test plan

<details>
<summary>I've tested it on my branch with components re-written to new
API, using the following code in EmptyExample:</summary>

```tsx
import React from 'react';
import { StyleSheet, View } from 'react-native';
import { RectButton } from 'react-native-gesture-handler';

export default function EmptyExample() {
  return (
    <View style={styles.container}>
      <RectButton
        style={styles.button}
        onPress={() => console.log('Hello World!')}
      />
    </View>
  );
}

const styles = StyleSheet.create({
  container: {
    flex: 1,
    justifyContent: 'center',
    alignItems: 'center',
  },
  button: {
    width: 100,
    height: 30,
    borderRadius: 10,
    backgroundColor: 'pink',
  },
});
```

</details>
@m-bert m-bert requested a review from akwasniewski November 24, 2025 14:45
j-piasecki
j-piasecki reviewed Nov 26, 2025
View reviewed changes
m-bert and others added 2 commits November 26, 2025 18:55
@m-bert @j-piasecki
Update packages/react-native-gesture-handler/src/v3/components/Gestur…
e84f3cf 
…eComponents.tsx

Co-authored-by: Jakub Piasecki <jakub.piasecki@swmansion.com>
@m-bert
Always assign hostDetectorView
110d333
j-piasecki
j-piasecki reviewed Dec 2, 2025
View reviewed changes
@m-bert m-bert merged commit 71ab149 into next Dec 3, 2025
8 checks passed
@m-bert m-bert deleted the @mbert/components-new-api branch December 3, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akwasniewski akwasniewski akwasniewski left review comments

@j-piasecki j-piasecki j-piasecki approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@m-bert @j-piasecki @akwasniewski