Skip to content

Commit 427eeb3

Browse files
author
Maciej Makowski
committed
fix: fixed visibility of jsi object in PeriodicWave
1 parent 5cf240b commit 427eeb3

File tree

4 files changed

+4
-9
lines changed

4 files changed

+4
-9
lines changed

packages/react-native-audio-api/common/cpp/core/AudioScheduledSourceNode.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
#pragma once
22

3+
#include <algorithm>
34
#include <atomic>
45
#include <chrono>
56
#include <functional>
67
#include <iostream>
8+
#include <limits>
79
#include <memory>
810
#include <thread>
9-
#include <limits>
10-
#include <algorithm>
1111

1212
#include "AudioNode.h"
1313

packages/react-native-audio-api/common/cpp/jsi/JsiHostObject.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,6 @@ JsiHostObject::JsiHostObject() {
1212
propertySetters_ = std::make_unique<std::unordered_map<
1313
std::string,
1414
void (JsiHostObject::*)(jsi::Runtime &, const jsi::Value &)>>();
15-
16-
propertyGetters_->insert(JSI_EXPORT_PROPERTY_GETTER(JsiHostObject, then));
1715
}
1816

1917
std::vector<jsi::PropNameID> JsiHostObject::getPropertyNames(jsi::Runtime &rt) {

packages/react-native-audio-api/common/cpp/jsi/JsiHostObject.h

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,10 @@
22

33
#include <jsi/jsi.h>
44
#include <memory>
5+
#include <string>
56
#include <unordered_map>
67
#include <utility>
78
#include <vector>
8-
#include <string>
99

1010
#define JSI_HOST_FUNCTION(NAME) \
1111
jsi::Value NAME( \
@@ -70,10 +70,6 @@ class JsiHostObject : public jsi::HostObject {
7070
(propertyFunctions_->insert(args), ...);
7171
}
7272

73-
JSI_PROPERTY_GETTER(then) {
74-
return jsi::Value::undefined();
75-
}
76-
7773
protected:
7874
std::unique_ptr<std::unordered_map<
7975
std::string,

packages/react-native-audio-api/src/index.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -294,6 +294,7 @@ export class BiquadFilterNode extends AudioNode {
294294
}
295295

296296
export class PeriodicWave {
297+
/** @internal */
297298
readonly periodicWave: globalThis.PeriodicWave;
298299

299300
constructor(periodicWave: globalThis.PeriodicWave) {

0 commit comments

Comments
 (0)