fix: fixed jsi promise (#296)

Co-authored-by: Maciej Makowski <maciej.makowski2608@gmail.com>

Author: maciejmakowski2003

packages/react-native-audio-api/common/cpp/HostObjects/BaseAudioContextHostObject.h

@@ -143,20 +143,16 @@ class BaseAudioContextHostObject : public JsiHostObject {
   JSI_HOST_FUNCTION(decodeAudioDataSource) {
     auto sourcePath = args[0].getString(runtime).utf8(runtime);
 
-    auto promise = promiseVendor_->createPromise(
-        [this, &runtime, sourcePath](std::shared_ptr<Promise> promise) {
-          std::thread([this,
-                       &runtime,
-                       sourcePath,
-                       promise = std::move(promise)]() {
-            auto results = context_->decodeAudioDataSource(sourcePath);
-            auto audioBufferHostObject =
-                std::make_shared<AudioBufferHostObject>(results);
-
-            promise->resolve(jsi::Object::createFromHostObject(
-                runtime, audioBufferHostObject));
-          }).detach();
+    auto promise = promiseVendor_->createPromise([this, sourcePath](std::shared_ptr<Promise> promise) {
+      std::thread([this, sourcePath, promise = std::move(promise)]() {
+        auto results = context_->decodeAudioDataSource(sourcePath);
+        auto audioBufferHostObject = std::make_shared<AudioBufferHostObject>(results);
+
+        promise->resolve([audioBufferHostObject = std::move(audioBufferHostObject)](jsi::Runtime &runtime) {
+          return jsi::Object::createFromHostObject(runtime, audioBufferHostObject);
         });
+      }).detach();
+    });
 
     return promise;
   }

packages/react-native-audio-api/common/cpp/jsi/JsiPromise.cpp

@@ -36,9 +36,12 @@ jsi::Value PromiseVendor::createPromise(
         auto reject = std::make_shared<jsi::Function>(std::move(rejectLocal));
 
         auto resolveWrapper =
-            [resolve, &runtime, callInvoker](jsi::Value value) -> void {
-          auto valueShared = std::make_shared<jsi::Value>(std::move(value));
-          callInvoker->invokeAsync([resolve, &runtime, valueShared]() -> void {
+            [resolve, &runtime, callInvoker](
+                const std::function<jsi::Value(jsi::Runtime &)> resolver)
+            -> void {
+          callInvoker->invokeAsync([resolve, &runtime, resolver]() -> void {
+            auto valueShared = std::make_shared<jsi::Value>(resolver(runtime));
+
             resolve->call(runtime, *valueShared);
           });
         };

packages/react-native-audio-api/common/cpp/jsi/JsiPromise.h

@@ -13,33 +13,26 @@ using namespace facebook;
 
 class Promise {
  public:
-  Promise(
-      std::function<void(jsi::Value)> resolve,
-      std::function<void(const std::string &)> reject)
-      : resolve_(std::move(resolve)), reject_(std::move(reject)) {}
+  Promise(std::function<void(const std::function<jsi::Value(jsi::Runtime&)>)> resolve, std::function<void(const std::string &)> reject) : resolve_(std::move(resolve)), reject_(std::move(reject)) {}
 
-  void resolve(jsi::Value &&value) {
-    resolve_(std::forward<jsi::Value>(value));
+  void resolve(const std::function<jsi::Value(jsi::Runtime&)> &resolver) {
+    resolve_(std::forward<const std::function<jsi::Value(jsi::Runtime&)>>(resolver));
   }
+
   void reject(const std::string &errorMessage) {
     reject_(errorMessage);
   }
 
  private:
-  std::function<void(jsi::Value)> resolve_;
+  std::function<void(const std::function<jsi::Value(jsi::Runtime&)>)> resolve_;
   std::function<void(const std::string &)> reject_;
 };
 
 class PromiseVendor {
  public:
-  PromiseVendor(
-      jsi::Runtime *runtime,
-      const std::shared_ptr<react::CallInvoker> &callInvoker)
-      : runtime_(runtime), callInvoker_(callInvoker) {}
+  PromiseVendor(jsi::Runtime *runtime, const std::shared_ptr<react::CallInvoker> &callInvoker): runtime_(runtime), callInvoker_(callInvoker) {}
 
- public:
-  jsi::Value createPromise(
-      const std::function<void(std::shared_ptr<Promise>)> &function);
+  jsi::Value createPromise(const std::function<void(std::shared_ptr<Promise>)> &function);
 
  private:
   jsi::Runtime *runtime_;